From patchwork Sat Jun 29 04:53:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13716812 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD07AC27C4F for ; Sat, 29 Jun 2024 04:59:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:To:From:Subject :References:Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5I8Dk3Jx18DLwgnut7bHcO920rFAKP8Txv5pQFBGNLA=; b=kuaDuCG46qdpwtqpJcZGVNlX+w StxL+BW1MFaGWqWBRVwF2C8Wwve+AQ0+Il6lVgv+5zQp2PjtdqNB/THAsWqbQ9k5QSQLfTvM3hUbg PGcI2w/eY3JDQ0Wf5hIp9no8RZPWEdmu1KqQuYZQAE5qf0FrGgRp2EnFfGFGatSIqfsCRMZvOBFs0 pwtCLMxC2xIjvF8jk4wcFrEd4gtI27ajGqTD2D7BR0hERXYiHylYxoV/NmWwf0FTjRSVsA5lsrkH0 7ZPAz+3skWV6Rxq1gAPpFYQeYhpqEb+OHVlW6wAkDxB5GrZ65z7U9LZc04LWzf5wHetIirr7McTu/ DENZqF7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNQB1-0000000FtcD-31yf; Sat, 29 Jun 2024 04:59:07 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNQ7E-0000000FreG-2YmA for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 04:55:13 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-64a489c5042so20524967b3.1 for ; Fri, 28 Jun 2024 21:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719636911; x=1720241711; darn=lists.infradead.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=5I8Dk3Jx18DLwgnut7bHcO920rFAKP8Txv5pQFBGNLA=; b=VJKp3NUKh1pVmpPq5uoIWnqWB/7ZrkQTxCRAV6e681hkgEepFhwTEapzMakWUBz+cm yxLZ3d/8f32WKNAEgvcffATGmSNT2L+FqQgM0ZqnrndH6vJLCluw8nIdIH1bJuXsFbvZ asxTnKdVuUrwD13ylpc2Htz/pUkQk67JcALwAMYmQ+C/mVvc4V2UtAfks31DZ0BKMQfY I/8PD5ZKN9emBWKwirtukZur4jGpBxn+cAtXZwIbUd7MNhmjdVskuOi4TpYxT4nuUfKz uTejzzQxyqM4zzQJ/kfzhlWqNoS++JeO48CcDX1wY+e1nShM3YPVGrynvAeR80lSqJ/s 8VVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719636911; x=1720241711; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5I8Dk3Jx18DLwgnut7bHcO920rFAKP8Txv5pQFBGNLA=; b=bdWHy6XnbHuaPkRbtkyZjszU+LGJ7UfZt/4iA38RSmHrmRfr98CK51JX0UX7+LvHiY gff/1xslqC4Vq/loGNy/LryAR0cki6VTdbvf7y1Yg0y+yObivqPy5wqULPxjb4mU9OOT CD6KuF4eUOKWNtsOuNLuqHfDj7V1pLRbhaIlFrU/PfBhf3er/0C6JqiO4LgYLPMBuSxJ gATSOnOhaPE1b0n8+lcONf833zjZHSvhKwyGQE5VwiQVUVmLVgWVI72CwZpLdq6iJQIt J5eZNZPDR21UZrffklEBBs6Dw4IBluf16j7F7+qvUeRwzh5Aunnz1OxMM2UNvwSl6Svw 0+OQ== X-Forwarded-Encrypted: i=1; AJvYcCUeeX5tyZuokJ/OZV5wM2RBf3NKev2cUvfCOmhgoX7hpYkPt7asApZtfPOAPJ/tNZ3W9JaJH5tlAuUBVT4kdtbZMnNVrSfJNZYtZEb2z8RBTGQ4EAg= X-Gm-Message-State: AOJu0YzL8KjTWrB3HphuLwk0ub3EIeTv44cPTzMrE/FGBJOYrpW+UBwY MldEZ9Hz0sQQzbVXNGeIYEolxf/WY1WeLh6n3JxJf0ohK8gEcz1JyT0dRtS8PLhejNbOAWSMGJA /IC+tNA== X-Google-Smtp-Source: AGHT+IHlhj9A+3l7M0c3Zsg//bzFK4sGoQmqySkzynjsb5X2abAc4H7qqAulmEHW+TVVXLld2Zhy5UyS6h0g X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:f9fe:7acd:496e:4edb]) (user=irogers job=sendgmr) by 2002:a05:6902:150d:b0:e03:554e:f396 with SMTP id 3f1490d57ef6-e036eb5c458mr765276.6.1719636910826; Fri, 28 Jun 2024 21:55:10 -0700 (PDT) Date: Fri, 28 Jun 2024 21:53:50 -0700 In-Reply-To: <20240629045350.285243-1-irogers@google.com> Message-Id: <20240629045350.285243-29-irogers@google.com> Mime-Version: 1.0 References: <20240629045350.285243-1-irogers@google.com> X-Mailer: git-send-email 2.45.2.803.g4e1b14247a-goog Subject: [PATCH v3 28/28] perf session: Constify tool From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_215512_684698_B3267289 X-CRM114-Status: GOOD ( 14.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Make tool const now that all uses are const and perf_tool__fill_defaults won't be used. The aim is to better capture that sessions don't mutate tools. Signed-off-by: Ian Rogers --- tools/perf/util/session.c | 6 +++--- tools/perf/util/session.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 6f5692902892..e0eec409e951 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c @@ -1771,7 +1771,7 @@ static int __perf_session__process_decomp_events(struct perf_session *session); static int __perf_session__process_pipe_events(struct perf_session *session) { struct ordered_events *oe = &session->ordered_events; - struct perf_tool *tool = session->tool; + const struct perf_tool *tool = session->tool; union perf_event *event; uint32_t size, cur_size = 0; void *buf = NULL; @@ -2183,7 +2183,7 @@ static int __perf_session__process_events(struct perf_session *session) .in_place_update = session->data->in_place_update, }; struct ordered_events *oe = &session->ordered_events; - struct perf_tool *tool = session->tool; + const struct perf_tool *tool = session->tool; struct ui_progress prog; int err; @@ -2233,7 +2233,7 @@ static int __perf_session__process_events(struct perf_session *session) static int __perf_session__process_dir_events(struct perf_session *session) { struct perf_data *data = session->data; - struct perf_tool *tool = session->tool; + const struct perf_tool *tool = session->tool; int i, ret, readers, nr_readers; struct ui_progress prog; u64 total_size = perf_data__size(session->data); diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h index 7f69baeae7fb..7c8dd6956330 100644 --- a/tools/perf/util/session.h +++ b/tools/perf/util/session.h @@ -43,7 +43,7 @@ struct perf_session { u64 one_mmap_offset; struct ordered_events ordered_events; struct perf_data *data; - struct perf_tool *tool; + const struct perf_tool *tool; u64 bytes_transferred; u64 bytes_compressed; struct zstd_data zstd_data;