From patchwork Mon Jul 1 12:43:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vitor Soares X-Patchwork-Id: 13718031 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06E2BC30653 for ; Mon, 1 Jul 2024 12:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=X9oUdv7urUmTInH8QMPbAXnIwXW+SLweFqKTOXeU2hk=; b=36Gqm1iWS5r9eDrSFhEScZxXyh N6PWi+E9I2ycUk4AKNAg0jrJbGm9qLfDklLdR9nfwmfe3A+mruBa/HP8Dpo4fvr8EvDB/g2McPDmH TfpPpgjeZKyXXBtbEpfewi6Ty7I4hFLo84x81D82onr8qxZd2AT5DJS6snGqumxrWDm3Av/sODnRo 8KL2Rd7M2KczTqqzTFdG8VgwlILvnAKbJaZcOLHYOR12/J8FsgPIFVEVopZskoGCCHVIt2LQ5U/Yn IxfT+k0FFLQ+QjCdLv+nj7K+kSDxApbfx5YQZ1fx4PMq9psA6vVl+UFSOVw12FU/4QzTCKkDM9pQD PXZ6ylNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOGOZ-00000003Jnk-3cDK; Mon, 01 Jul 2024 12:44:35 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOGOO-00000003Jk1-3LX8 for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 12:44:26 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-42561c16ffeso23135455e9.3 for ; Mon, 01 Jul 2024 05:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719837863; x=1720442663; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=X9oUdv7urUmTInH8QMPbAXnIwXW+SLweFqKTOXeU2hk=; b=LN3uHzbZnwXj9zHfItzYcHBj3l7MprgTGXUsWCKDMZUwjBUdxC+cHohtrhgPmNILcY AZOgWdITAW4asJr0Jg2vsCuSxBTwB8nQZCjb/yvJy5lEsMp1EMBYT261M2Gw3QHIN8TR 2OhFEojFNiV0QP4nnbA/NLW2Qb86xlkwxWcS5qhT4BixYH0a8ch5b2c24rjdYGvGkabz pgoLPMXsulFczLmZXRxbmpnLfkva95I3VxfT0GOrE4VU4y8P2/1aui4tReDtGBi/A3YK eCxzzhlb80G33lNSNgu4PQ4PDR6PxvJHqm//f5P76gcxDEODzB4xDS5uNKrCaX/4XwRk ffiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719837863; x=1720442663; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X9oUdv7urUmTInH8QMPbAXnIwXW+SLweFqKTOXeU2hk=; b=V2ORy2jN6u5Ck8/sUu6gqkmBLaApvfd5vH+H8u9ohm5Ue/ZbJGKegW3yoaElBNgSYU X2mOhWARghj/rT5QLfeJX4+VAJRAU/zkdRqV41NF5sDuC6z/13lb3cErDtFgrrkm7XD1 Iu45GQXTc8s81xCC9wk3pS/1h5KQcawN3mHq7fltkTRhb9RjFOomS+g2qJ7s8RiVuxc2 frgfNVMHCEG/AQGepQrtsBVKcdpvfEz1bt5Th3e6mgTeR+j82v0KQGC8Ijf7GqOqTVTv VgXuiEHlKRCsosb1MaG47JTQtIxD2Rpx4IhbU+cczptDZ1PKi7TPqBos2rcvRXPq961t pnMw== X-Forwarded-Encrypted: i=1; AJvYcCXoaTOF1DjT4gsL3OynzxN1h3a8I4c9WeePE6EnnHs5sFUj7Y7yU49wzni+ZTvW448ZAfH+etfrE4NpE7KDSPxngFz66Z5LSKnTHiNB1HjPLSj+tk4= X-Gm-Message-State: AOJu0YyKGjfAlL84bAvBY5Hev0Olj8+oPCXJQS8/fIjtyk4J6LnHOVwi 80pzt62FxryrqU0UN9Yn+lita01xqEGbsHfye7aQm3yQ6V+mtd2L X-Google-Smtp-Source: AGHT+IG/m5dh7OIdKUq1Jt30kdZeI3XnThzntipad3x9UGAxTUw1PaxNZ2+WOT85Dz5soydlYmB7ow== X-Received: by 2002:a05:600c:4c14:b0:424:f2b9:81f5 with SMTP id 5b1f17b1804b1-4257a028321mr36950435e9.9.1719837862346; Mon, 01 Jul 2024 05:44:22 -0700 (PDT) Received: from vitor-nb.. ([2001:8a0:e622:f700:f55c:ea59:1259:5240]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0e16b3sm9921005f8f.61.2024.07.01.05.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 05:44:21 -0700 (PDT) From: Vitor Soares To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Ulf Hansson Cc: Vitor Soares , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, ivitro@gmail.com, stable@vger.kernel.org, Lucas Stach Subject: [PATCH v1] arm64: dts: imx8mp: Fix VPU PGC power-domain parents Date: Mon, 1 Jul 2024 13:43:02 +0100 Message-Id: <20240701124302.16520-1-ivitro@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_054424_863930_C556C341 X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Vitor Soares On iMX8M Plus QuadLite (VPU-less SoC), the dependency between VPU power domains lead to a deferred probe error during boot: [ 17.140195] imx-pgc imx-pgc-domain.8: failed to command PGC [ 17.147183] platform imx-pgc-domain.11: deferred probe pending: (reason unknown) [ 17.147200] platform imx-pgc-domain.12: deferred probe pending: (reason unknown) [ 17.147207] platform imx-pgc-domain.13: deferred probe pending: (reason unknown) This is incorrect and should be the VPU blk-ctrl controlling these power domains, which is already doing it. After removing the `power-domain` property from the VPU PGC nodes, both iMX8M Plus w/ and w/out VPU boot correctly. However, it breaks the suspend/resume functionality. A fix for this is pending, see Links. Cc: Fixes: df680992dd62 ("arm64: dts: imx8mp: add vpu pgc nodes") Link: https://lore.kernel.org/all/fcd6acc268b8642371cf289149b2b1c3e90c7f45.camel@pengutronix.de/ Link: https://lore.kernel.org/all/20240418155151.355133-1-ivitro@gmail.com/ Suggested-by: Lucas Stach Signed-off-by: Vitor Soares --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index b92abb5a5c53..12548336b736 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -882,21 +882,18 @@ pgc_vpumix: power-domain@19 { pgc_vpu_g1: power-domain@20 { #power-domain-cells = <0>; - power-domains = <&pgc_vpumix>; reg = ; clocks = <&clk IMX8MP_CLK_VPU_G1_ROOT>; }; pgc_vpu_g2: power-domain@21 { #power-domain-cells = <0>; - power-domains = <&pgc_vpumix>; reg = ; clocks = <&clk IMX8MP_CLK_VPU_G2_ROOT>; }; pgc_vpu_vc8000e: power-domain@22 { #power-domain-cells = <0>; - power-domains = <&pgc_vpumix>; reg = ; clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>; };