| Message ID | 20240701142851.1448515-2-luke.parkin@arm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Per-transport SCMI debug statistics | expand |
On Mon, Jul 01, 2024 at 03:28:49PM +0100, Luke Parkin wrote: > Add a new config option for statistic tracking in SCMI subsystem. > > Signed-off-by: Luke Parkin <luke.parkin@arm.com> > --- > drivers/firmware/arm_scmi/Kconfig | 10 ++++++++++ > 1 file changed, 10 insertions(+) > Hi, > diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig > index aa5842be19b2..fac50fd0be72 100644 > --- a/drivers/firmware/arm_scmi/Kconfig > +++ b/drivers/firmware/arm_scmi/Kconfig > @@ -55,6 +55,16 @@ config ARM_SCMI_RAW_MODE_SUPPORT_COEX > operate normally, thing which could make an SCMI test suite using the > SCMI Raw mode support unreliable. If unsure, say N. > > +config ARM_SCMI_DEBUG_STATISTICS > + bool "Enable SCMI Raw mode statistic tracking" I would add also a depends on DEBUG_FS like in RAW...and maybe in the future move such all of such depends on ARM_SCMI_NEED_DEBUGFS instead...but for now it is easier and less potentially disruptive to the build to just add a depends here. > + select ARM_SCMI_NEED_DEBUGFS > + help > + Enables statistic tracking for the SCMI subsystem. > + > + Enable this option to create a new debugfs directory which contains > + several useful statistics on various SCMI features. This can be useful > + for debugging and SCMI monitoring. If unsure, say N. > + Moreover you should move this Kconfig patch after the patches in the series that includes the logic underneath this...here really you are defining some option that, if enabled, at this point it really still does NOT enable anything. Thanks, Cristian
diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig index aa5842be19b2..fac50fd0be72 100644 --- a/drivers/firmware/arm_scmi/Kconfig +++ b/drivers/firmware/arm_scmi/Kconfig @@ -55,6 +55,16 @@ config ARM_SCMI_RAW_MODE_SUPPORT_COEX operate normally, thing which could make an SCMI test suite using the SCMI Raw mode support unreliable. If unsure, say N. +config ARM_SCMI_DEBUG_STATISTICS + bool "Enable SCMI Raw mode statistic tracking" + select ARM_SCMI_NEED_DEBUGFS + help + Enables statistic tracking for the SCMI subsystem. + + Enable this option to create a new debugfs directory which contains + several useful statistics on various SCMI features. This can be useful + for debugging and SCMI monitoring. If unsure, say N. + config ARM_SCMI_HAVE_TRANSPORT bool help
Add a new config option for statistic tracking in SCMI subsystem. Signed-off-by: Luke Parkin <luke.parkin@arm.com> --- drivers/firmware/arm_scmi/Kconfig | 10 ++++++++++ 1 file changed, 10 insertions(+)