From patchwork Mon Jul 1 17:02:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 13718459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5249BC2BD09 for ; Mon, 1 Jul 2024 17:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zEi1EfM2qJxxK8rxuTCuRpYgFpM0W5FhWMuSJQepi7s=; b=JlaGl9TxsSfAIHk18BQPa6fLIG 284vefC3glTO41f4u32BEyFRgX1RSylVmxly2whQGGf1EMTswCd8sIxhr3kUrD9+uRpdgU2TKYuQ8 5h/P4C52iRJ86x8JDozVXvqXFGYue8CaxaP1kPqew2SRbgozFe4K6FUpCGJOng3IQFH6L2U5BFZtO FZOp3sebVXywsl1t5y4Tl0Eo9Axq1jvYN/APX9lPStgRRl9v93u7zHO4xDQeWLiI2tWPRGx4lmg8d DYxnvR+FMgUoAfr5wcYaT6U63a49ssaz8f3rRoRjM3JyeDupuEvuRuDrJY2cfs/qILbXZTbzPdvEd olS0O7Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOKT3-00000004EXH-1k6Z; Mon, 01 Jul 2024 17:05:29 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOKRG-00000004Dbd-3LR9 for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 17:03:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 16B46CE1A4E; Mon, 1 Jul 2024 17:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F859C4AF0D; Mon, 1 Jul 2024 17:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719853416; bh=xAcKoKj6j0w+3Mz3dsiA2i61LBHBoOfcnwYOT78zV50=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JcsMgtCbWYwyl5le/IUP1CCOF55Xh58KgeWD7S6JN9rZ044drweMVhPk6VnxRgiRA UfwtxmAiRz/FWanzHV5VmjDbxDXIQE1PoO5ijgk84iqwN3Qd8yCNXtELU1Vk0RsygY V8E8wbQKTAQ/f8PrDND002PRr8Mg7noKJEaya98RAo8lmipF1vSvw3eSiypC+tlyUD r/cuHGvfvmeRJE7V4Cx15SbPeRLvMSOh03SMOSc5MNKcvDajWTCZZRHAVGqdLLpreG 4u/MHTpOmHU3I9U74b8aL1NbY0worAf4xQldm7ou+zysTbjRrud8EqDlwJJld3FqQS wJJWcPsc+rAVQ== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: =?utf-8?q?Marek_Beh=C3=BAn?= Subject: [PATCH 16/25] irqchip/armada-370-xp: Use FIELD_GET() and named register constant Date: Mon, 1 Jul 2024 19:02:40 +0200 Message-ID: <20240701170249.8128-17-kabel@kernel.org> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240701170249.8128-1-kabel@kernel.org> References: <20240701170249.8128-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_100339_253335_05148AAF X-CRM114-Status: GOOD ( 13.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use FIELD_GET() and named register mask constant when reading the number of supported interrupts / current interrupt. Signed-off-by: Marek Behún --- drivers/irqchip/irq-armada-370-xp.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index c287579da436..d8db46001961 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c @@ -10,6 +10,7 @@ * Ben Dooks */ +#include #include #include #include @@ -112,6 +113,7 @@ /* Registers relative to main_int_base */ #define MPIC_INT_CONTROL 0x00 +#define MPIC_INT_CONTROL_NUMINT_MASK GENMASK(12, 2) #define MPIC_SW_TRIG_INT 0x04 #define MPIC_INT_SET_ENABLE 0x30 #define MPIC_INT_CLEAR_ENABLE 0x34 @@ -124,6 +126,7 @@ #define MPIC_IN_DRBEL_MASK 0x0c #define MPIC_PPI_CAUSE 0x10 #define MPIC_CPU_INTACK 0x44 +#define MPIC_CPU_INTACK_IID_MASK GENMASK(9, 0) #define MPIC_INT_SET_MASK 0x48 #define MPIC_INT_CLEAR_MASK 0x4C #define MPIC_INT_FABRIC_MASK 0x54 @@ -674,7 +677,7 @@ static void __exception_irq_entry mpic_handle_irq(struct pt_regs *regs) do { irqstat = readl_relaxed(per_cpu_int_base + MPIC_CPU_INTACK); - irqnr = irqstat & 0x3FF; + irqnr = FIELD_GET(MPIC_CPU_INTACK_IID_MASK, irqstat); if (irqnr > 1022) break; @@ -774,8 +777,7 @@ static int __init mpic_of_init(struct device_node *node, struct device_node *parent) { struct resource main_int_res, per_cpu_int_res; - int nr_irqs; - u32 control; + unsigned int nr_irqs; BUG_ON(of_address_to_resource(node, 0, &main_int_res)); BUG_ON(of_address_to_resource(node, 1, &per_cpu_int_res)); @@ -795,8 +797,8 @@ static int __init mpic_of_init(struct device_node *node, resource_size(&per_cpu_int_res)); BUG_ON(!per_cpu_int_base); - control = readl(main_int_base + MPIC_INT_CONTROL); - nr_irqs = (control >> 2) & 0x3ff; + nr_irqs = FIELD_GET(MPIC_INT_CONTROL_NUMINT_MASK, + readl(main_int_base + MPIC_INT_CONTROL)); for (int i = 0; i < nr_irqs; i++) writel(i, main_int_base + MPIC_INT_CLEAR_ENABLE);