From patchwork Mon Jul 1 17:02:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 13718461 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC4C6C2BD09 for ; Mon, 1 Jul 2024 17:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w+oTzGKRTA0vwqtm1X+Ni/UWfPm/EUwclQq2BKevwQM=; b=gzm26bCFQxd3wXc/ScOXmZ7cTw FKDdwoPl5Nlg9sPAWZSLQlZ3gBenYN7nTWg/OuFNkGJ4hnzZO7kDKLyRftJ7OJN6KENm24MY+X+pT PlsP4m3P49zsARHjBxQTGyAeNUnP335jfSlc4tpf2GlkBb+ieCMN/CMNz7RSmpaPmH4ltQbFlWm53 O2ABtQ+sif5jaySAzz08VDgutHQsSXGWMENz9y0wWNv6iTQMap/60b4rtb2aJqy4x5e4kaAmNF6KH kC8Zd3KuTml26lNe4hNdmHZdDflFKR63CRWm4CDkIsLqv5JTbZ5xWVG6ed1uauiar/v2752TyZuv7 FXU7BQxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOKTK-00000004Eg4-3MfE; Mon, 01 Jul 2024 17:05:46 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOKRP-00000004Dfs-3H7l for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 17:03:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E0201CE18C4; Mon, 1 Jul 2024 17:03:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3583C2BD10; Mon, 1 Jul 2024 17:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719853421; bh=5e5/7Gz1eXG0uwai4Z06vHQCYq3L7H94fbtkfLGo8qA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gYRI5oJ2sQBEzgG9DgY2G8sDsrdBKRvuuYZRR/6lhZh+Fj5NpyVZBiKYQokBTdyJ5 tdd/xxeZ9jo+jND7jChsgbGSahBmyx5yir1EzxycyZJQ0XgB5pgndF9u1p9CF9kWVT 6aRH0+Bv+9idWiNYPcOSxkSAFidcarfEM2Y+7nhpJ4rAe9R7x8eFelHb635oPGl/xE lC1ygwInzG8rdGu4yMbfTpgHrSC3swLNE5sRjERESkGk2Tt9DK7VoFRvpSoAsDvlsA 9VXGVvvOqOEl81SWLRABj2VEEgLFnQHDdKnyLqJt8pFdHJEWNoi79lNVP5kcPnkRo2 BIakCVJ3QL6VQ== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: =?utf-8?q?Marek_Beh=C3=BAn?= Subject: [PATCH 18/25] irqchip/armada-370-xp: Simplify mpic_reenable_percpu() code Date: Mon, 1 Jul 2024 19:02:42 +0200 Message-ID: <20240701170249.8128-19-kabel@kernel.org> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240701170249.8128-1-kabel@kernel.org> References: <20240701170249.8128-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_100348_018755_0FC32B40 X-CRM114-Status: GOOD ( 12.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Refactor the mpic_reenable_percpu() function to make it simpler. Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn --- drivers/irqchip/irq-armada-370-xp.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index 9e8b189da1d1..d21216515fc2 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c @@ -528,20 +528,13 @@ static void mpic_smp_cpu_init(void) static void mpic_reenable_percpu(void) { /* Re-enable per-CPU interrupts that were enabled before suspend */ - for (unsigned int irq = 0; irq < MPIC_MAX_PER_CPU_IRQS; irq++) { - struct irq_data *data; - int virq; + for (irq_hw_number_t i = 0; i < MPIC_MAX_PER_CPU_IRQS; i++) { + unsigned int virq = irq_linear_revmap(mpic_domain, i); - virq = irq_linear_revmap(mpic_domain, irq); - if (!virq) - continue; - - data = irq_get_irq_data(virq); - - if (!irq_percpu_is_enabled(virq)) + if (!virq || !irq_percpu_is_enabled(virq)) continue; - mpic_irq_unmask(data); + mpic_irq_unmask(irq_get_irq_data(virq)); } if (mpic_is_ipi_available())