From patchwork Mon Jul 1 17:02:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 13718465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C216C3065A for ; Mon, 1 Jul 2024 17:06:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GrTkbMBC9E/BcH0YAwVh12GoA6O1g1vhmvQkusNjHzY=; b=pXctBC/x3bnr7BbrhcSXfq5gxD THwBws3eR2v/cAhSd4AbK0jABD6QoZ7XreZG/maaOp/MFe3F2LI8qIiNnFXfv33Ah02j8/FxjyGM8 Hb1dU0qWY1XrJRAbYjE4bQWFWyS8Kn4mmi84t88SKnZf+7rMt+F8WSS0K5u86vTfOAoRc5xbqV8tx ePu7E5Tqo8vQIF3AVX+FWu18AW4gSfEFx3vw7G0rLermMfVtu2FriBdj2EyCrURPLdc95W3Y0o7hy AfWPOwi0zZ1/ZJyXwUldGt5r1Nrn9e7oUXeBxGeMf02U+AmT8IROaDAzjyzbqzeBUydfWGsb57DYY 13rA5jlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOKTx-00000004F2w-23Z8; Mon, 01 Jul 2024 17:06:25 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOKRW-00000004Dhu-0gIk for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 17:03:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 08618CE1A46; Mon, 1 Jul 2024 17:03:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34240C116B1; Mon, 1 Jul 2024 17:03:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719853432; bh=MN1niYSm/Iwqi7/GEJ9A8TU8dJyPhP5gLsHigr0rqJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WxEUqGeSg8659L0aciDD3Q4Cto/lG7drTa/HuZQLR6JCjI+gb7jHdGoJgaRClDAD7 1VQiRYWk0m/XgTT0w2BIYQfVrtW9gIBVP/856fGcXZCpKaXcDenmDtxu2EVtNLS934 mW0hdSf8/wnNWD5hlRYpHw5tblhJJl7emFNbnvjYGrrsfzknE69w5PQhC+BcJp9jJa d/pvvRpe8GQ5z2qqDs/cGvMO6H4Z49111e2fAEHpGFztdUu+RdqcJWVMvkwouOUxwR LH2A+0diKgNOb4QMFcOKh6wgMKwwQzkxSuGrZXiIQwqKduAHKF0gQBH4wMKC9PV3yX l4jqcsrrvyZVg== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: =?utf-8?q?Marek_Beh=C3=BAn?= Subject: [PATCH 22/25] irqchip/armada-370-xp: Refactor handling IPI interrupts into own function Date: Mon, 1 Jul 2024 19:02:46 +0200 Message-ID: <20240701170249.8128-23-kabel@kernel.org> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240701170249.8128-1-kabel@kernel.org> References: <20240701170249.8128-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_100354_423637_E3153824 X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Refactor the handling of IPI interrupts into its own function mpic_handle_ipi_irq(), similar to mpic_handle_msi_irq(). Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn --- drivers/irqchip/irq-armada-370-xp.c | 31 +++++++++++++++++------------ 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index 4b4c0dae72b0..5ce55cc15572 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c @@ -625,6 +625,22 @@ static void mpic_handle_msi_irq(struct pt_regs *regs, bool is_chained) static void mpic_handle_msi_irq(struct pt_regs *r, bool b) {} #endif +#ifdef CONFIG_SMP +static void mpic_handle_ipi_irq(void) +{ + irq_hw_number_t hwirq; + unsigned long cause; + + cause = readl_relaxed(per_cpu_int_base + MPIC_IN_DRBEL_CAUSE); + cause &= IPI_DOORBELL_MASK; + + for_each_set_bit(hwirq, &cause, IPI_DOORBELL_END) + generic_handle_domain_irq(mpic_ipi_domain, hwirq); +} +#else +static inline void mpic_handle_ipi_irq(void) {} +#endif + static void mpic_handle_cascade_irq(struct irq_desc *desc) { struct irq_chip *chip = irq_desc_get_chip(desc); @@ -677,20 +693,9 @@ static void __exception_irq_entry mpic_handle_irq(struct pt_regs *regs) if (hwirq == 1) mpic_handle_msi_irq(regs, false); -#ifdef CONFIG_SMP /* IPI Handling */ - if (hwirq == 0) { - unsigned long ipimask; - irq_hw_number_t ipi; - - ipimask = readl_relaxed(per_cpu_int_base + - MPIC_IN_DRBEL_CAUSE) & - IPI_DOORBELL_MASK; - - for_each_set_bit(ipi, &ipimask, IPI_DOORBELL_END) - generic_handle_domain_irq(mpic_ipi_domain, ipi); - } -#endif + if (hwirq == 0) + mpic_handle_ipi_irq(); } while (1); }