From patchwork Mon Jul 1 18:28:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 13718539 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B930C3065B for ; Mon, 1 Jul 2024 18:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wGa0V/+q1PY+8AtdQff4+HTCc2sbpBqj/v0lwdLsGCU=; b=q9Ir7OU6Az6xghB2KJSgHttFGY Pf7RN9i7WCVl2SZ4jryUWT5+IKnyA0R2qStmgSxTxRNgjdcG5y1X92KioEOrJjeAEJMFDXE32OZ6c aM/ZAh4X/1bdngOQ2BZM/GrCC2q5CGBiKuPNxGCrZoBLAneyqX+a6xpz0ZLjWia0FnBeHXivaQE5T bMCa3Nlag1oA8uyW2FeCPUMIXG5HwDhtOpM50zinX9IBc6CWFk+71aNYmST6e9NGmDqOnK3y2C3TR t4vNZ+qiTn1wHyF9wD6wlMJzQu+lVAj7b7arTLudntMRVxFIiSnsKPR9dL7NXiuT3hPAK6GZ4Hwpa BUpVFYqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOLmr-00000004S4T-3JR7; Mon, 01 Jul 2024 18:30:01 +0000 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOLma-00000004Rwn-0XAN for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 18:29:45 +0000 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2ec1ac1aed2so39164601fa.3 for ; Mon, 01 Jul 2024 11:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719858582; x=1720463382; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wGa0V/+q1PY+8AtdQff4+HTCc2sbpBqj/v0lwdLsGCU=; b=QU1MjHK7HFyXXsLecD6ueGwq4guVlVAZyKPrYufNaQy0QnbLS5nbWAOWxK/zRtu+mA Ym883fD4j1vozWy/t0wv6NAJV2bguggh2rdTS0U0wguAybbZCtKkJzoK1lksbJD3Ef5g R7I0nY5kYmfv5+Q0jNWLILOetw3J9A3KzRdwv4P4O8MftaiRdVURZXN/FvyNH9cMie/f 9MHogWiQTY+XDWZS3cN60YUAH+6Nt5mBZRwJjHpAlvLMLfpO1BjskCyYolK/UPp+ioFs rKxScdhtWcrlc5G1UJo4iZlrHjnwTn/py/q8pCteUNPHm+3sw0Fo8Rh0QJiWGkBQl1u+ Dr9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719858582; x=1720463382; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wGa0V/+q1PY+8AtdQff4+HTCc2sbpBqj/v0lwdLsGCU=; b=loN2aEwDLJepBJA7p8LUgz3EOi71oujQYIa8P2CLCp0EUg4CsJHuDLuBYlhfClr/xx +pzzBSfDZ0SBxVUPwD2cHpUAL5MXgHUvhUSgiNN+WTlbHtv/4P2wyB4uadQiLlzb8QIz IBGtSog7vRfyFtfuIT8+mqUsy/ZoN8R3jvwl7y501A2FJBa1m9oyNX94Etv/QgyMJXjS mQZDQxJf2TZBownnav40I1+zzV9cWPsqJvrrPOOYe/SD2bF0G2z2NAd+dgXZpnViWBQb Y0a+1kzLA5QDKJ9sO23Yd/hHA5XE9/XOpd/e8vbjraBQN8aVYEMuEFEoevFNhw1AoCIL YSCQ== X-Forwarded-Encrypted: i=1; AJvYcCVcdxjVFCIqg/IFj+skUcjpINiBK79u7vh5dqq1clCNw24kY/IqQkELDZUFs7zOU7qir/6UFzyX/MC1WSntc8H82x+0FZWdLjbPkHJBwqQ9MaA5fZ8= X-Gm-Message-State: AOJu0Yy7wwsLgIAbaQ23prO/2RYZDQOVdpzKvTHTJHLzlpQkoupzLqnn 9EZql9Bqis8ysKT7xbTDNBDHowFnsLSrniagWGLAXqlsQBZ9RoWg X-Google-Smtp-Source: AGHT+IFXnUFdgrXA1uR1LN5UmTAA18az9EpTs+N0Pv9356JIFI06IvJbJFQAahcrWN6Else101zSvA== X-Received: by 2002:a2e:b535:0:b0:2ec:4eca:748b with SMTP id 38308e7fff4ca-2ee5e39260amr38054481fa.14.1719858582315; Mon, 01 Jul 2024 11:29:42 -0700 (PDT) Received: from localhost ([178.176.56.174]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ee5168d0c2sm14452161fa.124.2024.07.01.11.29.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 11:29:41 -0700 (PDT) From: Serge Semin To: Andrew Lunn , Heiner Kallweit , Russell King , Alexandre Torgue , Jose Abreu , Jose Abreu , Vladimir Oltean , Florian Fainelli , Maxime Chevallier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin Cc: Serge Semin , Sagar Cheluvegowda , Abhishek Chauhan , Andrew Halaney , Jiawen Wu , Mengyuan Lou , Tomer Maimon , openbmc@lists.ozlabs.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next v4 10/10] net: stmmac: Add DW XPCS specified via "pcs-handle" support Date: Mon, 1 Jul 2024 21:28:41 +0300 Message-ID: <20240701182900.13402-11-fancer.lancer@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240701182900.13402-1-fancer.lancer@gmail.com> References: <20240701182900.13402-1-fancer.lancer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_112944_191156_F1C4AAAA X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Recently the DW XPCS DT-bindings have been introduced and the DW XPCS driver has been altered to support the DW XPCS registered as a platform device. In order to have the DW XPCS DT-device accessed from the STMMAC driver let's alter the STMMAC PCS-setup procedure to support the "pcs-handle" property containing the phandle reference to the DW XPCS device DT-node. The respective fwnode will be then passed to the xpcs_create_fwnode() function which in its turn will create the DW XPCS descriptor utilized in the main driver for the PCS-related setups. Signed-off-by: Serge Semin --- drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c index 74de6ec00bbf..03f90676b3ad 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c @@ -497,15 +497,22 @@ int stmmac_mdio_reset(struct mii_bus *bus) int stmmac_pcs_setup(struct net_device *ndev) { + struct fwnode_handle *devnode, *pcsnode; struct dw_xpcs *xpcs = NULL; struct stmmac_priv *priv; int addr, mode, ret; priv = netdev_priv(ndev); mode = priv->plat->phy_interface; + devnode = priv->plat->port_node; if (priv->plat->pcs_init) { ret = priv->plat->pcs_init(priv); + } else if (fwnode_property_present(devnode, "pcs-handle")) { + pcsnode = fwnode_find_reference(devnode, "pcs-handle", 0); + xpcs = xpcs_create_fwnode(pcsnode, mode); + fwnode_handle_put(pcsnode); + ret = PTR_ERR_OR_ZERO(xpcs); } else if (priv->plat->mdio_bus_data && priv->plat->mdio_bus_data->pcs_mask) { addr = ffs(priv->plat->mdio_bus_data->pcs_mask) - 1; @@ -515,10 +522,8 @@ int stmmac_pcs_setup(struct net_device *ndev) return 0; } - if (ret) { - dev_warn(priv->device, "No xPCS found\n"); - return ret; - } + if (ret) + return dev_err_probe(priv->device, ret, "No xPCS found\n"); priv->hw->xpcs = xpcs;