diff mbox series

[2/2] arm64: dts: imx8mm-venice-gw72xx-0x: Remove compatible from dtso

Message ID 20240701231229.197614-2-festevam@gmail.com (mailing list archive)
State New
Headers show
Series [1/2] arm64: dts: imx8mm-phygate-tauri-l: Remove compatible from dtso | expand

Commit Message

Fabio Estevam July 1, 2024, 11:12 p.m. UTC 
From: Fabio Estevam <festevam@denx.de>

There is no need to describe the compatible string inside
a dtso file.

dt-schema produces super verbose warnings about that.

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ----
 .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso     | 4 ----
 .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso     | 4 ----
 3 files changed, 12 deletions(-)

Comments

Parthiban July 2, 2024, 10:31 a.m. UTC | #1 
Hi,

I missed it, thanks for fixing it.

On 7/2/24 4:42 AM, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> There is no need to describe the compatible string inside
> a dtso file.
> 
> dt-schema produces super verbose warnings about that.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Parthiban Nallathambi <parthiban@linumiz.com>

Thanks,
Parthiban N

> ---
>  .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ----
>  .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso     | 4 ----
>  .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso     | 4 ----
>  3 files changed, 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> index f6ad1a4b8b66..47d3c0c49e8a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> @@ -15,10 +15,6 @@
>  /dts-v1/;
>  /plugin/;
>  
> -&{/} {
> -	compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
>  &gpio4 {
>  	rs485_en {
>  		gpio-hog;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> index c3cd9f2b0db3..7fcd8c851159 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> @@ -18,10 +18,6 @@
>  /dts-v1/;
>  /plugin/;
>  
> -&{/} {
> -	compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
>  &gpio4 {
>  	rs485_en {
>  		gpio-hog;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> index cc0a287226ab..b19e38fc27ba 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> @@ -18,10 +18,6 @@
>  /dts-v1/;
>  /plugin/;
>  
> -&{/} {
> -	compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
>  &gpio4 {
>  	rs485_en {
>  		gpio-hog;
Tim Harvey July 2, 2024, 6:05 p.m. UTC | #2 
On Mon, Jul 1, 2024 at 4:12 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> From: Fabio Estevam <festevam@denx.de>
>
> There is no need to describe the compatible string inside
> a dtso file.
>
> dt-schema produces super verbose warnings about that.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso | 4 ----
>  .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso     | 4 ----
>  .../boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso     | 4 ----
>  3 files changed, 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> index f6ad1a4b8b66..47d3c0c49e8a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
> @@ -15,10 +15,6 @@
>  /dts-v1/;
>  /plugin/;
>
> -&{/} {
> -       compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
>  &gpio4 {
>         rs485_en {
>                 gpio-hog;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> index c3cd9f2b0db3..7fcd8c851159 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
> @@ -18,10 +18,6 @@
>  /dts-v1/;
>  /plugin/;
>
> -&{/} {
> -       compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
>  &gpio4 {
>         rs485_en {
>                 gpio-hog;
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> index cc0a287226ab..b19e38fc27ba 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
> @@ -18,10 +18,6 @@
>  /dts-v1/;
>  /plugin/;
>
> -&{/} {
> -       compatible = "gw,imx8mm-gw72xx-0x";
> -};
> -
>  &gpio4 {
>         rs485_en {
>                 gpio-hog;
> --
> 2.34.1
>

Hi Fabio,

Thanks for the fixup. Is there a warning now that detects these?

The same likely needs to be done to imx8mm-venice-gw73xx-*.dtso and
imx8mp-venice-gw74xx*.dtso. My original intention with the compatible
strings was to define what the overlay is compatible with but this
certainly was not the right way to do that (i'm not sure what is
honestly).

Acked-by: Tim Harvey <tharvey@gateworks.com>

Best Regards,

Tim
Fabio Estevam July 2, 2024, 6:17 p.m. UTC | #3 
Hi Tim,

On Tue, Jul 2, 2024 at 3:05 PM Tim Harvey <tharvey@gateworks.com> wrote:

> Hi Fabio,
>
> Thanks for the fixup. Is there a warning now that detects these?

Yes, super massive warning when running "make dtbs_check":

Here it goes:
https://paste.to/?89f9844dc5b8f637#7s2w1yEc84cwkZVPTZmiqarkrsn99x9mVsjsSgXXukrm
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
index f6ad1a4b8b66..47d3c0c49e8a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtso
@@ -15,10 +15,6 @@ 
 /dts-v1/;
 /plugin/;
 
-&{/} {
-	compatible = "gw,imx8mm-gw72xx-0x";
-};
-
 &gpio4 {
 	rs485_en {
 		gpio-hog;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
index c3cd9f2b0db3..7fcd8c851159 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtso
@@ -18,10 +18,6 @@ 
 /dts-v1/;
 /plugin/;
 
-&{/} {
-	compatible = "gw,imx8mm-gw72xx-0x";
-};
-
 &gpio4 {
 	rs485_en {
 		gpio-hog;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
index cc0a287226ab..b19e38fc27ba 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtso
@@ -18,10 +18,6 @@ 
 /dts-v1/;
 /plugin/;
 
-&{/} {
-	compatible = "gw,imx8mm-gw72xx-0x";
-};
-
 &gpio4 {
 	rs485_en {
 		gpio-hog;