[07/20] iio: accel: bmc150-accel-core: make use of iio_for_each_active_channel()

Commit Message

Nuno Sa via B4 Relay July 2, 2024, 4:02 p.m. UTC

From: Nuno Sa <[e-mail]>

Use iio_for_each_active_channel() to iterate over active channels
accessing '.masklength' so it can be annotated as __private when there are
no more direct users of it.

Signed-off-by: Nuno Sa <[e-mail]>
---
 drivers/iio/accel/bmc150-accel-core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Alexandru Ardelean July 3, 2024, 6:24 a.m. UTC | #1

On Tue, Jul 2, 2024 at 7:02 PM Nuno Sa via B4 Relay
<[e-mail]> wrote:
>
> From: Nuno Sa <[e-mail]>
>
> Use iio_for_each_active_channel() to iterate over active channels
> accessing '.masklength' so it can be annotated as __private when there are
> no more direct users of it.
>

Reviewed-by: Alexandru Ardelean <[e-mail]>

> Signed-off-by: Nuno Sa <[e-mail]>
> ---
>  drivers/iio/accel/bmc150-accel-core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
> index ae0cd48a3e293..03121d020470e 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -1007,8 +1007,7 @@ static int __bmc150_accel_fifo_flush(struct iio_dev *indio_dev,
>                 int j, bit;
>
>                 j = 0;
> -               for_each_set_bit(bit, indio_dev->active_scan_mask,
> -                                indio_dev->masklength)
> +               iio_for_each_active_channel(indio_dev, bit)
>                         memcpy(&data->scan.channels[j++], &buffer[i * 3 + bit],
>                                sizeof(data->scan.channels[0]));
>
>
> --
> 2.45.2
>
>
>

Patch

diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
index ae0cd48a3e293..03121d020470e 100644
--- a/drivers/iio/accel/bmc150-accel-core.c
+++ b/drivers/iio/accel/bmc150-accel-core.c
@@ -1007,8 +1007,7 @@  static int __bmc150_accel_fifo_flush(struct iio_dev *indio_dev,
 		int j, bit;
 
 		j = 0;
-		for_each_set_bit(bit, indio_dev->active_scan_mask,
-				 indio_dev->masklength)
+		iio_for_each_active_channel(indio_dev, bit)
 			memcpy(&data->scan.channels[j++], &buffer[i * 3 + bit],
 			       sizeof(data->scan.channels[0]));