From patchwork Tue Jul 2 11:42:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 13719498 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4626C30658 for ; Tue, 2 Jul 2024 11:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vsZIZfU5PWmhenxMT0LXy6zg3Bibo6JMt3Q+7MKk63o=; b=1kE5XHZ3Rxb25Zm/V3Xu+4c/r6 IuePWlMaadWhSrJ//84JIwGNEgc+Qp6Ir0YIHNBYhLWYNXlz6uwd7rK2H6eDUUJFplmY/ll1GUWPd ERDb04saj2TYI5MfRTYMl6wCtwPoAsEkMkt65OCpku40YAa4zLpnkBEJhMcguWqWvPOen/0SR4fEq xXSWs/aBRPfJHrmWuLpTDkolz0pf6nu1UTKNLwU51Dienmu76rwxtN0vysm7BbMCz+pipna1lVDcM HM04M8KBpjs/JFbJfS4WH2s5dyWh9wMHzRfIGGGasW8CM2ZOySYSkMUPIlvt8du6QPBocQFZVOd2h 9t8MfLAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOby6-00000006Xtb-2PIg; Tue, 02 Jul 2024 11:46:42 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sObvW-00000006WPL-2kVT for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 11:44:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EFF75CE172D; Tue, 2 Jul 2024 11:44:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ED0AC32781; Tue, 2 Jul 2024 11:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719920640; bh=Fye1I0+A5pEpUA8VDEPjyqgwS8+8Aw/ZrzB8azTH2UQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aYuEejk85dShCe6bhmaazodo4JiwzfMT8WDIC+4aX2ZOm6kfTcJ2fFZHL5Huq2TgY ccLJVpUseh2iQ0T2uDw17pjxurH1G/+Sv6Uq00Idqj2l1+CHxW3U8wnsCBCB1R+XQG xg6e2Zr9wrF6W78+42udOZ/koI1l74Ws1OtK7AgYzJQaM0AeJxpVP/jPLHD5Sj69t1 jaMAPDB2ZbsBFGEGymIKI5mWoPEYmWVC4ORdXhBMPl8/iDtcKJuAl1QMFO4mVpSKZl 92IqH6FznbHQQ+hldXQi4Vuhg6bSgEC9R8ibg1+25G11VH1bgvw4+8id20STURK9wv oINZZUVe1HNSg== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: =?utf-8?q?Marek_Beh=C3=BAn?= Subject: [PATCH v2 20/30] irqchip/armada-370-xp: Refactor handling IPI interrupts Date: Tue, 2 Jul 2024 13:42:52 +0200 Message-ID: <20240702114302.22475-21-kabel@kernel.org> X-Mailer: git-send-email 2.44.2 In-Reply-To: <20240702114302.22475-1-kabel@kernel.org> References: <20240702114302.22475-1-kabel@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_044402_985980_098831D2 X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Refactor the handling of IPI interrupts - put into own function mpic_handle_ipi_irq(), similar to mpic_handle_msi_irq() - rename the variable holding the doorbell cause register to "cause" - retype and rename the variable holding the IPI HW IRQ number to "irq_hw_number_t i" Signed-off-by: Marek Behún --- drivers/irqchip/irq-armada-370-xp.c | 31 +++++++++++++++++------------ 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c index b31bf6c43a8b..be1c3721f980 100644 --- a/drivers/irqchip/irq-armada-370-xp.c +++ b/drivers/irqchip/irq-armada-370-xp.c @@ -635,6 +635,22 @@ static void mpic_handle_msi_irq(void) static void mpic_handle_msi_irq(void) {} #endif +#ifdef CONFIG_SMP +static void mpic_handle_ipi_irq(void) +{ + unsigned long cause; + irq_hw_number_t i; + + cause = readl_relaxed(per_cpu_int_base + MPIC_IN_DRBEL_CAUSE); + cause &= IPI_DOORBELL_MASK; + + for_each_set_bit(i, &cause, IPI_DOORBELL_END) + generic_handle_domain_irq(mpic_ipi_domain, i); +} +#else +static inline void mpic_handle_ipi_irq(void) {} +#endif + static void mpic_handle_cascade_irq(struct irq_desc *desc) { struct irq_chip *chip = irq_desc_get_chip(desc); @@ -685,20 +701,9 @@ static void __exception_irq_entry mpic_handle_irq(struct pt_regs *regs) if (irqnr == 1) mpic_handle_msi_irq(); -#ifdef CONFIG_SMP /* IPI Handling */ - if (irqnr == 0) { - unsigned long ipimask; - int ipi; - - ipimask = readl_relaxed(per_cpu_int_base + - MPIC_IN_DRBEL_CAUSE) & - IPI_DOORBELL_MASK; - - for_each_set_bit(ipi, &ipimask, IPI_DOORBELL_END) - generic_handle_domain_irq(mpic_ipi_domain, ipi); - } -#endif + if (irqnr == 0) + mpic_handle_ipi_irq(); } while (1); }