| Message ID | 20240703061840.3137496-1-jianhui.lee@canonical.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND,net] net: ethernet: mtk-star-emac: set mac_managed_pm when probing | expand |
On Wed, 2024-07-03 at 14:18 +0800, Jian Hui Lee wrote: > The below commit introduced a warning message when phy state is not in > the states: PHY_HALTED, PHY_READY, and PHY_UP. > commit 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state") > > mtk-star-emac doesn't need mdiobus suspend/resume. To fix the warning > message during resume, indicate the phy resume/suspend is managed by the > mac when probing. > > Fixes: 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state") > Signed-off-by: Jian Hui Lee <jianhui.lee@canonical.com> > --- > resending to add the mailing list recipient > > drivers/net/ethernet/mediatek/mtk_star_emac.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c > index 31aebeb2e285..79f8a8b72c27 100644 > --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c > +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c > @@ -1525,6 +1525,7 @@ static int mtk_star_probe(struct platform_device *pdev) > struct device_node *of_node; > struct mtk_star_priv *priv; > struct net_device *ndev; > + struct phy_device *phydev; Please respect the reverse x-mas tree order above. Thanks, Paolo
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index 31aebeb2e285..79f8a8b72c27 100644 --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c @@ -1525,6 +1525,7 @@ static int mtk_star_probe(struct platform_device *pdev) struct device_node *of_node; struct mtk_star_priv *priv; struct net_device *ndev; + struct phy_device *phydev; struct device *dev; void __iomem *base; int ret, i; @@ -1649,6 +1650,12 @@ static int mtk_star_probe(struct platform_device *pdev) netif_napi_add(ndev, &priv->rx_napi, mtk_star_rx_poll); netif_napi_add_tx(ndev, &priv->tx_napi, mtk_star_tx_poll); + phydev = of_phy_find_device(priv->phy_node); + if (phydev) { + phydev->mac_managed_pm = true; + put_device(&phydev->mdio.dev); + } + return devm_register_netdev(dev, ndev); }
The below commit introduced a warning message when phy state is not in the states: PHY_HALTED, PHY_READY, and PHY_UP. commit 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state") mtk-star-emac doesn't need mdiobus suspend/resume. To fix the warning message during resume, indicate the phy resume/suspend is managed by the mac when probing. Fixes: 744d23c71af3 ("net: phy: Warn about incorrect mdio_bus_phy_resume() state") Signed-off-by: Jian Hui Lee <jianhui.lee@canonical.com> --- resending to add the mailing list recipient drivers/net/ethernet/mediatek/mtk_star_emac.c | 7 +++++++ 1 file changed, 7 insertions(+)