From patchwork Mon Jul 8 09:31:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13726332 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C6AEC3271E for ; Mon, 8 Jul 2024 09:32:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=dA6EMy28d9u/TJupgL1NLFaPnGIHja+aqQxDduJmW04=; b=yaRwtWee4rL1FprZkSHML+EYia hLXsgRVOj69Q7+Z5pc/hWWF0FFX0sONbVJ3J+MjvpgehU5CdcSA7xoKFMdsopKJo3Vm77Mp1r5dp/ usu39vct0XTCZWcnAGa6cFnV5QX3HM7Vd5e+WAvTd8eLADF6Ezs+Y0qANeP1XyYJ5DefTl6Ex2zYX GbTmeKKwGzhdOm1E08Oj17FhlGoCLKjAJz7uY3zJJpCYa9IVQ24xGDNY6kfOi5LLWNf4g5iyCpzaI adHk3xKErXF99LdlJHOqEkvpizTT86bqzjzYqGoQ1nISfRPMmcAVk/xLjIuwSfqYEusl4sTHVPwfZ 7F/Gb12g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQkjK-00000003Hfg-1dg3; Mon, 08 Jul 2024 09:32:18 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sQkj4-00000003HbV-1TY0 for linux-arm-kernel@lists.infradead.org; Mon, 08 Jul 2024 09:32:03 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a77c080b521so397151666b.3 for ; Mon, 08 Jul 2024 02:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1720431121; x=1721035921; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dA6EMy28d9u/TJupgL1NLFaPnGIHja+aqQxDduJmW04=; b=SNFNij5nh4q0od94gLER8iRSOuKdzt9sdf9MkBGvigbCrfjidjLEzxkTge5HYoIiBl g91NFGBcwB18Y0xlrZaUX0AsuoCsT2LzFmHBXLQtkM4bNsam+MsChh1NlQBYpvZBgq2F idIzZjL3g/aylclaCVsh58MCmpuf0eNc5Ry6zRDxI4zew+IH4cNtvIi1tfzGMjKBYzXy jsTze+1mTCRKzscLFJYTOIim6rjkgOPVLUiMc/2b89zf9nAIUBKLqZhekkM9ROk+hQ3X VlUDcI/QuFlU8+F7eQtCZoEUPq06thlXZeEhQulWQQMM6GMec8wTJvwrWW8u9p0LCUlL YtfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720431121; x=1721035921; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dA6EMy28d9u/TJupgL1NLFaPnGIHja+aqQxDduJmW04=; b=rSqEZyPSdEeVfLu4QlwfMIhiYi4lx+j+Vdhi4V45qnY4/zVh4tzZ8vxM6XdXv/Swi1 JbU/KwnM+3SNBQl/fyo3Npyf0SE1Req9eN74SLkZJcEc2d7fFQ1p2s0atsTTWEW1qPU0 dRWGZmt9xQXZgHsS6bQb6zINNMrh9+pc3f64PJri/RLL6lSW0RBRJg32Rlyt9YTTf4Af /8PtbFZwOQhW7SYpgiQh3vagrTdmBTR9d1QKzA6pqqiBcquB/XLRL8D9eZoOaJ8z4IP8 ixI8DqP4affc6ABESEcrcqacquoGTCx9yvVx0ZzB9thbVC+SGWCWK+ppWEF5i+PbOMpw drOw== X-Gm-Message-State: AOJu0Yyo8b9w/zOCyipy0cUPOGcLM2TNgzcE+ZD8M0Cbd5M9DKSk7RtI Sk0gP/3iG0c5J9hOGRFae2Y0bwVU68+I5Q62qjSfRZlEheqKgZQ5vaLLHG2fqwc= X-Google-Smtp-Source: AGHT+IHrtZLWlzDG53yCClX+4dmqu/RWIvGgylTh5OE9oJfPRMFz0StkrbMf8FIs+o3xB/w4y4LFCw== X-Received: by 2002:a17:906:c9d5:b0:a77:cd3c:e9b7 with SMTP id a640c23a62f3a-a77cd3ceacfmr528532066b.57.1720431120500; Mon, 08 Jul 2024 02:32:00 -0700 (PDT) Received: from localhost (p50915e7b.dip0.t-ipconnect.de. [80.145.94.123]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77d37c97a2sm272129766b.40.2024.07.08.02.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jul 2024 02:32:00 -0700 (PDT) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Jason Cooper , Thomas Petazzoni Cc: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: mvebu: Drop a write-only variable Date: Mon, 8 Jul 2024 11:31:42 +0200 Message-ID: <20240708093145.1398949-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1482; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=nyVoxQ+q0+Y3ALNmWyfzZMTfRFrWAo9yoPaGmpPCAVM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBmi7ICWUVFGAhmd6IAHQv7wSDzRJBq7VpCjd7PG eTgn2mnekaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZouyAgAKCRCPgPtYfRL+ TsAwB/wKKm9yPoBR13H2m6Wlrj0X4VBagPG2+jMROLkQXd4Qbn5jUWLNk6NlN3VkuPDP22q6eZY +UnKAYCc+3qpWfA8BX/CccKwaL7a+UYvCDAwtIhXNSegYLX2eyIGEgWv4H76dqD/dioQ7eWC6oA 8iG9OCbmGvB6lxdVqx2H5iycKoSsMvhRsfHzcsAVo8KEZp4MPC+bY2I5lNDtRS/baKniJRENb1+ YL2L7tTwMOzAms+7q3x5ihSQ9T4S1001vAHnlQLhqy15XnXGMP+jUx9LDqZu8oZbYb7BMvnTc8N sz7+Ukf7eg//XF1fBm19pT2LqSolb9+SjJrJvhOIId0OFvaq X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240708_023202_415263_05A4940A X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This fixes a W=1 compiler error: arch/arm/mach-mvebu/board-v7.c: In function ‘mvebu_scan_mem’: arch/arm/mach-mvebu/board-v7.c:84:27: error: variable ‘size’ set but not used [-Werror=unused-but-set-variable] 84 | u64 base, size; | ^~~~ Fixes: 8da2b2f7ceee ("ARM: mvebu: reserve the first 10 KB of each memory bank for suspend/resume") Signed-off-by: Uwe Kleine-König --- Hello, not entirely sure about the correctness of this patch. Maybe you want to error out if size < MVEBU_DDR_TRAINING_AREA_SZ? Best regards Uwe arch/arm/mach-mvebu/board-v7.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233 diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c index fd5d0c8ff695..3fc4cce0225d 100644 --- a/arch/arm/mach-mvebu/board-v7.c +++ b/arch/arm/mach-mvebu/board-v7.c @@ -81,10 +81,11 @@ static int __init mvebu_scan_mem(unsigned long node, const char *uname, endp = reg + (l / sizeof(__be32)); while ((endp - reg) >= (dt_root_addr_cells + dt_root_size_cells)) { - u64 base, size; + u64 base; base = dt_mem_next_cell(dt_root_addr_cells, ®); - size = dt_mem_next_cell(dt_root_size_cells, ®); + /* skip over size */ + dt_mem_next_cell(dt_root_size_cells, ®); memblock_reserve(base, MVEBU_DDR_TRAINING_AREA_SZ); }