| Message ID | 20240709-add_qcs9100_ethqos_compatible-v2-2-ba22d1a970ff@quicinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | net: stmmac: dwmac-qcom-ethqos: Add QCS9100 ethqos compatible | expand |
These patches are for netdev, so you need to follow the netdev
rules, i.e. the subject should be have [PATCH net-next] in it, etc as
documented over here:
https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
> QCS9100 uses EMAC version 4, add the relevant defines, rename the
> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
> and add the new compatible.
This blurb isn't capturing what's done in this change, please make it
reflect the patch.
Thanks,
Andrew
On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote: > These patches are for netdev, so you need to follow the netdev > rules, i.e. the subject should be have [PATCH net-next] in it, etc as > documented over here: > > https://docs.kernel.org/process/maintainer-netdev.html#tl-dr > > On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote: > > QCS9100 uses EMAC version 4, add the relevant defines, rename the > > has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) > > and add the new compatible. > > This blurb isn't capturing what's done in this change, please make it > reflect the patch. Hi Tengfei If i remember correctly, there was a similar comment made to one of the patches in the huge v1 series. The commit messages are very important, just as important as the code itself. Please review them all and fixup issues like this before you repost. Andrew --- pw-bot: cr
On 7/9/2024 10:40 PM, Andrew Halaney wrote: > These patches are for netdev, so you need to follow the netdev > rules, i.e. the subject should be have [PATCH net-next] in it, etc as > documented over here: > > https://docs.kernel.org/process/maintainer-netdev.html#tl-dr > Thx very much for the detailed information. > On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote: >> QCS9100 uses EMAC version 4, add the relevant defines, rename the >> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) >> and add the new compatible. > > This blurb isn't capturing what's done in this change, please make it > reflect the patch. There is a similar comments on [1] on another patch. Similar comments should be taken care of next time. https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-30-quic_tengfan@quicinc.com/ > > Thanks, > Andrew >
On 7/9/2024 11:33 PM, Andrew Lunn wrote: > On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote: >> These patches are for netdev, so you need to follow the netdev >> rules, i.e. the subject should be have [PATCH net-next] in it, etc as >> documented over here: >> >> https://docs.kernel.org/process/maintainer-netdev.html#tl-dr >> >> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote: >>> QCS9100 uses EMAC version 4, add the relevant defines, rename the >>> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) >>> and add the new compatible. >> >> This blurb isn't capturing what's done in this change, please make it >> reflect the patch. > > Hi Tengfei > > If i remember correctly, there was a similar comment made to one of > the patches in the huge v1 series. > > The commit messages are very important, just as important as the code > itself. Please review them all and fixup issues like this before you > repost. Thx Andrew L for the info. > > Andrew > > --- > pw-bot: cr
On 7/10/2024 11:02 AM, Aiqun Yu (Maria) wrote: > > > On 7/9/2024 11:33 PM, Andrew Lunn wrote: >> On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote: >>> These patches are for netdev, so you need to follow the netdev >>> rules, i.e. the subject should be have [PATCH net-next] in it, etc as >>> documented over here: >>> >>> https://docs.kernel.org/process/maintainer-netdev.html#tl-dr >>> >>> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote: >>>> QCS9100 uses EMAC version 4, add the relevant defines, rename the >>>> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) >>>> and add the new compatible. >>> >>> This blurb isn't capturing what's done in this change, please make it >>> reflect the patch. >> >> Hi Tengfei >> >> If i remember correctly, there was a similar comment made to one of >> the patches in the huge v1 series. >> >> The commit messages are very important, just as important as the code >> itself. Please review them all and fixup issues like this before you >> repost. > > Thx Andrew L for the info. >> >> Andrew >> >> --- >> pw-bot: cr > After considering the feedback provided on the subject, We have decided to keep current SA8775p compatible and ABI compatibility in drivers. Let's close this session and ignore all the current patches here. Thank you for your input.
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c index e8a1701cdb7c..f3c5ae54bd5e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c @@ -864,6 +864,7 @@ static int qcom_ethqos_probe(struct platform_device *pdev) static const struct of_device_id qcom_ethqos_match[] = { { .compatible = "qcom,qcs404-ethqos", .data = &emac_v2_3_0_data}, + { .compatible = "qcom,qcs9100-ethqos", .data = &emac_v4_0_0_data}, { .compatible = "qcom,sa8775p-ethqos", .data = &emac_v4_0_0_data}, { .compatible = "qcom,sc8280xp-ethqos", .data = &emac_v3_0_0_data}, { .compatible = "qcom,sm8150-ethqos", .data = &emac_v2_1_0_data},
QCS9100 uses EMAC version 4, add the relevant defines, rename the has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3) and add the new compatible. QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p platform use non-SCMI resource. In the future, the SA8775p platform will move to use SCMI resources and it will have new sa8775p-related device tree. Consequently, introduce "qcom,qcs9100-ethqos" to the ethqos device match table. Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 + 1 file changed, 1 insertion(+)