From patchwork Fri Jul 12 13:13:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yannick Fertre X-Patchwork-Id: 13731770 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13F84C3DA4B for ; Fri, 12 Jul 2024 13:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=IYjw4WDQmFzzHm+jIr0oVQV4uqexoebGmhnt2Vpkcvw=; b=jzpy/1U/xOKOo8 2gsXghh9cY27E6bB6Gm94hm9Ucmd2BQGQApQCRC20M7PDio1M/jR0Vinm+eNbWW9nBvldPjfYTglK 2s+aX+8tezR3r7H9JQrIs8Utj9YsSCHwECxyr3+q25Yd52oZmIDdGxgp7tZfgsZUoaYnzgRDq1VgU h3l0PQttJnhnauEtzEZZ6NQYVhfmS9jZtQzDhfnsNrjbpgzlG8ytvwe2h6HFjfdbv9vcYWVKpgQP5 k6/rK1iPi4fRDpRZlL0FssFlSi27s73k0otj7AQagZLMbF8ELx20rn8xeGUrWEq0NLdQVZ7CE6qG+ fWVvAF746OeyJWVCio0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSG7N-000000006Zk-1a7J; Fri, 12 Jul 2024 13:15:21 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sSG74-000000006Uz-1rrB for linux-arm-kernel@lists.infradead.org; Fri, 12 Jul 2024 13:15:04 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46CCLxRd016528; Fri, 12 Jul 2024 15:14:44 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=selector1; bh=IYjw4WDQmFzzHm+jIr0oVQ V4uqexoebGmhnt2Vpkcvw=; b=6tixkjqEGfk5Mq04x+OtA1ae2H6GFxqzJ+isH0 Zk+QnlIesI6P5FDWCdNxMlgrWZASGqWmrD78LmJvURAuk2lfg7jO2uwjrbmH/X78 TflubKRpbjYw8fvyUK2zmR3wUmmZORaLkZUhYuBmAd/QvSqd6qcYPBzdO8QzHv2e 1q97hxKnNWfVWpwOQGQQE+VI10jlg0C1jfNJDPMpDyURPLdxxXV49Gig11Iy1/n6 S1Hw42M2+W13lv1zaqkB03e6jtqxBVNPPW765SdEKykZR9UrJVRQ3XTExNoPlhwS kk0z5b8uZipvOClb61ALOHpLoLW4n89soJ6KPahsqwiBmi6w== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 406whj2egu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Jul 2024 15:14:44 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id D635D40044; Fri, 12 Jul 2024 15:14:34 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6C65820CB1B; Fri, 12 Jul 2024 15:13:51 +0200 (CEST) Received: from localhost (10.252.16.177) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Fri, 12 Jul 2024 15:13:51 +0200 From: Yannick Fertre To: Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Maxime Coquelin , Alexandre Torgue , , , , Subject: [PATCH] drm/stm: ltdc: reset plane transparency after plane disable Date: Fri, 12 Jul 2024 15:13:44 +0200 Message-ID: <20240712131344.98113-1-yannick.fertre@foss.st.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.252.16.177] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-12_09,2024-07-11_01,2024-05-17_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240712_061502_815894_2B4742B1 X-CRM114-Status: GOOD ( 10.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The plane's opacity should be reseted while the plane is disabled. It prevents from seeing a possible global or layer background color set earlier. Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/ltdc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 5576fdae4962..cb4f08673a64 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c @@ -1514,6 +1514,9 @@ static void ltdc_plane_atomic_disable(struct drm_plane *plane, /* Disable layer */ regmap_write_bits(ldev->regmap, LTDC_L1CR + lofs, LXCR_LEN | LXCR_CLUTEN | LXCR_HMEN, 0); + /* Reset the layer transparency to hide any related background color */ + regmap_write_bits(ldev->regmap, LTDC_L1CACR + lofs, LXCACR_CONSTA, 0x00); + /* Commit shadow registers = update plane at next vblank */ if (ldev->caps.plane_reg_shadow) regmap_write_bits(ldev->regmap, LTDC_L1RCR + lofs,