From patchwork Mon Jul 15 16:07:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 13733630 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AE86C3DA4B for ; Mon, 15 Jul 2024 16:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TXX7mRuXQcBLS8y383InmnD2loHS7Yh9fEH9eFcZlP8=; b=UCoWaFV4Q4oKsdQiBBfiDwjnMt EFHDTQwsNMmmyIGCDtnTNx8qsDUWfVNmPrzJpBMFkicf3+D2uPNl8/63iNWVDzg15tSkU7pD+kUwD b434QLcxuU7tbn52OC2JZ1JZps/5GeSQpFNUWJzPZuPy0Yin86cRfcc4HU20MvX+2rNShFYhz3qGU IBOoNJdS7VA9qgCaBQXRF4cz6WfHYrXoD0s5gCdrpe+1uBIHh5z9m3c5WZLNvXz+vTfzWTfoWmNRy YcUnAB9RKUs2T3ljY995jSFP/Gqg51pL76Wmj650mgFCYpjwDT6Nq+3Ar5NdWnz/D/5LSsuWOY0oq THF9BFzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTOGk-00000007fc5-10MZ; Mon, 15 Jul 2024 16:09:42 +0000 Received: from mgamail.intel.com ([192.198.163.13]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sTOF6-00000007eph-3unN for linux-arm-kernel@lists.infradead.org; Mon, 15 Jul 2024 16:08:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721059681; x=1752595681; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=THudwkVwuPwa7x07vorLWh22uq9Bq8o+/y8n/tytTj8=; b=lNsjAkJfzziVNAZlf/BrmQ/vzCCjEgV5t4hjxohFplaLM00P0aVw6FFk XqBKZOKNpg9GlY8MWGrCew7eym3G/8euoSSKN4qqOvpExslPoVEZqV1Ds HKgDePONuW1fFQrLtt0gvfkQILrCf69GxaETtB0hCJDmZ8V5E7MvVX+i6 QIJqVaks1VtAmBHAxIxNwc4ED5MWjnJ19aT0C6erapO3HedTus2aKdTTS fh7vnZRoJQ1q88O+q8oQ9pKT3Qd3Z0vQZtp+cM4RwOi5Y5BXJqCiA5meV PpL3YG626XqUQm9zqKXkDH3/ibuIIhu6AKfaONuc5286p2EcLr10SJaYz A==; X-CSE-ConnectionGUID: 3KCII4a7Ri6dF9Br+1Uz0w== X-CSE-MsgGUID: HHM8kyNFRfudg0PDqi6OFQ== X-IronPort-AV: E=McAfee;i="6700,10204,11134"; a="21361252" X-IronPort-AV: E=Sophos;i="6.09,210,1716274800"; d="scan'208";a="21361252" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2024 09:08:00 -0700 X-CSE-ConnectionGUID: AdDkuYaGSKyrgmo3i5sSLg== X-CSE-MsgGUID: wHGiEGZSSgC47ZqGGYJl8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,210,1716274800"; d="scan'208";a="49413563" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO localhost.localdomain) ([10.246.49.253]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2024 09:07:55 -0700 From: Adrian Hunter To: Peter Zijlstra Cc: Ingo Molnar , Mark Rutland , Alexander Shishkin , Heiko Carstens , Thomas Richter , Hendrik Brueckner , Suzuki K Poulose , Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Yicong Yang , Jonathan Cameron , Will Deacon , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Ian Rogers , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: [PATCH V9 06/13] perf tools: Enable evsel__is_aux_event() to work for S390_CPUMSF Date: Mon, 15 Jul 2024 19:07:05 +0300 Message-Id: <20240715160712.127117-7-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240715160712.127117-1-adrian.hunter@intel.com> References: <20240715160712.127117-1-adrian.hunter@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240715_090801_015780_4211096B X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org evsel__is_aux_event() identifies AUX area tracing selected events. S390_CPUMSF uses a raw event type (PERF_TYPE_RAW - refer s390_cpumsf_evsel_is_auxtrace()) not a PMU type value that could be checked in evsel__is_aux_event(). However it sets needs_auxtrace_mmap (refer auxtrace_record__init()), so check that first. Currently, the features that use evsel__is_aux_event() are used only by Intel PT, but that may change in the future. Signed-off-by: Adrian Hunter Acked-by: Ian Rogers Reviewed-by: Andi Kleen Reviewed-by: Leo Yan --- tools/perf/util/pmu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 986166bc7c78..0b38c51bd6eb 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1199,8 +1199,12 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu *pmu) bool evsel__is_aux_event(const struct evsel *evsel) { - struct perf_pmu *pmu = evsel__find_pmu(evsel); + struct perf_pmu *pmu; + if (evsel->needs_auxtrace_mmap) + return true; + + pmu = evsel__find_pmu(evsel); return pmu && pmu->auxtrace; }