| Message ID | 20240715230311.685641-1-flokli@flokli.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: bcm283x: Fix hdmi hpd-gpio pin | expand |
+Stefan, On 7/15/24 16:03, Florian Klink wrote: > HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1. > > This fixes HDMI hotplug/output detection. > > See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf > > Signed-off-by: Florian Klink <flokli@flokli.de> Assuming Stefan is OK wit the change, I will apply this along with a: Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board") > --- > arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > index 72d26d130efa..85f54fa595aa 100644 > --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts > @@ -77,7 +77,7 @@ &gpio { > }; > > &hdmi { > - hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; > + hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>; > power-domains = <&power RPI_POWER_DOMAIN_HDMI>; > status = "okay"; > };
On 7/15/24 16:19, Florian Fainelli wrote: > +Stefan, With the correct email this time... > > On 7/15/24 16:03, Florian Klink wrote: >> HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1. >> >> This fixes HDMI hotplug/output detection. >> >> See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf >> >> Signed-off-by: Florian Klink <flokli@flokli.de> > > Assuming Stefan is OK wit the change, I will apply this along with a: > > Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO > board") > >> --- >> arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> index 72d26d130efa..85f54fa595aa 100644 >> --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> @@ -77,7 +77,7 @@ &gpio { >> }; >> &hdmi { >> - hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; >> + hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>; >> power-domains = <&power RPI_POWER_DOMAIN_HDMI>; >> status = "okay"; >> }; >
Hi, Am 16.07.24 um 01:19 schrieb Florian Fainelli: > +Stefan, > > On 7/15/24 16:03, Florian Klink wrote: >> HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1. >> >> This fixes HDMI hotplug/output detection. >> >> See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf >> >> Signed-off-by: Florian Klink <flokli@flokli.de> > > Assuming Stefan is OK wit the change, I will apply this along with a: > > Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and > IO board") thanks for fixing and i'm fine with this change. The GPIO line names are already correct. Maybe the subject should be more specific: ARM: dts: bcm2837-rpi-cm3-io3: Fix HDMI hpd-gpio pin Except of this: Reviewed-by: Stefan Wahren <wahrenst@gmx.net> Regards > >> --- >> arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> index 72d26d130efa..85f54fa595aa 100644 >> --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >> @@ -77,7 +77,7 @@ &gpio { >> }; >> &hdmi { >> - hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; >> + hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>; >> power-domains = <&power RPI_POWER_DOMAIN_HDMI>; >> status = "okay"; >> }; >
Hey, fine with the subject change too :-) @Florian: Let me know if you want me to roll all in a v2 or are happy to apply that subject change too. Cheers, flokli On Tue, Jul 16, 2024 at 07:30:32AM GMT, Stefan Wahren wrote: >Hi, > >Am 16.07.24 um 01:19 schrieb Florian Fainelli: >>+Stefan, >> >>On 7/15/24 16:03, Florian Klink wrote: >>>HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1. >>> >>>This fixes HDMI hotplug/output detection. >>> >>>See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf >>> >>>Signed-off-by: Florian Klink <flokli@flokli.de> >> >>Assuming Stefan is OK wit the change, I will apply this along with a: >> >>Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and >>IO board") >thanks for fixing and i'm fine with this change. The GPIO line names are >already correct. > >Maybe the subject should be more specific: > >ARM: dts: bcm2837-rpi-cm3-io3: Fix HDMI hpd-gpio pin > >Except of this: > >Reviewed-by: Stefan Wahren <wahrenst@gmx.net> > >Regards >> >>>--- >>> arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>>diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >>>b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >>>index 72d26d130efa..85f54fa595aa 100644 >>>--- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >>>+++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts >>>@@ -77,7 +77,7 @@ &gpio { >>> }; >>> &hdmi { >>>- hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; >>>+ hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>; >>> power-domains = <&power RPI_POWER_DOMAIN_HDMI>; >>> status = "okay"; >>> }; >> >
On 7/16/24 10:08, Florian Klink wrote: > Hey, > > fine with the subject change too :-) > > @Florian: Let me know if you want me to roll all in a v2 or are happy to > apply that subject change too. Will fix it up while applying, no need for a v2, thanks!
From: Florian Fainelli <f.fainelli@gmail.com> On Tue, 16 Jul 2024 02:03:11 +0300, Florian Klink <flokli@flokli.de> wrote: > HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1. > > This fixes HDMI hotplug/output detection. > > See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf > > Signed-off-by: Florian Klink <flokli@flokli.de> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/fixes, thanks! -- Florian
diff --git a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts index 72d26d130efa..85f54fa595aa 100644 --- a/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts +++ b/arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts @@ -77,7 +77,7 @@ &gpio { }; &hdmi { - hpd-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>; + hpd-gpios = <&expgpio 0 GPIO_ACTIVE_LOW>; power-domains = <&power RPI_POWER_DOMAIN_HDMI>; status = "okay"; };
HDMI_HPD_N_1V8 is connected to GPIO pin 0, not 1. This fixes HDMI hotplug/output detection. See https://datasheets.raspberrypi.com/cm/cm3-schematics.pdf Signed-off-by: Florian Klink <flokli@flokli.de> --- arch/arm/boot/dts/broadcom/bcm2837-rpi-cm3-io3.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)