diff mbox series

[v1,1/4] arm64: dts: imx8: remove non-existent DACs

Message ID 20240717-alkalize-bouncy-83e748284bc7@spud (mailing list archive)
State New, archived
Headers show
Series Removal of non-existent DAC nodes | expand

Commit Message

Conor Dooley July 17, 2024, 9:37 a.m. UTC 
From: Conor Dooley <conor.dooley@microchip.com>

Neither the imx8dxl-evk or imx8qm-mek have a Rohm DAC on them as far as
I can tell from online documentation, and they certainly do not have a
dh2228fv, as this device does not actually exist! Remove the DAC nodes
from the devicetrees as it is not acceptable to pretend to have a device
on a board in order to bind the spidev driver in Linux.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 6 ------
 arch/arm64/boot/dts/freescale/imx8qm-mek.dts  | 6 ------
 2 files changed, 12 deletions(-)

Comments

Krzysztof Kozlowski July 17, 2024, 9:38 a.m. UTC | #1 
On 17/07/2024 11:37, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Neither the imx8dxl-evk or imx8qm-mek have a Rohm DAC on them as far as
> I can tell from online documentation, and they certainly do not have a
> dh2228fv, as this device does not actually exist! Remove the DAC nodes
> from the devicetrees as it is not acceptable to pretend to have a device
> on a board in order to bind the spidev driver in Linux.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Shawn Guo Aug. 12, 2024, 9:43 a.m. UTC | #2 
On Wed, Jul 17, 2024 at 10:37:53AM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Neither the imx8dxl-evk or imx8qm-mek have a Rohm DAC on them as far as
> I can tell from online documentation, and they certainly do not have a
> dh2228fv, as this device does not actually exist! Remove the DAC nodes
> from the devicetrees as it is not acceptable to pretend to have a device
> on a board in order to bind the spidev driver in Linux.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
index 1a74ac3ee4ee..4caaecc19227 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts
@@ -722,12 +722,6 @@  &lpspi3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_lpspi3>;
 	status = "okay";
-
-	spidev0: spi@0 {
-		reg = <0>;
-		compatible = "rohm,dh2228fv";
-		spi-max-frequency = <30000000>;
-	};
 };
 
 &iomuxc {
diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
index 778741dbbb33..3f0fd147bbd0 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
@@ -287,12 +287,6 @@  &lpspi2 {
 	pinctrl-0 = <&pinctrl_lpspi2 &pinctrl_lpspi2_cs>;
 	cs-gpios = <&lsio_gpio3 10 GPIO_ACTIVE_LOW>;
 	status = "okay";
-
-	spidev0: spi@0 {
-		reg = <0>;
-		compatible = "rohm,dh2228fv";
-		spi-max-frequency = <30000000>;
-	};
 };
 
 &lsio_mu5 {