From patchwork Tue Jul 23 13:27:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 13740063 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A71CC3DA63 for ; Tue, 23 Jul 2024 13:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jQl6EXHpXLo5PWqlhK5rRfr4zbBkv4muqiVxIAXkgGQ=; b=enpjLGmFanbxR6EnG6UAUUhPAZ VICY4EDDuYmoGl0kUrG26iPhgGeT3Hxi95IbJPccrlkZYZupE+r6VQ5vpzbim1ATNohyAzlbLqrw6 N88XdAQtqhh7MKM7wwRBe4Ok8N5u9vNNRYnplg8vdi/R/oztkWYeXLh5+8I7mFTBkOznWRH+5W9R5 hk/pbrhG6npebMMk4l60kvNr6YmmubgGDux2KzRczBe+CCciZXGx4VBRrbmHqHiGUlN/hgmtHu6Nb KV8lL7wb/NlC2q0m8gPH1H0j1VmjU9OAnL/8K6bV3NVDCVS3E/UOKptC7fx/eSNoyO46Ax0nCATKl 8FecwCBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWFhC-0000000CZN9-3IdF; Tue, 23 Jul 2024 13:36:50 +0000 Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWFcg-0000000CXv2-0UXn; Tue, 23 Jul 2024 13:32:12 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4WSyk05Pdzz9scL; Tue, 23 Jul 2024 15:32:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1721741528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jQl6EXHpXLo5PWqlhK5rRfr4zbBkv4muqiVxIAXkgGQ=; b=DOjnuDJ8n25dhMPJbdNHOiFiyOiO64tcWSvwzxsju7BHE1K/dScf69P6nx+4bDIWJjRrnD N8NBopk/6vzKaRwrI/pun3OAX4MwZtvpBheqcXFCFV2O/A/CPSbV4jlARpZqmaS7NcO+mM UdicPQ0VhXL0Y3B5ow05lHK6xHoSQReL/79D+ZhVvfFoCjCls3KbpQ9xIQaHiJLXIfEP+2 7b1ZhvJxwJvz9LHllLRE1XlBkz3MZ3vngeAx2OesVlVyenBLvexDEK4HuZJPZunJuBgC6e Js3IgJZUgzrTSprF5mgncRvM6zDdmshjiODA/JivHRhTCjr5r6N79Qz/hp2obw== From: Marek Vasut DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1721741526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jQl6EXHpXLo5PWqlhK5rRfr4zbBkv4muqiVxIAXkgGQ=; b=GUFmAVkBQHMSD5lazSRknEiuJXc5lYFo0eg3UrETltp2s1JY/u+oZ0oCgXjrMlBbcmvg4z OfPH9GWHoHX/KmFwJZmGMesk9yHVKxC/FzcL8oPBDkHEAe1yjRkIACkVpYM9IuHcjMndqE MG1f7XBsTXqquHzTaYD5yVQYCAYVleuNn/eiJ5WkrpKHis82sbXaz1pB+ZXaf6w+C0DNeP 7GSxs3+FBexirJEFRq3WUsJ4pl+jNWsuoo8ndVch2SuTm1WSKm2h36OM9XfBL5Cm+JrCW+ iq/qkT7nfBJz9zyJh8qvYmQusrF2Ho10P2IMYe2XKm78lzhBXztLzL3cD1+CRQ== To: linux-pci@vger.kernel.org Cc: Marek Vasut , =?utf-8?q?Krzysztof_Wilcz?= =?utf-8?q?y=C5=84ski?= , =?utf-8?q?Pali_Roh=C3=A1r?= , =?utf-8?q?Uwe_Kleine-K=C3=B6?= =?utf-8?q?nig?= , Aleksandr Mishin , Anna-Maria Behnsen , Anup Patel , Bjorn Helgaas , Broadcom internal kernel review list , Daire McNamara , Damien Le Moal , Florian Fainelli , Hou Zhiqiang , Jianjun Wang , Jim Quinlan , Jingoo Han , Jisheng Zhang , Jon Hunter , Jonathan Derrick , Joyce Ooi , Karthikeyan Mitran , Kishon Vijay Abraham I , Koichiro Den , Lorenzo Pieralisi , Manivannan Sadhasivam , Marc Zyngier , Michal Simek , Nicolas Saenz Julienne , Niklas Cassel , Nipun Gupta , Nirmal Patel , Rob Herring , Ryder Lee , Shivamurthy Shastri , Siddharth Vadapalli , Thierry Reding , Thomas Gleixner , Thomas Petazzoni , Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: [PATCH v4 13/15] PCI: xilinx-nwl: Silence set affinity failed warning Date: Tue, 23 Jul 2024 15:27:13 +0200 Message-ID: <20240723132958.41320-14-marek.vasut+renesas@mailbox.org> In-Reply-To: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> References: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> MIME-Version: 1.0 X-MBO-RS-ID: f104b2b6e7f90328a1e X-MBO-RS-META: 1g1rr399msjc1bh3usj314swyu3bq4r6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240723_063210_479697_D2A425BE X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without printing "IRQ...: set affinity failed(-22)" warning. Remove .irq_set_affinity implementation which only return -EINVAL from this controller driver. Signed-off-by: Marek Vasut --- Cc: "Krzysztof Wilczyński" Cc: "Pali Rohár" Cc: "Uwe Kleine-König" Cc: Aleksandr Mishin Cc: Anna-Maria Behnsen Cc: Anup Patel Cc: Bjorn Helgaas Cc: Broadcom internal kernel review list Cc: Daire McNamara Cc: Damien Le Moal Cc: Florian Fainelli Cc: Hou Zhiqiang Cc: Jianjun Wang Cc: Jim Quinlan Cc: Jingoo Han Cc: Jisheng Zhang Cc: Jon Hunter Cc: Jonathan Derrick Cc: Jonathan Hunter Cc: Joyce Ooi Cc: Karthikeyan Mitran Cc: Kishon Vijay Abraham I Cc: Koichiro Den Cc: Lorenzo Pieralisi Cc: Manivannan Sadhasivam Cc: Marc Zyngier Cc: Michal Simek Cc: Nicolas Saenz Julienne Cc: Niklas Cassel Cc: Nipun Gupta Cc: Nirmal Patel Cc: Rob Herring Cc: Ryder Lee Cc: Shivamurthy Shastri Cc: Siddharth Vadapalli Cc: Thierry Reding Cc: Thomas Gleixner Cc: Thomas Petazzoni Cc: Yoshihiro Shimoda Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-pci@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-tegra@vger.kernel.org --- V4: - New patch --- drivers/pci/controller/pcie-xilinx-nwl.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c index 0408f4d612b5a..d5615cf8563f4 100644 --- a/drivers/pci/controller/pcie-xilinx-nwl.c +++ b/drivers/pci/controller/pcie-xilinx-nwl.c @@ -425,8 +425,8 @@ static struct irq_chip nwl_msi_irq_chip = { }; static struct msi_domain_info nwl_msi_domain_info = { - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | - MSI_FLAG_MULTI_PCI_MSI), + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | + MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI, .chip = &nwl_msi_irq_chip, }; #endif @@ -441,16 +441,9 @@ static void nwl_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) msg->data = data->hwirq; } -static int nwl_msi_set_affinity(struct irq_data *irq_data, - const struct cpumask *mask, bool force) -{ - return -EINVAL; -} - static struct irq_chip nwl_irq_chip = { .name = "Xilinx MSI", .irq_compose_msi_msg = nwl_compose_msi_msg, - .irq_set_affinity = nwl_msi_set_affinity, }; static int nwl_irq_domain_alloc(struct irq_domain *domain, unsigned int virq,