From patchwork Tue Jul 23 13:27:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 13740056 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29164C3DA49 for ; Tue, 23 Jul 2024 13:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QlsaWuidAL5RI8AvyPYKTmmYV22DqYfexUouesKrmXY=; b=ohmcCtU6G45gRf9F79vgOK1iJg uutQYcVViclOHFn213EOMqF5k0Bzhd5oVUk16FHNhK1JtU8AndiZJQ9xqya3WwCcYEPYID4rNfbeL yjTEbI3+YAsW9RdvyVu5Ut1esb8je376dLuX6mYOKilFtLSbgYyDIZFuPThyQY45MKniTJzOCVHPY 4OtXVubMYi12vyiFuzSOlDjsN5FwQNB4GQdw6quk1YLVl47cff9ejNoJcJ6zQ4KFgLaWRcV2z5r+/ /Ein2/GzZmA0JlEVelbehK8f0JC8MZBF5RZhU5Zj1/zqE8WJHNupKAsYyI41FNNr6T0zJaDMGqpRG cLBJFGyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWFeB-0000000CYXB-1T5p; Tue, 23 Jul 2024 13:33:43 +0000 Received: from mout-p-101.mailbox.org ([80.241.56.151]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWFbw-0000000CXYC-1pGU; Tue, 23 Jul 2024 13:31:26 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4WSyj55Cv5z9spD; Tue, 23 Jul 2024 15:31:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1721741481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QlsaWuidAL5RI8AvyPYKTmmYV22DqYfexUouesKrmXY=; b=O5PpebQ3xkx5Lr1qrFV9TdUQf2+jgFWk5KNDz4PwmB7T+nsBD1Z+LKO1/V1f11y49VNgA4 aShy9tQO97TcQKxqoK9w8B4Bs8ea2lThKP/yR+R3+AQIECxTUwwaDV9Cbx5Hg8tA6/1HFI D8T91CrXEgBYZFDm4hoLSyPH+CxUxa+0DRAn7V3f/3LXB98jjkDjts4ABNk05be5ik3ia8 wtsOcM80lolfbs3MnpBu+0orQ7WOaAZEe96f2gYItM/kvzf1rZPhr6qCK0nF2A+x5Uw90A Y0BvCknpHyOwkuMHYcHP8Jd6FN6LPimsIuu7Cq9QvxOeCI+Bor8Bywnwp5wlqA== From: Marek Vasut DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1721741479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QlsaWuidAL5RI8AvyPYKTmmYV22DqYfexUouesKrmXY=; b=h6o/O+FV9gt+lmpGWNmfFJu9RC4ih9kEinjtLPMrYN3UkugSqnNdF8LgJjLAG7c6wj04SZ 532GVRfBOomu/loOtUZDVundBQESKsVEfHkoAoRbhh4Smd7/qG123ZqEMOsd+fIVpdjtOZ 2ldIwSPapwAFg5JAvIOKgl5VVu6oujyy929YdBuQUIp7vAuAAAOWTDJT6N7qDqy+yyDcmn A9QhqGx57cH0TYGXOj5zRLZycBimBNvKrx/oYJ9uPcosq/IUs3QKU/Rte38Ihq/ZYfwvWs 7EDNMDdwYdeuJg6odZcyXrDDmg9G0Sy9PMy4tXSqT8L6j8dRylI2L5fzszEMxQ== To: linux-pci@vger.kernel.org Cc: Marek Vasut , =?utf-8?q?Krzysztof_Wilcz?= =?utf-8?q?y=C5=84ski?= , =?utf-8?q?Pali_Roh=C3=A1r?= , =?utf-8?q?Uwe_Kleine-K=C3=B6?= =?utf-8?q?nig?= , Aleksandr Mishin , Anna-Maria Behnsen , Anup Patel , Bjorn Helgaas , Broadcom internal kernel review list , Daire McNamara , Damien Le Moal , Florian Fainelli , Hou Zhiqiang , Jianjun Wang , Jim Quinlan , Jingoo Han , Jisheng Zhang , Jon Hunter , Jonathan Derrick , Joyce Ooi , Karthikeyan Mitran , Kishon Vijay Abraham I , Koichiro Den , Lorenzo Pieralisi , Manivannan Sadhasivam , Marc Zyngier , Michal Simek , Nicolas Saenz Julienne , Niklas Cassel , Nipun Gupta , Nirmal Patel , Rob Herring , Ryder Lee , Shivamurthy Shastri , Siddharth Vadapalli , Thierry Reding , Thomas Gleixner , Thomas Petazzoni , Yoshihiro Shimoda , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org Subject: [PATCH v4 06/15] PCI: mediatek-gen3: Silence set affinity failed warning Date: Tue, 23 Jul 2024 15:27:06 +0200 Message-ID: <20240723132958.41320-7-marek.vasut+renesas@mailbox.org> In-Reply-To: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> References: <20240723132958.41320-1-marek.vasut+renesas@mailbox.org> MIME-Version: 1.0 X-MBO-RS-ID: d727ed4a519b83792ea X-MBO-RS-META: 3984toaxbhuxegkxod1ibi51e6frj81f X-Rspamd-Queue-Id: 4WSyj55Cv5z9spD X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240723_063124_664169_CC686D0E X-CRM114-Status: GOOD ( 11.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use newly introduced MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity unset and allows migrate_one_irq() code in cpuhotplug.c to exit right away, without printing "IRQ...: set affinity failed(-22)" warning. Remove .irq_set_affinity implementation which only return -EINVAL from this controller driver. Signed-off-by: Marek Vasut Acked-by: Jianjun Wang --- Cc: "Krzysztof Wilczyński" Cc: "Pali Rohár" Cc: "Uwe Kleine-König" Cc: Aleksandr Mishin Cc: Anna-Maria Behnsen Cc: Anup Patel Cc: Bjorn Helgaas Cc: Broadcom internal kernel review list Cc: Daire McNamara Cc: Damien Le Moal Cc: Florian Fainelli Cc: Hou Zhiqiang Cc: Jianjun Wang Cc: Jim Quinlan Cc: Jingoo Han Cc: Jisheng Zhang Cc: Jon Hunter Cc: Jonathan Derrick Cc: Jonathan Hunter Cc: Joyce Ooi Cc: Karthikeyan Mitran Cc: Kishon Vijay Abraham I Cc: Koichiro Den Cc: Lorenzo Pieralisi Cc: Manivannan Sadhasivam Cc: Marc Zyngier Cc: Michal Simek Cc: Nicolas Saenz Julienne Cc: Niklas Cassel Cc: Nipun Gupta Cc: Nirmal Patel Cc: Rob Herring Cc: Ryder Lee Cc: Shivamurthy Shastri Cc: Siddharth Vadapalli Cc: Thierry Reding Cc: Thomas Gleixner Cc: Thomas Petazzoni Cc: Yoshihiro Shimoda Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-pci@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-tegra@vger.kernel.org --- V4: - New patch --- drivers/pci/controller/pcie-mediatek-gen3.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c index b7e8e24f6a408..392b6ef3473f2 100644 --- a/drivers/pci/controller/pcie-mediatek-gen3.c +++ b/drivers/pci/controller/pcie-mediatek-gen3.c @@ -424,12 +424,6 @@ static int mtk_pcie_startup_port(struct mtk_gen3_pcie *pcie) return 0; } -static int mtk_pcie_set_affinity(struct irq_data *data, - const struct cpumask *mask, bool force) -{ - return -EINVAL; -} - static void mtk_pcie_msi_irq_mask(struct irq_data *data) { pci_msi_mask_irq(data); @@ -450,8 +444,9 @@ static struct irq_chip mtk_msi_irq_chip = { }; static struct msi_domain_info mtk_msi_domain_info = { - .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | - MSI_FLAG_PCI_MSIX | MSI_FLAG_MULTI_PCI_MSI), + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | + MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX | + MSI_FLAG_MULTI_PCI_MSI, .chip = &mtk_msi_irq_chip, }; @@ -517,7 +512,6 @@ static struct irq_chip mtk_msi_bottom_irq_chip = { .irq_mask = mtk_msi_bottom_irq_mask, .irq_unmask = mtk_msi_bottom_irq_unmask, .irq_compose_msi_msg = mtk_compose_msi_msg, - .irq_set_affinity = mtk_pcie_set_affinity, .name = "MSI", }; @@ -618,7 +612,6 @@ static struct irq_chip mtk_intx_irq_chip = { .irq_mask = mtk_intx_mask, .irq_unmask = mtk_intx_unmask, .irq_eoi = mtk_intx_eoi, - .irq_set_affinity = mtk_pcie_set_affinity, .name = "INTx", };