| Message ID | 20240730013820.41702-6-mailingradian@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iommu/arm-smmu-qcom: Add SDM670 SMMU v2 | expand |
On 30/07/2024 03:38, Richard Acayan wrote: > Add the compatible for the separate IOMMU on SDM670 for the Adreno GPU. > > Signed-off-by: Richard Acayan <mailingradian@gmail.com> > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > index 36c6b36ad4ff..7f4b15be4a11 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > @@ -539,6 +539,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = { > { .compatible = "qcom,sc8180x-smmu-500", .data = &qcom_smmu_500_impl0_data }, > { .compatible = "qcom,sc8280xp-smmu-500", .data = &qcom_smmu_500_impl0_data }, > { .compatible = "qcom,sdm630-smmu-v2", .data = &qcom_smmu_v2_data }, > + { .compatible = "qcom,sdm670-smmu-v2", .data = &qcom_smmu_v2_data }, Do the people even read the comments? What the comment is saying? I admit it might be not precise, but "500" and "v2" are the same from that point of view. NAK. Best regards, Krzysztof
On Tue, Jul 30, 2024 at 08:23:44AM GMT, Krzysztof Kozlowski wrote: > On 30/07/2024 03:38, Richard Acayan wrote: > > Add the compatible for the separate IOMMU on SDM670 for the Adreno GPU. > > > > Signed-off-by: Richard Acayan <mailingradian@gmail.com> > > --- > > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > > index 36c6b36ad4ff..7f4b15be4a11 100644 > > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > > @@ -539,6 +539,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = { > > { .compatible = "qcom,sc8180x-smmu-500", .data = &qcom_smmu_500_impl0_data }, > > { .compatible = "qcom,sc8280xp-smmu-500", .data = &qcom_smmu_500_impl0_data }, > > { .compatible = "qcom,sdm630-smmu-v2", .data = &qcom_smmu_v2_data }, > > + { .compatible = "qcom,sdm670-smmu-v2", .data = &qcom_smmu_v2_data }, > > Do the people even read the comments? What the comment is saying? I > admit it might be not precise, but "500" and "v2" are the same from that > point of view. Well, the comment speaks about -500 explicitly, because -v2 have differences (it is known that these platforms require more quirks). > > NAK. > > Best regards, > Krzysztof >
diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c index 36c6b36ad4ff..7f4b15be4a11 100644 --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c @@ -539,6 +539,7 @@ static const struct of_device_id __maybe_unused qcom_smmu_impl_of_match[] = { { .compatible = "qcom,sc8180x-smmu-500", .data = &qcom_smmu_500_impl0_data }, { .compatible = "qcom,sc8280xp-smmu-500", .data = &qcom_smmu_500_impl0_data }, { .compatible = "qcom,sdm630-smmu-v2", .data = &qcom_smmu_v2_data }, + { .compatible = "qcom,sdm670-smmu-v2", .data = &qcom_smmu_v2_data }, { .compatible = "qcom,sdm845-smmu-v2", .data = &qcom_smmu_v2_data }, { .compatible = "qcom,sdm845-smmu-500", .data = &sdm845_smmu_500_data }, { .compatible = "qcom,sm6115-smmu-500", .data = &qcom_smmu_500_impl0_data},
Add the compatible for the separate IOMMU on SDM670 for the Adreno GPU. Signed-off-by: Richard Acayan <mailingradian@gmail.com> --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 1 + 1 file changed, 1 insertion(+)