| Message ID | 20240730102433.540260-2-andyshrk@163.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for Cool Pi GenBook | expand |
Hello Andy, On 2024-07-30 12:24, Andy Yan wrote: > Add Cool Pi CM5 GenBook, a laptop powered by RK3588. > > Cool Pi GenBook works with a carrier board connect with CM5. > > Signed-off-by: Andy Yan <andyshrk@163.com> Looking good to me, thanks for the v3. Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > > Changes in v3: > - Wrap commit message by a maximum 75 chars per line > - Remove the superfluous blank line > - Use "coolpi,pi-cm5-genbook" instead of "coolpi,genbook" > > Changes in v2: > - Descripte it as Cool Pi CM5 GenBook > > Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml > b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 2ad835f4068e..18ea4160e3e2 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -96,6 +96,13 @@ properties: > - const: coolpi,pi-cm5 > - const: rockchip,rk3588 > > + - description: Cool Pi CM5 GenBook > + items: > + - enum: > + - coolpi,pi-cm5-genbook > + - const: coolpi,pi-cm5 > + - const: rockchip,rk3588 > + > - description: Cool Pi 4 Model B > items: > - const: coolpi,pi-4b
On 30/07/2024 12:24, Andy Yan wrote: > Add Cool Pi CM5 GenBook, a laptop powered by RK3588. > > Cool Pi GenBook works with a carrier board connect with CM5. > > Signed-off-by: Andy Yan <andyshrk@163.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 2ad835f4068e..18ea4160e3e2 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -96,6 +96,13 @@ properties: - const: coolpi,pi-cm5 - const: rockchip,rk3588 + - description: Cool Pi CM5 GenBook + items: + - enum: + - coolpi,pi-cm5-genbook + - const: coolpi,pi-cm5 + - const: rockchip,rk3588 + - description: Cool Pi 4 Model B items: - const: coolpi,pi-4b
Add Cool Pi CM5 GenBook, a laptop powered by RK3588. Cool Pi GenBook works with a carrier board connect with CM5. Signed-off-by: Andy Yan <andyshrk@163.com> --- Changes in v3: - Wrap commit message by a maximum 75 chars per line - Remove the superfluous blank line - Use "coolpi,pi-cm5-genbook" instead of "coolpi,genbook" Changes in v2: - Descripte it as Cool Pi CM5 GenBook Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++ 1 file changed, 7 insertions(+)