| Message ID | 20240731141103.2559706-2-luca.fancellu@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Armv8-R AArch64 support | expand |
On Wed, Jul 31, 2024 at 03:11:00PM +0100, Luca Fancellu wrote: > Introduce a new autoconf parameter --with-bw-arch that takes > 'aarch64-a' and 'aarch32-a' as compile architecture, the former > is selected by default when the parameter is not passed. > > This new parameter superseed --enable-aarch32-bw, its functionality > is now implemented by --with-bw-arch=aarch32-a. > > Signed-off-by: Luca Fancellu <luca.fancellu@arm.com> > --- > Changes from v2: > - Major rework, reason in the cover letter. > --- > configure.ac | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index ce41daebc378..bba42fa1dba8 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -9,9 +9,18 @@ AC_INIT([boot-wrapper], [v0.2]) > > AM_INIT_AUTOMAKE([foreign]) > > -AC_ARG_ENABLE([aarch32-bw], > - AS_HELP_STRING([--enable-aarch32-bw], [build a 32-bit boot-wrapper]), > - [BOOTWRAPPER_ES=32], [BOOTWRAPPER_ES=64]) > +# Allow a user to pass --with-bw-arch={aarch64-a,aarch32-a} > +AC_ARG_WITH([bw-arch], > + AS_HELP_STRING([--with-bw-arch], [aarch64-a selects AArch64-A (default), aarch32-a selects AArch32-A]), Could we we please make the help text: specify boot-wrapper architecture: aarch64-a (default) or aarch32-a That way ist says what the option does, and it avoids the repeition. With that change I think this looks good to go. Mark. > + [case "${withval}" in > + no|yes|aarch64-a) USE_ARCH=aarch64-a ;; > + aarch32-a) USE_ARCH=aarch32-a ;; > + *) AC_MSG_ERROR([Bad value "${withval}" for --with-bw-arch. Use "aarch64-a" or "aarch32-a"]) ;; > + esac]) > + > +AS_IF([test "x$USE_ARCH" = "xaarch32-a"], > + [BOOTWRAPPER_ES=32], [BOOTWRAPPER_ES=64] > +) > AM_CONDITIONAL([BOOTWRAPPER_32], [test "x$BOOTWRAPPER_ES" = "x32"]) > > AC_ARG_ENABLE([aarch32-kernel], > -- > 2.34.1 >
diff --git a/configure.ac b/configure.ac index ce41daebc378..bba42fa1dba8 100644 --- a/configure.ac +++ b/configure.ac @@ -9,9 +9,18 @@ AC_INIT([boot-wrapper], [v0.2]) AM_INIT_AUTOMAKE([foreign]) -AC_ARG_ENABLE([aarch32-bw], - AS_HELP_STRING([--enable-aarch32-bw], [build a 32-bit boot-wrapper]), - [BOOTWRAPPER_ES=32], [BOOTWRAPPER_ES=64]) +# Allow a user to pass --with-bw-arch={aarch64-a,aarch32-a} +AC_ARG_WITH([bw-arch], + AS_HELP_STRING([--with-bw-arch], [aarch64-a selects AArch64-A (default), aarch32-a selects AArch32-A]), + [case "${withval}" in + no|yes|aarch64-a) USE_ARCH=aarch64-a ;; + aarch32-a) USE_ARCH=aarch32-a ;; + *) AC_MSG_ERROR([Bad value "${withval}" for --with-bw-arch. Use "aarch64-a" or "aarch32-a"]) ;; + esac]) + +AS_IF([test "x$USE_ARCH" = "xaarch32-a"], + [BOOTWRAPPER_ES=32], [BOOTWRAPPER_ES=64] +) AM_CONDITIONAL([BOOTWRAPPER_32], [test "x$BOOTWRAPPER_ES" = "x32"]) AC_ARG_ENABLE([aarch32-kernel],
Introduce a new autoconf parameter --with-bw-arch that takes 'aarch64-a' and 'aarch32-a' as compile architecture, the former is selected by default when the parameter is not passed. This new parameter superseed --enable-aarch32-bw, its functionality is now implemented by --with-bw-arch=aarch32-a. Signed-off-by: Luca Fancellu <luca.fancellu@arm.com> --- Changes from v2: - Major rework, reason in the cover letter. --- configure.ac | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-)