From patchwork Sat Aug 3 06:49:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cuigaosheng X-Patchwork-Id: 13752310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F515C52D70 for ; Sat, 3 Aug 2024 06:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BfsqPYjIDYPjFbs+3Nuun7rEG6V84I/Q80COFA88coU=; b=CJ/6gVrqVT/LDuM0gsyDDiRoa1 0dD17JUTui58bSTZVqRJOZXlpFsjc5EX9wbQOClDpOlTDiFm2gBF6Wf0lH/rG8qdfy8YvPuyXGPxa ZM6PZsHeGqBfOykNsAZEmT3fpstuhznrjsZ9PsckgcDdp6BmswFtBj2+6erHFg7umQTXRilEP7hng MsfXxqWqgQViyuxVRutlnHG2Rwzy0Uq1FZuUlN26JVxcJefMsKY0mNxFtiszs73B5KvkvrbcKI1ul O88s2MFMboAeHV8M/POUkEjciaxOJNWu8kEOYitPr2jv+n/4cmkLkkawHUmx5PN34g9foi5GPJvPK 1W0cEQgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa8aU-0000000AvhV-3THI; Sat, 03 Aug 2024 06:49:58 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa8Zy-0000000AvfD-47zQ; Sat, 03 Aug 2024 06:49:28 +0000 Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WbYFy2hD6z1L9dZ; Sat, 3 Aug 2024 14:49:10 +0800 (CST) Received: from kwepemd200011.china.huawei.com (unknown [7.221.188.251]) by mail.maildlp.com (Postfix) with ESMTPS id 651521400D1; Sat, 3 Aug 2024 14:49:25 +0800 (CST) Received: from cgs.huawei.com (10.244.148.83) by kwepemd200011.china.huawei.com (7.221.188.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Sat, 3 Aug 2024 14:49:24 +0800 From: Gaosheng Cui To: , , , , , , , , , , , CC: , , Subject: [PATCH -next 1/2] hwrng: bcm2835 - Add missing clk_disable_unprepare in bcm2835_rng_init Date: Sat, 3 Aug 2024 14:49:22 +0800 Message-ID: <20240803064923.337696-2-cuigaosheng1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240803064923.337696-1-cuigaosheng1@huawei.com> References: <20240803064923.337696-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.244.148.83] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemd200011.china.huawei.com (7.221.188.251) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240802_234927_200179_AD4B2D2C X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add the missing clk_disable_unprepare() before return in bcm2835_rng_init(). Signed-off-by: Gaosheng Cui Reviewed-by: Florian Fainelli --- drivers/char/hw_random/bcm2835-rng.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/char/hw_random/bcm2835-rng.c b/drivers/char/hw_random/bcm2835-rng.c index b03e80300627..aa2b135e3ee2 100644 --- a/drivers/char/hw_random/bcm2835-rng.c +++ b/drivers/char/hw_random/bcm2835-rng.c @@ -94,8 +94,10 @@ static int bcm2835_rng_init(struct hwrng *rng) return ret; ret = reset_control_reset(priv->reset); - if (ret) + if (ret) { + clk_disable_unprepare(priv->clk); return ret; + } if (priv->mask_interrupts) { /* mask the interrupt */