From patchwork Sat Aug 3 06:49:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: cuigaosheng X-Patchwork-Id: 13752311 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55C8EC3DA4A for ; Sat, 3 Aug 2024 06:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y6PIGNPuU+xgGvL6XxavASXJkcHXu7oIeiKSQ43DwWw=; b=EpotEQEeLSIiUZTkzJcNOlbQdm PU5qVUrnQ8kMYqJcBqjkrJr+U9Tl2BhKzYZLNosvLl7b1Hk4iIstVSn8dRm2byhkSFRcYcro8bjOU TrKbfRLmmvQ46JC+bVnwQKMHV1e+WTX3nGd2iYG4tkVGAJoWV2NyOESwjkChPocz/FfXb7Ggd7xV0 bVMAiyFOg629e5NUpBi8y43S6h7gvIbAlKT800o1as4Oo4XtsXE8AUQb1t/j2qRumI2KdlwHsOYKm VBWbn0Abxf6s09XcDIJJ8gwMPbPH1YIpVWd12QS4T0H8XyurBgAEcfqtdD6FU/Ros5Xej7R+jJ1op 86xt+SYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa8ay-0000000AvnJ-2xGi; Sat, 03 Aug 2024 06:50:28 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sa8Zz-0000000AvfF-1anA; Sat, 03 Aug 2024 06:49:28 +0000 Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WbYFy6S1Rz1L9dg; Sat, 3 Aug 2024 14:49:10 +0800 (CST) Received: from kwepemd200011.china.huawei.com (unknown [7.221.188.251]) by mail.maildlp.com (Postfix) with ESMTPS id E7D701400DC; Sat, 3 Aug 2024 14:49:25 +0800 (CST) Received: from cgs.huawei.com (10.244.148.83) by kwepemd200011.china.huawei.com (7.221.188.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.34; Sat, 3 Aug 2024 14:49:25 +0800 From: Gaosheng Cui To: , , , , , , , , , , , CC: , , Subject: [PATCH -next 2/2] hwrng: cctrng - Add missing clk_disable_unprepare in cctrng_resume Date: Sat, 3 Aug 2024 14:49:23 +0800 Message-ID: <20240803064923.337696-3-cuigaosheng1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240803064923.337696-1-cuigaosheng1@huawei.com> References: <20240803064923.337696-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.244.148.83] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemd200011.china.huawei.com (7.221.188.251) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240802_234927_771920_863A15A8 X-CRM114-Status: UNSURE ( 7.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add the missing clk_disable_unprepare() before return in cctrng_resume(). Signed-off-by: Gaosheng Cui --- drivers/char/hw_random/cctrng.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/cctrng.c b/drivers/char/hw_random/cctrng.c index c0d2f824769f..4c50efc46483 100644 --- a/drivers/char/hw_random/cctrng.c +++ b/drivers/char/hw_random/cctrng.c @@ -622,6 +622,7 @@ static int __maybe_unused cctrng_resume(struct device *dev) /* wait for Cryptocell reset completion */ if (!cctrng_wait_for_reset_completion(drvdata)) { dev_err(dev, "Cryptocell reset not completed"); + clk_disable_unprepare(drvdata->clk); return -EBUSY; }