From patchwork Mon Aug 5 23:38:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 13754250 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94B8FC3DA7F for ; Mon, 5 Aug 2024 23:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dnncB28XY0s0oOAoP5k3joEIwhuPT0nv/d7oPA6DHTI=; b=W34T2vnmssftRCz/vG5ntfVrrQ 20Vu428Bv6fR+xMCF8keiVlyu71kiqkhM1qhnmZBr45DuEpO+UvPJ4bgO28lAom0JjlMOS4FfhiSs o2KlyYqaVY8Dbd/Ju9Al+fZpVgmv7afnaoAYGd2Ys11Xdg1jXD0khCK3neUqRUuWO4JnC6F1GuoXq WlBGf1nGsNxa9V3PEX2H3/JwOSrBSJE85bV/eQP3IOkNQUeOe5N1r+VMo73r1IQogUYGwT5ShW8rD EMww6MViZg23cq6tbOJ8OBoEc2qEeP20j6dhEbR0yqW4adwN7OBlZI447UYfChkJhlzwJAOg61/vG lz1X1iHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb7Jo-0000000Hb5J-31hf; Mon, 05 Aug 2024 23:40:48 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sb7IK-0000000Hafi-2oNX for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2024 23:39:18 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1ff3d5c6e9eso24545ad.1 for ; Mon, 05 Aug 2024 16:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1722901156; x=1723505956; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dnncB28XY0s0oOAoP5k3joEIwhuPT0nv/d7oPA6DHTI=; b=ps59fNCgtcmSaUj6XkLPBaK18p7kaj7lQPRA1jNV+XIdhgp0fy3oO+CQNKFfnspO7F fm7o6nkBTwjBRaEguqOHtJxpMEm0vaa/2c8JinFE7P270vRsfSENYjIgBF7HvCYAkZ8m hNkDHDczE+RxaTelpnepvAM3JrL8I/QovymcUIJAF+dsTHPwXKpL+qgebO9hY6G7Ts0/ hAJajBYFLa+P5KP8HlMbP90XCLmljMzu3G6qlpBPHo40DPVlKciqf81djLhDFnw7DZK2 j7WumAK4hsLNlcHa025quo/DNeMxK/Q76WXkjsGzzc0FP/ktNTr+KYAmt5VH8OOROBdU x5FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722901156; x=1723505956; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dnncB28XY0s0oOAoP5k3joEIwhuPT0nv/d7oPA6DHTI=; b=OY6nG9gz7ypOAnILRSS0/grhROVJjJdhDG5pioiqn8jNAl9hTR+o+gre6fbIkDPNUv TZnP9FGRoRVD/jZHLjGR+xL67tz+LdOXY6PoRut3vaNdfnfaL07hHPJeGjbc6kZGHzEH EvQ/bN7qAfduq4azezY41uaF93En706dTnzfFYa3l27LW9a6cum+pMNR2WU81Q2olHUC 7uWVBRUnIbG7fUQDiUpY5cQ387klwJBFYqCLogMPlr1cJvuZOkQNwIw5OfQxhvKXchts T9XNQi93sIF7wAbTsjeoEn+0PVtAICRxpWN0bGsnzCcsnfAGIXE88PaKzdjW6lAnRJ1s V2Aw== X-Forwarded-Encrypted: i=1; AJvYcCWqZxI28JWdxV8f33ofx7icsOyh4irmVnxvhCA8TeR8TPFftQKfC4iFllEOLcCugpAj2ohYIY0XxTKer//dzvO8fVMvkhOqSDXv6EoAbOTPqamwwgU= X-Gm-Message-State: AOJu0YyOVbiCDvdYfz7h5ZU5Xsz8aP9p9BzYICKk/CldLK2U/N/LngZE /JTP+qmBbc9OQ6+m40mpATAzINn0gr8fKmlTHJh0SLoiCVOB+dJTS5b8iLlbP6o= X-Google-Smtp-Source: AGHT+IHobvQnstPph5Yb+ux00NdxLtNlQ9qF1pXoXFjnb5XD56fo2xQmXa90/jkJt5RoCFpipa+Xlg== X-Received: by 2002:a17:902:e84a:b0:1ff:39d7:a1b0 with SMTP id d9443c01a7336-1ff57495cb2mr144665765ad.50.1722901155669; Mon, 05 Aug 2024 16:39:15 -0700 (PDT) Received: from localhost ([71.212.170.185]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff5928ee8dsm74218375ad.230.2024.08.05.16.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Aug 2024 16:39:15 -0700 (PDT) From: Kevin Hilman Date: Mon, 05 Aug 2024 16:38:40 -0700 Subject: [PATCH 2/3] pmdomain: ti_sci: add wakeup constraint management MIME-Version: 1.0 Message-Id: <20240805-lpm-v6-10-constraints-pmdomain-v1-2-d186b68ded4c@baylibre.com> References: <20240805-lpm-v6-10-constraints-pmdomain-v1-0-d186b68ded4c@baylibre.com> In-Reply-To: <20240805-lpm-v6-10-constraints-pmdomain-v1-0-d186b68ded4c@baylibre.com> To: Ulf Hansson Cc: Nishanth Menon , Vibhore Vardhan , Dhruva Gole , Akashdeep Kaur , Sebin Francis , Markus Schneider-Pargmann , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 20240801195422.2296347-1-msp@baylibre.com X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2001; i=khilman@baylibre.com; h=from:subject:message-id; bh=fQs2VJ8lfyMR9SmNHWMLjdsigTfsq4Jxqit4bVCGBXo=; b=owEBbQKS/ZANAwAKAVk3GJrT+8ZlAcsmYgBmsWKggzNV78j/AecMl1EMuzfzjzwYnxTYwr5x8 x7D5mlMcnuJAjMEAAEKAB0WIQR7h0YOFpJ/qfW/8QxZNxia0/vGZQUCZrFioAAKCRBZNxia0/vG ZW/ED/9MaNuCpYxFfobOqYpMTwSVORQik9ViMNI3YunHM+6xvl2bejNcU/Z4/VLi71VgnPkiE/S +3fHFhryjLo6CyDnG06Tx2NTFyvzJ1LWU7D2IGgu04Oif1ZkCtTLnqF/bT7ef5CMiM5n2GTkCCV MwPfleDsab5aeKMGq7wqjiw5USlC/QpkV5sXFViEvl4lcBfC9/2PAeEMFloZZyrqBd88wPxoaBU QOQ0u3CaLwDMrfRzv7bf1qtbiwF5IaUYLOUUbADewasZMakk9OBG6MsP16c1VgIJx+zar2YEwUn e3+lvuPJy7zsnnkgGKxlgjMaA58yTaug0tuHfAb8bHQRp/v/UyPCLUSiKXtk2UDKocyTXlk+wqC jEcVJSEWUK6IqFRhAMndi/BmrRUuD+r+n4oOQVJV9tvfOFirZNAWrZP7Zcg8ng1i8NDzBfCLTcZ maEyngcANbznb48ts2he44FewEQFwfbnO0UIb5mXcb3DmcpZGKMX9Wd2bV/koMpyKRNO/0GjrUM cZkb0xfy6E0R3enQK3twcCJUvNRbM7gckNenDS7YoWeG6zl20T8McPPsZoJU+mjF8cMJV1O3NXB Jl9AZkcX5UVjKe9O0eV1MUTU9G6BN95yY0TK1R0DuQaX382qjPZJIcoOb/XMBrCdG39Gv+U9V3U 90oy9xdSJYM4VHg== X-Developer-Key: i=khilman@baylibre.com; a=openpgp; fpr=7B87460E16927FA9F5BFF10C5937189AD3FBC665 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_163916_745083_1C8812F7 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org During system-wide suspend, check all devices connected to PM domain to see if they are wakeup-enabled. If so, set a TI SCI device constraint. Note: DM firmware clears all constraints on resume. Co-developed-by: Vibhore Vardhan Signed-off-by: Vibhore Vardhan Signed-off-by: Kevin Hilman Signed-off-by: Dhruva Gole --- drivers/pmdomain/ti/ti_sci_pm_domains.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c index 4dc48a97f9b8..7cd6ae957289 100644 --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c @@ -51,6 +51,7 @@ struct ti_sci_pm_domain { struct ti_sci_genpd_provider *parent; s32 lat_constraint; bool constraint_sent; + bool wkup_constraint; }; #define genpd_to_ti_sci_pd(gpd) container_of(gpd, struct ti_sci_pm_domain, pd) @@ -87,6 +88,26 @@ static inline void ti_sci_pd_clear_constraints(struct device *dev) pd->lat_constraint = PM_QOS_RESUME_LATENCY_NO_CONSTRAINT; pd->constraint_sent = false; + pd->wkup_constraint = false; +} + +static inline bool ti_sci_pd_check_wkup_constraint(struct device *dev) +{ + struct generic_pm_domain *genpd = pd_to_genpd(dev->pm_domain); + struct ti_sci_pm_domain *pd = genpd_to_ti_sci_pd(genpd); + const struct ti_sci_handle *ti_sci = pd->parent->ti_sci; + int ret; + + if (device_may_wakeup(dev)) { + ret = ti_sci->ops.pm_ops.set_device_constraint(ti_sci, pd->idx, + TISCI_MSG_CONSTRAINT_SET); + if (!ret) { + pd->wkup_constraint = true; + dev_dbg(dev, "ti_sci_pd: ID:%d set device constraint.\n", pd->idx); + } + } + + return pd->wkup_constraint; } /* @@ -158,6 +179,8 @@ static int ti_sci_pd_suspend(struct device *dev) } pd->lat_constraint = val; + ti_sci_pd_check_wkup_constraint(dev); + return 0; }