| Message ID | 20240806214605.3379881-4-jm@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix ESM source interrupts | expand |
On 16:46-20240806, Judith Mendez wrote: > From: Santhosh Kumar K <s-k6@ti.com> > > Remove 'reserved' status for MCU ESM node in AM62P device tree. Why? > > Signed-off-by: Santhosh Kumar K <s-k6@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi > index e65db6ce02bf6..d913e6319bad8 100644 > --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi > @@ -27,7 +27,6 @@ mcu_esm: esm@4100000 { > compatible = "ti,j721e-esm"; > reg = <0x00 0x4100000 0x00 0x1000>; > ti,esm-pins = <0>, <1>, <2>, <85>; > - status = "reserved"; > bootph-pre-ram; > }; > > -- > 2.45.2 >
Hi Nishanth, On 8/7/24 6:46 AM, Nishanth Menon wrote: > On 16:46-20240806, Judith Mendez wrote: >> From: Santhosh Kumar K <s-k6@ti.com> >> >> Remove 'reserved' status for MCU ESM node in AM62P device tree. > > Why? Main ESM reset is routed to the MCU ESM, hense enable MCU ESM in DT to be able to reset the CPU. >> >> Signed-off-by: Santhosh Kumar K <s-k6@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi >> index e65db6ce02bf6..d913e6319bad8 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi >> @@ -27,7 +27,6 @@ mcu_esm: esm@4100000 { >> compatible = "ti,j721e-esm"; >> reg = <0x00 0x4100000 0x00 0x1000>; >> ti,esm-pins = <0>, <1>, <2>, <85>; >> - status = "reserved"; >> bootph-pre-ram; >> }; >> >> -- >> 2.45.2 >> >
On 10:13-20240807, Judith Mendez wrote: > Hi Nishanth, > > On 8/7/24 6:46 AM, Nishanth Menon wrote: > > On 16:46-20240806, Judith Mendez wrote: > > > From: Santhosh Kumar K <s-k6@ti.com> > > > > > > Remove 'reserved' status for MCU ESM node in AM62P device tree. > > > > Why? > > Main ESM reset is routed to the MCU ESM, hense enable > MCU ESM in DT to be able to reset the CPU. please document that in the commit message - please review the rest of the patches as well. Is this problem present on other related AM6 products as well - will be good to audit and fixup in the series?
On 8/7/24 10:26 AM, Nishanth Menon wrote: > On 10:13-20240807, Judith Mendez wrote: >> Hi Nishanth, >> >> On 8/7/24 6:46 AM, Nishanth Menon wrote: >>> On 16:46-20240806, Judith Mendez wrote: >>>> From: Santhosh Kumar K <s-k6@ti.com> >>>> >>>> Remove 'reserved' status for MCU ESM node in AM62P device tree. >>> >>> Why? >> >> Main ESM reset is routed to the MCU ESM, hense enable >> MCU ESM in DT to be able to reset the CPU. > > please document that in the commit message - please review the rest > of the patches as well. Is this problem present on other related AM6 > products as well - will be good to audit and fixup in the series? Sure, am62x and am64x should be fine, only platform left to check is am65x. So will verify that and send v2 with commit message fixed, thanks for reviewing! ~ Judith
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi index e65db6ce02bf6..d913e6319bad8 100644 --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi @@ -27,7 +27,6 @@ mcu_esm: esm@4100000 { compatible = "ti,j721e-esm"; reg = <0x00 0x4100000 0x00 0x1000>; ti,esm-pins = <0>, <1>, <2>, <85>; - status = "reserved"; bootph-pre-ram; };