From patchwork Wed Aug 7 11:58:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Draszik?= X-Patchwork-Id: 13756180 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6040DC3DA7F for ; Wed, 7 Aug 2024 11:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CMjvgficlM8E7OFHsCNQI4tsZ98VKn4/e3uEzM8rqJg=; b=ft5dqHPC7g3algFCqbuePxWGC5 mgYiyaO5uQPh9bpA+SJsN3JaPjCAgkwxdDeTsxbgcuECST6zvrsnel0evKUemA8KGQaW15b5SvkiV dbHE8CBtitoNNK00x5m++m6EaiipbX/LORY28X1SEA8aw4kc+HPytY55uoVtgT6ayt6nxjV0ghPx8 Q0Y/irkLdH912qSgD1Z5TtZiPyhHXqSDUWNTJhcShNCwr+wKPZxeBUr8LAOD4W3k5Sa3pxCjod+0m AVNpOfJdwdC73MSehcfbGJh9Mt25p8vCas9a4VlmIcUX5tEq1VJ1iO5Zf59pMnpedKDhy3MQW3XeL IWzyX6dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbfJf-00000004vuQ-1iUo; Wed, 07 Aug 2024 11:58:55 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbfJ6-00000004vn7-1jF3 for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2024 11:58:21 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a7a975fb47eso218240466b.3 for ; Wed, 07 Aug 2024 04:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723031899; x=1723636699; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CMjvgficlM8E7OFHsCNQI4tsZ98VKn4/e3uEzM8rqJg=; b=nImu2TlGHcCxEnTRLfkNejAFZPuY/71NdOsVps2Pa4SsABnarxpqci9XGQ7WjzYRMS o4QQiS7uVlvxnGDAQEqksXbJmwzeqTg5cRWuHYEkqERmgH5+GtdFXlASsnYdcMOhnp5U WJ9xLD3a+97M16QZWyMLhZRfxfE9zSrruMSPA1AsG5k0nzKRA3v5Ux2sL/IGvTwUDCKL LHDxIGcpEOKMwk0II/UNpR4gtTmVfp0w4lqRU8rH5jYFyQyMUXHfBrl1iR9p7n9YESkB HJa4R9rZLaXvPRZ60LpcvUDGsrpBwq3NeISMu6bpIDtN15L2MQEL1rDQt2UtxzNDqPqx u9YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723031899; x=1723636699; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CMjvgficlM8E7OFHsCNQI4tsZ98VKn4/e3uEzM8rqJg=; b=wLj0N5fb+4LPIp59lJ1DzPHMYgZ+BO040Q74kASmLvzFgTKhBReEG+Dm+ws3IHzSa+ 1MATcPVeljd7/1bvnpq8Turlw76cjXVooYDGW32Hfp2DDn1tDzj9F463Tid7DBrD0jQf tcE1iMRdV0GpC1jvGUJsRZsxjV8x2CGIGODTTwnqeCKi53Dfv6Bw0kIQjDdk+cY0mQaf 1hvGU2kFbOntPjI/fGncuSv4EyaQsebJzmyo0AvcfSddgJY12xb0rJBZb5wAGh63GgFR qbgJ8ObwWrV0fQSvePk6iKBhwI5fecmSvyYY4wGV+wuw/uNGYodL6DbnVfGHDl4cobD1 NmRw== X-Forwarded-Encrypted: i=1; AJvYcCVlunlfwbIQBxjGTdWHnqSq5CLVj87fwd1x7Xuhp3wf7qrtNP6DppFkDqKC6jFOU9JZYxD+9tnwFZs9C6lxeOehAOR52Q1KyEbWZNKHaPTCSqvLFeI= X-Gm-Message-State: AOJu0YybDl8lTiaraXEmouoe0Mprtcyzy+W0eV/ENy6ezDKw3x9ogMf/ LfIo7VNbWWR9Di9uss9n34eiSez0a9DuukHkX/QagCDbnv75Qu5fEKcqswxroESaw/ij9nryepR 5MRBzYQ== X-Google-Smtp-Source: AGHT+IFX/mnj8z/gOU4S/Qjsm2FR4qQxyCrhiZEmvGKW7LyZfNdC7JaX0Q3SxwF74ucLtHDokfAeBQ== X-Received: by 2002:a17:907:1c19:b0:a6f:4fc8:2666 with SMTP id a640c23a62f3a-a7dc506ce86mr1394858366b.44.1723031898724; Wed, 07 Aug 2024 04:58:18 -0700 (PDT) Received: from puffmais.c.googlers.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9d45239sm631017466b.119.2024.08.07.04.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 04:58:18 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 07 Aug 2024 12:58:18 +0100 Subject: [PATCH v2 1/2] tty: serial: samsung_tty: drop unused argument to irq handlers MIME-Version: 1.0 Message-Id: <20240807-samsung-tty-cleanup-v2-1-1db5afc9d41b@linaro.org> References: <20240807-samsung-tty-cleanup-v2-0-1db5afc9d41b@linaro.org> In-Reply-To: <20240807-samsung-tty-cleanup-v2-0-1db5afc9d41b@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, =?utf-8?q?Andr?= =?utf-8?q?=C3=A9_Draszik?= X-Mailer: b4 0.13.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_045820_633920_F3D99E35 X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The 'irq' argument is not used in any of the callees, we can just drop it and simplify the code. No functional changes. Reviewed-by: Tudor Ambarus Signed-off-by: André Draszik --- drivers/tty/serial/samsung_tty.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index dc35eb77d2ef..1c6d0ffe5649 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -855,7 +855,7 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id) return IRQ_HANDLED; } -static irqreturn_t s3c24xx_serial_rx_irq(int irq, void *dev_id) +static irqreturn_t s3c24xx_serial_rx_irq(void *dev_id) { struct s3c24xx_uart_port *ourport = dev_id; @@ -928,7 +928,7 @@ static void s3c24xx_serial_tx_chars(struct s3c24xx_uart_port *ourport) s3c24xx_serial_stop_tx(port); } -static irqreturn_t s3c24xx_serial_tx_irq(int irq, void *id) +static irqreturn_t s3c24xx_serial_tx_irq(void *id) { struct s3c24xx_uart_port *ourport = id; struct uart_port *port = &ourport->port; @@ -950,11 +950,11 @@ static irqreturn_t s3c64xx_serial_handle_irq(int irq, void *id) irqreturn_t ret = IRQ_HANDLED; if (pend & S3C64XX_UINTM_RXD_MSK) { - ret = s3c24xx_serial_rx_irq(irq, id); + ret = s3c24xx_serial_rx_irq(id); wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_RXD_MSK); } if (pend & S3C64XX_UINTM_TXD_MSK) { - ret = s3c24xx_serial_tx_irq(irq, id); + ret = s3c24xx_serial_tx_irq(id); wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_TXD_MSK); } return ret; @@ -971,11 +971,11 @@ static irqreturn_t apple_serial_handle_irq(int irq, void *id) if (pend & (APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO)) { wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO); - ret = s3c24xx_serial_rx_irq(irq, id); + ret = s3c24xx_serial_rx_irq(id); } if (pend & APPLE_S5L_UTRSTAT_TXTHRESH) { wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_TXTHRESH); - ret = s3c24xx_serial_tx_irq(irq, id); + ret = s3c24xx_serial_tx_irq(id); } return ret;