From patchwork Thu Aug 8 11:07:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: MD Danish Anwar X-Patchwork-Id: 13757262 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48172C52D6F for ; Thu, 8 Aug 2024 11:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=unFGtIaLV852e7NhQ88rKDTvf4aXBnMYM/ojLpB9pCg=; b=CTF1DlqIpeT22gZkWUUwojgeTm ucFQNAhNYeAiuRszZymGw6uG+G/sGCLChCgTEhQNL1qcF/D2m8y4QfCwsgoTKK008fm4rXqKsqVzE m+pTpQCk5vWryDTUvqVyodpBraNc8HJofc0kcYNlU1JFOyNcv9onP5DjiQZctOdbey4UeFgrLmk0Y mu4uS3NAULOxpAMbS07H7vEONqrgSKUJ1wOZ41Jud+9Wt+5HUmzaZbyucVyDd9JKjmvUlgHChHfzu 0g1OGxbQi6aY5+/MLWq1H8s3c+w0q8WQQMpWrqyfXqIBRVoIEJAskyYFVFEOb8tRS+4LgLPWC3nit 8wO3yvvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc12r-000000081R4-2oQC; Thu, 08 Aug 2024 11:11:01 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sc10G-000000080fW-1gnZ for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2024 11:08:21 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 478B85hD121883; Thu, 8 Aug 2024 06:08:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1723115285; bh=unFGtIaLV852e7NhQ88rKDTvf4aXBnMYM/ojLpB9pCg=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=wDObhFiC9wTvQcNl86pIimGk2BZ6Dce6A9GldXrb2vxo9T0O1gp3EyOs0gvlrmWIa OE9/LYPCsZohWCS+hHALn5Z/RKbEAPLgytgZuuL4vftnvo8krD+lh3s+VQG0147anb RBH1ZiIkX4qH2de91Td1Ut36aCEvMmMrK9wzfzWw= Received: from DLEE110.ent.ti.com (dlee110.ent.ti.com [157.170.170.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 478B85Qa017878 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Aug 2024 06:08:05 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 8 Aug 2024 06:08:05 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 8 Aug 2024 06:08:05 -0500 Received: from fllv0122.itg.ti.com (fllv0122.itg.ti.com [10.247.120.72]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 478B85vu087519; Thu, 8 Aug 2024 06:08:05 -0500 Received: from localhost (danish-tpc.dhcp.ti.com [10.24.69.25]) by fllv0122.itg.ti.com (8.14.7/8.14.7) with ESMTP id 478B84Kw011988; Thu, 8 Aug 2024 06:08:04 -0500 From: MD Danish Anwar To: Jan Kiszka , Dan Carpenter , Andrew Lunn , Vignesh Raghavendra , Javier Carrasco , Diogo Ivo , Jacob Keller , Simon Horman , Richard Cochran , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" CC: , , , , Roger Quadros Subject: [PATCH net-next 1/6] net: ti: icssg-prueth: Enable IEP1 Date: Thu, 8 Aug 2024 16:37:55 +0530 Message-ID: <20240808110800.1281716-2-danishanwar@ti.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240808110800.1281716-1-danishanwar@ti.com> References: <20240808110800.1281716-1-danishanwar@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240808_040820_559180_5FF91856 X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org IEP1 is needed by firmware to enable FDB learning and FDB ageing. Always enable IEP1 Signed-off-by: MD Danish Anwar --- drivers/net/ethernet/ti/icssg/icssg_prueth.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c index 9dc9de39bb8f..c61423118319 100644 --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c @@ -1255,12 +1255,8 @@ static int prueth_probe(struct platform_device *pdev) goto put_iep0; } - if (prueth->pdata.quirk_10m_link_issue) { - /* Enable IEP1 for FW in 64bit mode as W/A for 10M FD link detect issue under TX - * traffic. - */ - icss_iep_init_fw(prueth->iep1); - } + /* Enable IEP1 for FW as it's needed by FW for FDB Learning and FDB ageing */ + icss_iep_init_fw(prueth->iep1); /* setup netdev interfaces */ if (eth0_node) { @@ -1365,8 +1361,7 @@ static int prueth_probe(struct platform_device *pdev) } exit_iep: - if (prueth->pdata.quirk_10m_link_issue) - icss_iep_exit_fw(prueth->iep1); + icss_iep_exit_fw(prueth->iep1); icss_iep_put(prueth->iep1); put_iep0: @@ -1423,8 +1418,7 @@ static void prueth_remove(struct platform_device *pdev) prueth_netdev_exit(prueth, eth_node); } - if (prueth->pdata.quirk_10m_link_issue) - icss_iep_exit_fw(prueth->iep1); + icss_iep_exit_fw(prueth->iep1); icss_iep_put(prueth->iep1); icss_iep_put(prueth->iep0);