From patchwork Mon Aug 12 00:59:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sunil V L X-Patchwork-Id: 13759949 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C3C1C3DA4A for ; Mon, 12 Aug 2024 01:01:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cDiQZULOrmkIQ76w8p/0qXlEheAvD+F8k2bdCW40Dj8=; b=3DBkPRdSoAei0f9IY3oy2oKnwI 7xfNyhKW9kwtVItocdKsrAkHecvDaOpdIZkO77Z3Ko2HH8tQXxvuMCAQMftwgsqIe8/Fs97cwaFwz nktjpTcVfNZzlwl2xJ8F7HsJ18mSQhpLn3xQyB+AuK21Ny5ZPJyM1kYcDXCisJGZsu2xPvceI9BO+ AzAHuI/4bfHIiqKdOsWaVx/SDE4m2JTM1Gr250COWlQsL9UoBVZtuXiZyBtBlCahrlfx1brSyCw5+ GtqGKuRtfsFVS6+O8VJAn15BQmiF6VflA8sUN0+K6h7pJwzBluislqyK0+fVXSEkMYYGhMASJajcx liz4MnhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdJRR-0000000GagL-1KVl; Mon, 12 Aug 2024 01:01:45 +0000 Received: from mail-oi1-x232.google.com ([2607:f8b0:4864:20::232]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdJPf-0000000GZsy-0I2E for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2024 00:59:57 +0000 Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3dab336717fso2632236b6e.0 for ; Sun, 11 Aug 2024 17:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1723424394; x=1724029194; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cDiQZULOrmkIQ76w8p/0qXlEheAvD+F8k2bdCW40Dj8=; b=FO4zhSiEB0cd//oKILZUydXn1L11s25NgiVYcL9GLqu0tFQzVjODQ2W1k2cfS1vXrd gJDYydX33lrMLNhFzN/Ne/HClaY+h99tXmr1UyP/mBDtIyTUKjkQlbzcqNdeCVXnD/VL hSC1bNWYqxyiTXqlpNcxoJJ12dYhnJzBLOMMhm9580sdFkqOkMPxqZN0rFmgDZQAfRD1 TThZNwG1/hqCwyQa7oS/nj8JYrV6KOtVTUNqv8wCtOJkZbytDEQXrPUICjL1MKnhJxlT 45WzTYKNiXsNaJwkLe8EIEerBgzrMmqP4+HP+zyYCk+mY4prUuZ4WkSF7zwhqIxokRIJ EZag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723424394; x=1724029194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cDiQZULOrmkIQ76w8p/0qXlEheAvD+F8k2bdCW40Dj8=; b=WUmNOwOQi6zm75R9HKMGIPG9yucWglixzWVSgTfjjLnyqVFouy9ZWsXKgPWUGsEC7o jINXayKIbgncdDeNdOoCmGnQFdHqJS0OyYE4E4O1p9IewY3Ir3HhOZPsxQSilAp5lVlv soEkn7JgW18jhWJC2hg/WsmR6dBjGBd6jYH+3DbU3rrth1OibfXkZWjOBkv0DiT7Bfjg KJUD1iRnyed93OVrij+xtiVDCoCRewCtl+qHTC44fSYUkK0YfTeVnh9SJL0tKIA3u792 FTnj3jJaI+5zdpVzDzHT79IZeXohhDgBXVqTKBdwQpWNx2WVEeMEA3TsQmAFQJvwJ0Ac et5w== X-Forwarded-Encrypted: i=1; AJvYcCXInoRMV4XXEBRFOsp6GSxIs6k7kTPD3Tk+nsYpTqiaAJ2lrBIuMj1WQF5Xy8xEemVr/m3Z1PSpN3cdVFubJoKenC7GwUBqGva0kwP5G6ZOSvIApM0= X-Gm-Message-State: AOJu0YzZWncnsyn+wo1+bk2DikrFkQ504aQJxwNeVHyOVLrE4FsIlSaN Pge4eDq7Ysm51qKFFuPIUQzXwxGCYIXATEwuiK6+Yhl29ykHbsLpWDPaTxhQw8g= X-Google-Smtp-Source: AGHT+IFZ+1tDJ3142HVFsLE4ya3SPYZxnEcsV+61Xh8a+xb4OPG7zVmGoKf++d88AMIRm4sWlhcOOQ== X-Received: by 2002:a05:6808:2185:b0:3db:fe8:f744 with SMTP id 5614622812f47-3dc4168aac0mr9047447b6e.24.1723424393786; Sun, 11 Aug 2024 17:59:53 -0700 (PDT) Received: from sunil-pc.tail07344b.ts.net ([106.51.198.16]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7c3dbe8cbdcsm3074062a12.61.2024.08.11.17.59.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Aug 2024 17:59:53 -0700 (PDT) From: Sunil V L To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev Cc: Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Robert Moore , Conor Dooley , Haibo Xu , Andrew Jones , Atish Kumar Patra , Drew Fustini , Sunil V L , =?utf-8?b?QmrDtnJuIFTDtnBlbA==?= Subject: [PATCH v8 02/17] ACPI: scan: Add a weak arch_sort_irqchip_probe() to order the IRQCHIP probe Date: Mon, 12 Aug 2024 06:29:14 +0530 Message-ID: <20240812005929.113499-3-sunilvl@ventanamicro.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240812005929.113499-1-sunilvl@ventanamicro.com> References: <20240812005929.113499-1-sunilvl@ventanamicro.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240811_175955_118421_91E702DF X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Unlike OF framework, the irqchip probe using IRQCHIP_ACPI_DECLARE has no order defined. Depending on the Makefile is not a good idea. So, usually it is worked around by mandating only root interrupt controller probed using IRQCHIP_ACPI_DECLARE and other interrupt controllers are probed via cascade mechanism. However, this is also not a clean solution because if there are multiple root controllers (ex: RINTC in RISC-V which is per CPU) which need to be probed first, then the cascade will happen for every root controller. So, introduce an architecture specific weak function arch_sort_irqchip_probe() to order the probing of the interrupt controllers which can be implemented by different architectures as per their interrupt controller hierarchy. Signed-off-by: Sunil V L Tested-by: Björn Töpel --- drivers/acpi/scan.c | 3 +++ include/linux/acpi.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 59771412686b..52a9dfc8e18c 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -2755,6 +2755,8 @@ static int __init acpi_match_madt(union acpi_subtable_headers *header, return 0; } +void __weak arch_sort_irqchip_probe(struct acpi_probe_entry *ap_head, int nr) { } + int __init __acpi_probe_device_table(struct acpi_probe_entry *ap_head, int nr) { int count = 0; @@ -2763,6 +2765,7 @@ int __init __acpi_probe_device_table(struct acpi_probe_entry *ap_head, int nr) return 0; mutex_lock(&acpi_probe_mutex); + arch_sort_irqchip_probe(ap_head, nr); for (ape = ap_head; nr; ape++, nr--) { if (ACPI_COMPARE_NAMESEG(ACPI_SIG_MADT, ape->id)) { acpi_probe_count = 0; diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 0687a442fec7..3fff86f95c2f 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -1343,6 +1343,8 @@ struct acpi_probe_entry { kernel_ulong_t driver_data; }; +void arch_sort_irqchip_probe(struct acpi_probe_entry *ap_head, int nr); + #define ACPI_DECLARE_PROBE_ENTRY(table, name, table_id, subtable, \ valid, data, fn) \ static const struct acpi_probe_entry __acpi_probe_##name \