From patchwork Mon Aug 12 20:04:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 13760998 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94E18C52D7C for ; Mon, 12 Aug 2024 20:09:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NN9ohrWDzAKh5ND5oSSWFgfVnLGZgDo0j5pkupfMzYI=; b=C/rA1C77QOcFsfa3yx9TRf6d03 n0VVB8zCrkclpmEJcM24VeoTV9tfjtFtg7WB5DTvDrqLhUkjq+LJVTpEb/9WcgFye0CPP8AHAq1gm /BEZhu/AE6rI6Kx4y7hFc0W+dfUnDB59nSJZarOOUsV2d5AWQ1+DRdIpIsNds387XF6nVRxn/c+Nh oiRYS7rE2fv5bUyXZ0nqc7ntncJKS7s40e3V8XlmbiO5zbYvV4AjSLfy7SFuJlf11hciI6t7oZu0N KhS84znYJRG+tVRzYt0UJ1AUfaodyeDYig25rqbP5xMqCpkv8LD3iAKJaZmdt1RKI7AudY6KJnDa7 51CMdG/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdbMS-00000001Pz8-2NdF; Mon, 12 Aug 2024 20:09:48 +0000 Received: from out-179.mta0.migadu.com ([91.218.175.179]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdbHp-00000001OfT-3nO9 for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2024 20:05:04 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1723493099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NN9ohrWDzAKh5ND5oSSWFgfVnLGZgDo0j5pkupfMzYI=; b=fSR5TP+G+9NhbxgRPp1WjkDzeBcETQMBkXkUaIiEp0R2hoLUpJzv/znbINWUcT5pBZMyIZ 9ZlfjPIU8fVhxweLrdlVaQhB9hBRPSgXZYYu3V5QFQ94d1yb225JEOz7KAj0luo6Pdg5Wu 3lnG9fwbW5iuNz6FcRX9ITtCaNqf0fU= From: Sean Anderson To: Radhey Shyam Pandey , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Andrew Lunn , Michal Simek , Daniel Borkmann , Paolo Abeni , "David S . Miller" , Eric Dumazet , linux-arm-kernel@lists.infradead.org, Jakub Kicinski , Ariane Keller , Sean Anderson Subject: [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode Date: Mon, 12 Aug 2024 16:04:36 -0400 Message-Id: <20240812200437.3581990-4-sean.anderson@linux.dev> In-Reply-To: <20240812200437.3581990-1-sean.anderson@linux.dev> References: <20240812200437.3581990-1-sean.anderson@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_130502_534044_DF5CB269 X-CRM114-Status: GOOD ( 11.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org A message about being in promiscuous mode is printed every time each additional multicast address beyond four is added. Suppress this message like is done in other drivers. And don't set IFF_PROMISC in ndev->flags; contrary to the comment we don't have to inform the net subsystem. Signed-off-by: Sean Anderson --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 1bcabb016ca9..9bcad515f156 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -439,15 +439,9 @@ static void axienet_set_multicast_list(struct net_device *ndev) if (ndev->flags & (IFF_ALLMULTI | IFF_PROMISC) || netdev_mc_count(ndev) > XAE_MULTICAST_CAM_TABLE_NUM) { - /* We must make the kernel realize we had to move into - * promiscuous mode. If it was a promiscuous mode request - * the flag is already set. If not we set it. - */ - ndev->flags |= IFF_PROMISC; reg = axienet_ior(lp, XAE_FMI_OFFSET); reg |= XAE_FMI_PM_MASK; axienet_iow(lp, XAE_FMI_OFFSET, reg); - dev_info(&ndev->dev, "Promiscuous mode enabled.\n"); } else if (!netdev_mc_empty(ndev)) { struct netdev_hw_addr *ha; @@ -481,7 +475,6 @@ static void axienet_set_multicast_list(struct net_device *ndev) reg &= ~XAE_FMI_PM_MASK; axienet_iow(lp, XAE_FMI_OFFSET, reg); - dev_info(&ndev->dev, "Promiscuous mode disabled.\n"); } for (; i < XAE_MULTICAST_CAM_TABLE_NUM; i++) {