| Message ID | 20240819115956.3884847-1-ruanjinjie@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Mon, 19 Aug 2024 at 13:52, Jinjie Ruan <ruanjinjie@huawei.com> wrote: > > The sparse tool complains as follows: > > drivers/pmdomain/apple/pmgr-pwrstate.c:180:32: warning: > symbol 'apple_pmgr_reset_ops' was not declared. Should it be static: > > This symbol is not used outside of pmgr-pwrstate.c, so marks it static. > > Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> Applied for next, thanks! Kind regards Uffe > --- > drivers/pmdomain/apple/pmgr-pwrstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pmdomain/apple/pmgr-pwrstate.c b/drivers/pmdomain/apple/pmgr-pwrstate.c > index d62a776c89a1..9467235110f4 100644 > --- a/drivers/pmdomain/apple/pmgr-pwrstate.c > +++ b/drivers/pmdomain/apple/pmgr-pwrstate.c > @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned > return !!(reg & APPLE_PMGR_RESET); > } > > -const struct reset_control_ops apple_pmgr_reset_ops = { > +static const struct reset_control_ops apple_pmgr_reset_ops = { > .assert = apple_pmgr_reset_assert, > .deassert = apple_pmgr_reset_deassert, > .reset = apple_pmgr_reset_reset, > -- > 2.34.1 >
diff --git a/drivers/pmdomain/apple/pmgr-pwrstate.c b/drivers/pmdomain/apple/pmgr-pwrstate.c index d62a776c89a1..9467235110f4 100644 --- a/drivers/pmdomain/apple/pmgr-pwrstate.c +++ b/drivers/pmdomain/apple/pmgr-pwrstate.c @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned return !!(reg & APPLE_PMGR_RESET); } -const struct reset_control_ops apple_pmgr_reset_ops = { +static const struct reset_control_ops apple_pmgr_reset_ops = { .assert = apple_pmgr_reset_assert, .deassert = apple_pmgr_reset_deassert, .reset = apple_pmgr_reset_reset,
The sparse tool complains as follows: drivers/pmdomain/apple/pmgr-pwrstate.c:180:32: warning: symbol 'apple_pmgr_reset_ops' was not declared. Should it be static: This symbol is not used outside of pmgr-pwrstate.c, so marks it static. Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com> --- drivers/pmdomain/apple/pmgr-pwrstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)