From patchwork Tue Aug 20 14:27:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 13770190 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5F1CC531DC for ; Tue, 20 Aug 2024 14:29:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+CweAkAJr9mntclzvPa7UIasbvY59T5xkn8SIizEWjc=; b=kJ36QnfC/3V6mDmVI2l1VsPbcX s8OcZteks039UpzW3MbtuJxdG0lrbZ7nfKT+c5tXcyoAKwsstlD7BQO7zj35ZnzkY1AIaSzTmj1K2 n86k6WMPQrX7LhRwNBpKibUVtC2YkM6g9MNEM9feFzjO1FYY5zaYb7DXd9eobfm2RDH4r6qcwEaDo nqmdSVUtX0YpEczIZrljRWRPP7w5pnTIhh53lv46XMYeqebZ+0ONAiR6WNDgiEbgaD+VCqgxqgelw ZTSCFo244UB+ZZGGIaC9JJlVr8GOIRXEkAhUk2sRAUyMoyJjHT/WrnIv2lf2NXTlFiRprjjexZD6F qKyUU+bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgPrl-00000005YLt-1MNb; Tue, 20 Aug 2024 14:29:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgPqw-00000005Y6U-0Yq8 for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 14:28:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EEE05FEC; Tue, 20 Aug 2024 07:29:17 -0700 (PDT) Received: from [127.0.1.1] (e107155-lin.cambridge.arm.com [10.1.198.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EC8B3F66E; Tue, 20 Aug 2024 07:28:51 -0700 (PDT) From: Sudeep Holla Date: Tue, 20 Aug 2024 15:27:54 +0100 Subject: [PATCH v2 1/7] firmware: arm_ffa: Some coding style fixes MIME-Version: 1.0 Message-Id: <20240820-ffa_v1-2-v2-1-18c0c5f3c65e@arm.com> References: <20240820-ffa_v1-2-v2-0-18c0c5f3c65e@arm.com> In-Reply-To: <20240820-ffa_v1-2-v2-0-18c0c5f3c65e@arm.com> To: linux-arm-kernel@lists.infradead.org, Sudeep Holla , op-tee@lists.trustedfirmware.org X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1607; i=sudeep.holla@arm.com; h=from:subject:message-id; bh=cZTAsRfmNjba/xBvkOD3FhtdQGmyLXIFXmSg73yxnqU=; b=owEBbQKS/ZANAwAIAQBBurwxfuKYAcsmYgBmxKghfslqVbS3kpxcU8jGknE9v79VrdVKhIdQg AaQtuN8sdKJAjMEAAEIAB0WIQS6ceUSBvMeskPdk+EAQbq8MX7imAUCZsSoIQAKCRAAQbq8MX7i mKQCD/4xcg/hAFX/CTVLWxF3eFazSgvLQy5E/womndHJ0w7vCAgUglGZ6FWIrcENPXISNFK8IkV ApXyx/zW9fkcgVPi0l7cp3CugVe/266JNuH/SjuS6MMUNUdWez0L4LMxpLxVVvHYxeHwID5PEva V3aiP43XQees69RsBa/MaNsqMIvosd7LreI7e/kibPuUY+Gp1mIUfwTk4EglGkCP3j3Nd9UMMF+ lQPlGP5iR7afSw1q7NbkATzSh8VLFKFgHlbSGnR1RN0yJlcj4+Ld6u3rEI3lR71hu+aqdL8aw5q VZSbi/+TXsRAn2xYs7VHsi/4admtETVmsypSKVBLFO3iFfSlB67r0Kv6Buf20Q20+tB19ueT8Su PnabFce1xm+LcQCD3eyrK5Fzm+p/fRqdZWjvwCb2pd4a9hRlXpokcCeLWHrRIupRQqWW8UFfR/A swLu0H2GjkA4mLeMi7M8jXAm3zU3MWnSjVzwAb78Fouh53vN/MW+xxC8VWwstWkLkwQEaRRZr9i n5pArCmEVHZg6+yvLb5ie1EZWbQ4hshjtdk2HeS1r389kXFeV1B3NWCskzOgf8TVbaJS7+2ZY8n 9xZYOo6x1dZazsylAIhmlMqWfbNq5k9PLp/5PFw7DllvZAIeDljYDhYi0yov8hgTV6dZ2zg++vB Bu6+aKL/1VvJcJg== X-Developer-Key: i=sudeep.holla@arm.com; a=openpgp; fpr=7360A21742ADF5A11767C1C139CFD4755FE2D5B4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_072854_286349_A444286E X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org These changes fixes a set of below coding style issues: 1. spaces required around that '=' (ctx:VxW) 2. possible unnecessary 'out of memory' message 3. unnecessary for single statement blocks Signed-off-by: Sudeep Holla --- drivers/firmware/arm_ffa/driver.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 7ba98c7af2e9..b4b3ecc9824e 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -1242,7 +1242,7 @@ ffa_bus_notifier(struct notifier_block *nb, unsigned long action, void *data) if (action == BUS_NOTIFY_BIND_DRIVER) { struct ffa_driver *ffa_drv = to_ffa_driver(dev->driver); - const struct ffa_device_id *id_table= ffa_drv->id_table; + const struct ffa_device_id *id_table = ffa_drv->id_table; /* * FF-A v1.1 provides UUID for each partition as part of the @@ -1327,8 +1327,6 @@ static int ffa_setup_partitions(void) /* Allocate for the host */ info = kzalloc(sizeof(*info), GFP_KERNEL); if (!info) { - pr_err("%s: failed to alloc Host partition ID 0x%x. Abort.\n", - __func__, drv_info->vm_id); /* Already registered devices are freed on bus_exit */ ffa_partitions_cleanup(); return -ENOMEM; @@ -1609,9 +1607,8 @@ static int __init ffa_init(void) return ret; drv_info = kzalloc(sizeof(*drv_info), GFP_KERNEL); - if (!drv_info) { + if (!drv_info) return -ENOMEM; - } ret = ffa_version_check(&drv_info->version); if (ret)