diff mbox series

ARM: dts: imx28-apx4devkit: Fix the regulator description

Message ID 20240820002435.1411201-1-festevam@gmail.com (mailing list archive)
State New, archived
Headers show
Series ARM: dts: imx28-apx4devkit: Fix the regulator description | expand

Commit Message

Fabio Estevam Aug. 20, 2024, 12:24 a.m. UTC 
From: Fabio Estevam <festevam@denx.de>

The regulator should not be placed under simple-bus.

Remove it from simple-bus to fix the following dt-schema warnings:

'regulators' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
regulators: #size-cells:0:0: 0 is not one of [1, 2]
regulators: regulator@0:reg:0: [0] is too short
regulators: 'ranges' is a required property

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 .../arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)

Comments

Shawn Guo Aug. 31, 2024, 2:01 p.m. UTC | #1 
On Mon, Aug 19, 2024 at 09:24:35PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The regulator should not be placed under simple-bus.
> 
> Remove it from simple-bus to fix the following dt-schema warnings:
> 
> 'regulators' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
> regulators: #size-cells:0:0: 0 is not one of [1, 2]
> regulators: regulator@0:reg:0: [0] is too short
> regulators: 'ranges' is a required property
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts b/arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts
index f9bf40d96568..4c4ea91c286f 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts
+++ b/arch/arm/boot/dts/nxp/mxs/imx28-apx4devkit.dts
@@ -11,19 +11,13 @@  memory@40000000 {
 		reg = <0x40000000 0x04000000>;
 	};
 
-	regulators {
-		compatible = "simple-bus";
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		reg_3p3v: regulator@0 {
-			compatible = "regulator-fixed";
-			reg = <0>;
-			regulator-name = "3P3V";
-			regulator-min-microvolt = <3300000>;
-			regulator-max-microvolt = <3300000>;
-			regulator-always-on;
-		};
+
+	reg_3p3v: regulator-3p3v {
+		compatible = "regulator-fixed";
+		regulator-name = "3P3V";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
 	};
 
 	sound {