diff mbox series

[v4,3/4] arm64: dts: k3-am62a-wakeup: Add R5F device node

Message ID 20240820104034.15607-4-hnagalla@ti.com (mailing list archive)
State New, archived
Headers show
Series Add R5F and C7x DSP nodes for AM62a SoC | expand

Commit Message

Hari Nagalla Aug. 20, 2024, 10:40 a.m. UTC 
From: Devarsh Thakkar <devarsht@ti.com>

AM62A SoCs have a single R5F core in waekup domain. This core is also
used as a device manager for the SoC.

Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++++++++++
 1 file changed, 23 insertions(+)

Comments

Andrew Davis Aug. 20, 2024, 3:13 p.m. UTC | #1 
On 8/20/24 5:40 AM, Hari Nagalla wrote:
> From: Devarsh Thakkar <devarsht@ti.com>
> 
> AM62A SoCs have a single R5F core in waekup domain. This core is also
> used as a device manager for the SoC.
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> index f5ac101a04df..c4319986e660 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> @@ -76,6 +76,29 @@ wkup_rti0: watchdog@2b000000 {
>   		status = "reserved";
>   	};
>   
> +	wkup_r5fss0: r5fss@78000000 {
> +		compatible = "ti,am62-r5fss";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0x78000000 0x00 0x78000000 0x8000>,
> +			 <0x78100000 0x00 0x78100000 0x8000>;
> +		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;

Need newline here.

> +		wkup_r5fss0_core0: r5f@78000000 {
> +			compatible = "ti,am62-r5f";
> +			reg = <0x78000000 0x00008000>,
> +				<0x78100000 0x00008000>;
> +			reg-names = "atcm", "btcm";
> +			ti,sci = <&dmsc>;
> +			ti,sci-dev-id = <121>;
> +			ti,sci-proc-ids = <0x01 0xff>;
> +			resets = <&k3_reset 121 1>;
> +			firmware-name = "am62-wkup-r5f0_0-fw";

resets and firmware-name should go before vendor specific properties.

Andrew

> +			ti,atcm-enable = <1>;
> +			ti,btcm-enable = <1>;
> +			ti,loczrama = <1>;
> +		};
> +	};
> +
>   	wkup_vtm0: temperature-sensor@b00000 {
>   		compatible = "ti,j7200-vtm";
>   		reg = <0x00 0xb00000 0x00 0x400>,
Nishanth Menon Aug. 21, 2024, 11:10 a.m. UTC | #2 
On 10:13-20240820, Andrew Davis wrote:
> On 8/20/24 5:40 AM, Hari Nagalla wrote:
> > From: Devarsh Thakkar <devarsht@ti.com>
> > 
> > AM62A SoCs have a single R5F core in waekup domain. This core is also
> > used as a device manager for the SoC.
> > 
> > Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> > Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> > ---
> >   arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++++++++++
> >   1 file changed, 23 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> > index f5ac101a04df..c4319986e660 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> > @@ -76,6 +76,29 @@ wkup_rti0: watchdog@2b000000 {
> >   		status = "reserved";
> >   	};
> > +	wkup_r5fss0: r5fss@78000000 {
> > +		compatible = "ti,am62-r5fss";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x78000000 0x00 0x78000000 0x8000>,
> > +			 <0x78100000 0x00 0x78100000 0x8000>;
> > +		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> 
> Need newline here.
> 
> > +		wkup_r5fss0_core0: r5f@78000000 {
> > +			compatible = "ti,am62-r5f";
> > +			reg = <0x78000000 0x00008000>,
> > +				<0x78100000 0x00008000>;
> > +			reg-names = "atcm", "btcm";
> > +			ti,sci = <&dmsc>;
> > +			ti,sci-dev-id = <121>;
> > +			ti,sci-proc-ids = <0x01 0xff>;
> > +			resets = <&k3_reset 121 1>;
> > +			firmware-name = "am62-wkup-r5f0_0-fw";
> 
> resets and firmware-name should go before vendor specific properties.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117

> 
> > +			ti,atcm-enable = <1>;
> > +			ti,btcm-enable = <1>;
> > +			ti,loczrama = <1>;
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
index f5ac101a04df..c4319986e660 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
@@ -76,6 +76,29 @@  wkup_rti0: watchdog@2b000000 {
 		status = "reserved";
 	};
 
+	wkup_r5fss0: r5fss@78000000 {
+		compatible = "ti,am62-r5fss";
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges = <0x78000000 0x00 0x78000000 0x8000>,
+			 <0x78100000 0x00 0x78100000 0x8000>;
+		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
+		wkup_r5fss0_core0: r5f@78000000 {
+			compatible = "ti,am62-r5f";
+			reg = <0x78000000 0x00008000>,
+				<0x78100000 0x00008000>;
+			reg-names = "atcm", "btcm";
+			ti,sci = <&dmsc>;
+			ti,sci-dev-id = <121>;
+			ti,sci-proc-ids = <0x01 0xff>;
+			resets = <&k3_reset 121 1>;
+			firmware-name = "am62-wkup-r5f0_0-fw";
+			ti,atcm-enable = <1>;
+			ti,btcm-enable = <1>;
+			ti,loczrama = <1>;
+		};
+	};
+
 	wkup_vtm0: temperature-sensor@b00000 {
 		compatible = "ti,j7200-vtm";
 		reg = <0x00 0xb00000 0x00 0x400>,