| Message ID | 20240820123426.48694-1-rongqianfeng@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | memory: mtk-smi: Simplify using devm_clk_get_enabled() | expand |
On 20/08/2024 14:34, Rong Qianfeng wrote: > devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable() > and the clock will automatically be disabled, unprepared and freed when > the device is unbound from the bus. That's obvious, drop. You do not have to explain basic APIs. Instead say what is being simplified here. > So simplify mtk_smi_common_probe() > accordingly. Also explain that you fix bug of missing unprepare in unbind and add Fixes+CC stable tags. Best regards, Krzysztof
在 2024/8/20 20:40, Krzysztof Kozlowski 写道: > [Some people who received this message don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > On 20/08/2024 14:34, Rong Qianfeng wrote: >> devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable() >> and the clock will automatically be disabled, unprepared and freed when >> the device is unbound from the bus. > That's obvious, drop. You do not have to explain basic APIs. Instead say > what is being simplified here. > >> So simplify mtk_smi_common_probe() >> accordingly. > Also explain that you fix bug of missing unprepare in unbind and add > Fixes+CC stable tags. OK, thanks for the reminder. Best regards, Qianfeng > > Best regards, > Krzysztof >
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index fbe52ecc0eca..2bc034dff691 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -771,13 +771,9 @@ static int mtk_smi_common_probe(struct platform_device *pdev) if (IS_ERR(common->smi_ao_base)) return PTR_ERR(common->smi_ao_base); - common->clk_async = devm_clk_get(dev, "async"); + common->clk_async = devm_clk_get_enabled(dev, "async"); if (IS_ERR(common->clk_async)) return PTR_ERR(common->clk_async); - - ret = clk_prepare_enable(common->clk_async); - if (ret) - return ret; } else { common->base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(common->base))
devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable() and the clock will automatically be disabled, unprepared and freed when the device is unbound from the bus. So simplify mtk_smi_common_probe() accordingly. Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com> --- drivers/memory/mtk-smi.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)