| Message ID | 20240821142006.645306-1-ada@thorsis.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] mtd: nand: raw: atmel: Add message on DMA usage | expand |
On 21/08/2024 at 16:20, Alexander Dahl wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Like for other atmel drivers (serial, crypto, mmc, …), too. > > Signed-off-by: Alexander Dahl <ada@thorsis.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > > Notes: > v1 -> v2: > - make info message conditional (thanks Miquel) > > drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index dc75d50d52e8..f9ccfd02e804 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -2049,7 +2049,10 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > dma_cap_set(DMA_MEMCPY, mask); > > nc->dmac = dma_request_channel(mask, NULL, NULL); > - if (!nc->dmac) > + if (nc->dmac) > + dev_info(nc->dev, "using %s for DMA transfers\n", > + dma_chan_name(nc->dmac)); > + else > dev_err(nc->dev, "Failed to request DMA channel\n"); > } > > > base-commit: 47ac09b91befbb6a235ab620c32af719f8208399 > -- > 2.39.2 >
Hi Alexander, ada@thorsis.com wrote on Wed, 21 Aug 2024 16:20:05 +0200: > Like for other atmel drivers (serial, crypto, mmc, …), too. I was about to take the patch but I figured out the prefix was wrong, please change it to "mtd: rawnand: atmel:" (and don't forget to collect Nicola's tag). > > Signed-off-by: Alexander Dahl <ada@thorsis.com> > --- Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c index dc75d50d52e8..f9ccfd02e804 100644 --- a/drivers/mtd/nand/raw/atmel/nand-controller.c +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c @@ -2049,7 +2049,10 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, dma_cap_set(DMA_MEMCPY, mask); nc->dmac = dma_request_channel(mask, NULL, NULL); - if (!nc->dmac) + if (nc->dmac) + dev_info(nc->dev, "using %s for DMA transfers\n", + dma_chan_name(nc->dmac)); + else dev_err(nc->dev, "Failed to request DMA channel\n"); }
Like for other atmel drivers (serial, crypto, mmc, …), too. Signed-off-by: Alexander Dahl <ada@thorsis.com> --- Notes: v1 -> v2: - make info message conditional (thanks Miquel) drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) base-commit: 47ac09b91befbb6a235ab620c32af719f8208399