From patchwork Thu Aug 22 07:20:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen-Yu Tsai X-Patchwork-Id: 13772882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 658B9C531DF for ; Thu, 22 Aug 2024 07:29:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0OkXJystyHFO3QqFrhx1xRYATCv0SLvRjJj6gA62TPk=; b=EyXG8VnfeOycKvekIxXKurEsKb hrlmEvdAnPvqgXRjPQz5WcvvKGwgTDCeorl7FrOAXXFt++gNcUkJjm3GReqpYLXjfUY5xveF4n7UG +EQE16wzQQsge0w0SlmoI3DhRMAFLAHdDOXpbPTAy1udQ8TpKygsQ+FXHWz53svp0QqGotVuFbqKy MWSPGbpEh2NDhlogPq7h6SiWn3KfVJf1E511k3Ega6xiL8IEyr6fHCV9mdbkcAs/Zd+ZFDnZNkfVv JvCQr/qrdEWuCHkdXAEiIs79IfdJUiEoISgSYIGi+DD76UIA2E525pSC4vSJOSZ4V3KVN4wHEqblJ jvOl2WNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh2Ft-0000000BsHU-2f72; Thu, 22 Aug 2024 07:29:13 +0000 Received: from mail-oa1-x36.google.com ([2001:4860:4864:20::36]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sh284-0000000BpzP-1X7E for linux-arm-kernel@lists.infradead.org; Thu, 22 Aug 2024 07:21:11 +0000 Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-27010ae9815so307975fac.2 for ; Thu, 22 Aug 2024 00:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724311266; x=1724916066; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0OkXJystyHFO3QqFrhx1xRYATCv0SLvRjJj6gA62TPk=; b=KCQr6Y0zpzC/RmKm2AazAMvs/vpIlWzTfT7QOQHy+LVtQMqtODRFWswOzQROpw3rpW yfySR7ClT975rC1qN49a5SrKfVO9Bz6aL6XO/WGaQ3woLQsvQHuFBmXDfb2CxBdNsrF6 3IqjpWXgTtR7N1Fdy7v37JGsDSyO30b9SCo1s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724311266; x=1724916066; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0OkXJystyHFO3QqFrhx1xRYATCv0SLvRjJj6gA62TPk=; b=VoNQBGYxTeitE27P/+JSaPLHDhDTGzA+vMlEe2QVzB5rx1uvm2O7Tp58t3vSh0rg0l s4uDCKmywiOQJKQ6s21TS2Dt9XTqSJLhl7BxAs29l5pTDXiYeyb4OptZOEZDQGnE3oMv w1x8mCVGk/fXfH0CcP/v4td6kQuFdfkzwWxnT09Hnt1GFauHPMvhNFgZBHq/I574Y493 HxjAciYyxk9qTd9AFz/bDRvpvFhnFkEuj/BRcMQ5JZlSk1tL5gdBPBdzEXc+N+hr7Zc+ Gm8jLc1yEyghjO9KHbFnUvSDwFlQRYzGK06+LHyfbliiguzyi8wVGKYb1jIfM7aOVCXm eopg== X-Forwarded-Encrypted: i=1; AJvYcCXk6gxvipwEytndpbCGiRY+Jxf/JQ95MolKhAB5YF/Y2CR2omnIk49Xq3clUA2Sp6EyKK9gdtdFolIkN96RqqZ8@lists.infradead.org X-Gm-Message-State: AOJu0YzXyKf6vmdkJzzFDa29c6XtDFKMaOhXqR8D88AGx9EUaMQD0aHD NTxmP1JxucJDLI1uWl8M5XddaThzIWUnEyGhyegnyJvaJJDREcPe4gtX70A3zg== X-Google-Smtp-Source: AGHT+IFzUCqhCkTr+YqoZpsRxb513kbI0DI/K30PqGR1wgWwO2DPHl2WC1ed/qu4VuxElP0+ie671w== X-Received: by 2002:a05:6871:1c6:b0:25e:7a1:ea8f with SMTP id 586e51a60fabf-273cff9bceamr1248838fac.47.1724311266536; Thu, 22 Aug 2024 00:21:06 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:8470:6a67:8877:ce2c]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7cd9ad6e8e9sm615901a12.86.2024.08.22.00.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Aug 2024 00:21:06 -0700 (PDT) From: Chen-Yu Tsai To: Mark Brown , Liam Girdwood Cc: Chen-Yu Tsai , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/3] regulator: Clarify error message for "id == NULL" in _regulator_get() Date: Thu, 22 Aug 2024 15:20:44 +0800 Message-ID: <20240822072047.3097740-2-wenst@chromium.org> X-Mailer: git-send-email 2.46.0.184.g6999bdac58-goog In-Reply-To: <20240822072047.3097740-1-wenst@chromium.org> References: <20240822072047.3097740-1-wenst@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240822_002108_615597_809FE443 X-CRM114-Status: GOOD ( 15.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The original error message simply said "get() with no identifier" without any context as to what was requested or what device the request was related to. The only thing the user or developer could do was grep for the message in the full source tree. Amend the error message to be more specific, and also use dev_* to associate the error message with a device. Signed-off-by: Chen-Yu Tsai --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 7674b7f2df14..9029de5395ee 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2183,7 +2183,7 @@ struct regulator *_regulator_get(struct device *dev, const char *id, } if (id == NULL) { - pr_err("get() with no identifier\n"); + dev_err(dev, "regulator request with no identifier\n"); return ERR_PTR(-EINVAL); }