| Message ID | 20240823-to_sent2-v1-6-8bc182a0adaf@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: vchiq_core: Refactor vchiq_bulk_transfer() logic | expand |
Am 23.08.24 um 17:14 schrieb Umang Jain: > The argument 'is_blocking' in queue_message_sync() is not > used in the function. Drop it. > > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Good catch! Reviewed-by: Stefan Wahren <wahrenst@gmx.net> > --- > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > index 43c6a214be86..84631878f77d 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > @@ -1146,7 +1146,7 @@ queue_message_sync(struct vchiq_state *state, struct vchiq_service *service, > int msgid, > ssize_t (*copy_callback)(void *context, void *dest, > size_t offset, size_t maxsize), > - void *context, int size, int is_blocking) > + void *context, int size) > { > struct vchiq_shared_state *local; > struct vchiq_header *header; > @@ -1524,7 +1524,7 @@ parse_open(struct vchiq_state *state, struct vchiq_header *header) > /* Acknowledge the OPEN */ > if (service->sync) { > if (queue_message_sync(state, NULL, openack_id, memcpy_copy_callback, > - &ack_payload, sizeof(ack_payload), 0) == -EAGAIN) > + &ack_payload, sizeof(ack_payload)) == -EAGAIN) > goto bail_not_ready; > > /* The service is now open */ > @@ -3150,7 +3150,7 @@ vchiq_queue_message(struct vchiq_instance *instance, unsigned int handle, > break; > case VCHIQ_SRVSTATE_OPENSYNC: > status = queue_message_sync(service->state, service, data_id, > - copy_callback, context, size, 1); > + copy_callback, context, size); > break; > default: > status = -EINVAL; >
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 43c6a214be86..84631878f77d 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -1146,7 +1146,7 @@ queue_message_sync(struct vchiq_state *state, struct vchiq_service *service, int msgid, ssize_t (*copy_callback)(void *context, void *dest, size_t offset, size_t maxsize), - void *context, int size, int is_blocking) + void *context, int size) { struct vchiq_shared_state *local; struct vchiq_header *header; @@ -1524,7 +1524,7 @@ parse_open(struct vchiq_state *state, struct vchiq_header *header) /* Acknowledge the OPEN */ if (service->sync) { if (queue_message_sync(state, NULL, openack_id, memcpy_copy_callback, - &ack_payload, sizeof(ack_payload), 0) == -EAGAIN) + &ack_payload, sizeof(ack_payload)) == -EAGAIN) goto bail_not_ready; /* The service is now open */ @@ -3150,7 +3150,7 @@ vchiq_queue_message(struct vchiq_instance *instance, unsigned int handle, break; case VCHIQ_SRVSTATE_OPENSYNC: status = queue_message_sync(service->state, service, data_id, - copy_callback, context, size, 1); + copy_callback, context, size); break; default: status = -EINVAL;
The argument 'is_blocking' in queue_message_sync() is not used in the function. Drop it. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)