From patchwork Sun Aug 25 14:34:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 13776799 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89786C5320E for ; Sun, 25 Aug 2024 14:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=KJCtcmIB3UdIrkYLcVzOIpEPiO2wmd+dCBPvqHnV2K4=; b=DKrWZNauJj0YCsd14Yy9PmLaJm kc9BHkoBVxE1VAibtbOU0Q7H75cmcabbjNxCCAHIMfoWm42QnZzV0uAW7Y9i684bU0Xsdjo4dOplQ DtkOnNKzSgWn3aSUOP0uYf4dq1WhK2IWmf0bgu2DL3clcp165nuf0ya2I7cFdxvcW7bzCNspabnXM dhBzEmPxKLxOKtcMS0sg61omT4PKQ729fJ2FQUk1on0yqMt84yFOJPrUxSbSoX2NmWW2qhDA1sipy Kk/SuTRh+5EYQXIIeKJsH91ozRatkX5sCWGHGXnXmhH5fa4wryN0ePAkKjeYqUJRkcW3UnhyWTv3p UO+aj0gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1siELi-00000004Vdm-2y6u; Sun, 25 Aug 2024 14:36:10 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siEKE-00000004VHi-443I for linux-arm-kernel@bombadil.infradead.org; Sun, 25 Aug 2024 14:34:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=KJCtcmIB3UdIrkYLcVzOIpEPiO2wmd+dCBPvqHnV2K4=; b=B41CZItN8fbFQq3U8PMRypJ7Bv DQc93sJm1KXFB4FEkF/OVF2nJaEsyyLTtYhJlebIYdA2oUjggxXIC261qXViZ3Hzdfbzh9kosEdMQ E/P0IEJrfXdWG1wSwGZJoG2yyEuiERUip8lBu/qT9Nk+5066FdEkqosvAy861WnBfp/k83yhFuPxA Hrt2tDG6p0HV4+Uf5xuwxPr4i+1Um722495qd15hPWd7zna2pJUw2u8NHtouoHZDJyGve+zrFmX7i oqxuh9730lhwdvbDzkKY80i6qzS+3RV/9VzBC9kvTdebNx3bYroS+sdSImGungwGB5PfV5PFt4PDF 3qgPAo2g==; Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1siEKB-0000000ASHe-21Xv for linux-arm-kernel@lists.infradead.org; Sun, 25 Aug 2024 14:34:37 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a868b739cd9so421908466b.2 for ; Sun, 25 Aug 2024 07:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1724596471; x=1725201271; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KJCtcmIB3UdIrkYLcVzOIpEPiO2wmd+dCBPvqHnV2K4=; b=OOUbAiuEx0kAWG2Nzy6T6G4f040/lKfo792F9YMhMqF7hp9xbgLgWIXWCwvfQO1LZm xovUKHgpLDJHEjiPVJu4ADJZ5+pOrZlwDc/vai3Nl29waPB/Z6UN+au/AUla9nQjk9fs PI87R5syrc2DK7W6ITAMrrX2B3uejTy1TqyzQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724596471; x=1725201271; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KJCtcmIB3UdIrkYLcVzOIpEPiO2wmd+dCBPvqHnV2K4=; b=lsmSyGK87yD4yt7ym8w1QkhmtC1TB1/my2BIVBwdw+L0QH5F0a5v6Q0UQJnYRu5LU0 OwdkAl2K1/sE47PYb6af9qh8aBiss6XCvYnKHAruJrNVfr3zQGvlKqlTSKNXcu117d8I ug4TbBaUIGghTaCdVPbHCh8HrwWFs7osGgqNcLBcEtz85i8YldMyzgQuQ8E+9QOqCeGB l5WoINEGq78pc+wooQkAKaqHViuJRnciEwtVpJNY8bq0O5YG3P4tNe0yjqPrcf3EwBZ4 9OagtkedzzR6Eemc9x8jS0aHoUuA49V5pRv9nWDI5VLo8/DV2j3OdwURKnc3/Wchw8qp 5qrg== X-Forwarded-Encrypted: i=1; AJvYcCV03bbxcxzo55uuKwDcECDmBN/7RMhz6pbQsMQmlMjcjKWcMMVd0aaWnDekSJYXOZydtmx0LJ5DIVuQhPcmHupT@lists.infradead.org X-Gm-Message-State: AOJu0Yyb+BezGBqeyIyaAxN1uYl9FOTBxTI/IBcgxOkx/8RPqybAH5rW MyBU1TlTHp5nPgzoqCOwKUwlnjhbWSww99ulF3M8S5rYC7e7ToLgZWo27/3SUK4= X-Google-Smtp-Source: AGHT+IFrPkCDWSQxHr3mcynt8lDSRSWlq9K1FdNFRP5DdDzP7xtG+zdnJc3gqlxqDwJcYjVr7uYgTg== X-Received: by 2002:a17:907:7f12:b0:a86:8524:2558 with SMTP id a640c23a62f3a-a86a518a3a6mr468976166b.12.1724596471075; Sun, 25 Aug 2024 07:34:31 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-25-99-149.retail.telecomitalia.it. [79.25.99.149]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f4862b6sm550625566b.170.2024.08.25.07.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 07:34:30 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, Dario Binacchi , Arnd Bergmann , Fabio Estevam , Linus Walleij , Peng Fan , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Ulf Hansson , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH v2 1/3] pmdomain: imx93-pd: replace dev_err() with dev_err_probe() Date: Sun, 25 Aug 2024 16:34:00 +0200 Message-ID: <20240825143428.556439-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240825_153435_766838_6ACB0DE6 X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This way, the code becomes more compact, and dev_err_probe() is used in every error path of the probe() function. Signed-off-by: Dario Binacchi Acked-by: Uwe Kleine-König --- Changes in v2: - Drop the extra { } to be even more compact. drivers/pmdomain/imx/imx93-pd.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pmdomain/imx/imx93-pd.c b/drivers/pmdomain/imx/imx93-pd.c index d750a7dc58d2..44daecbe5cc3 100644 --- a/drivers/pmdomain/imx/imx93-pd.c +++ b/drivers/pmdomain/imx/imx93-pd.c @@ -125,11 +125,10 @@ static int imx93_pd_probe(struct platform_device *pdev) /* Just to sync the status of hardware */ if (!domain->init_off) { ret = clk_bulk_prepare_enable(domain->num_clks, domain->clks); - if (ret) { - dev_err(domain->dev, "failed to enable clocks for domain: %s\n", - domain->genpd.name); - return ret; - } + if (ret) + return dev_err_probe(domain->dev, ret, + "failed to enable clocks for domain: %s\n", + domain->genpd.name); } ret = pm_genpd_init(&domain->genpd, NULL, domain->init_off);