| Message ID | 20240826151250.3500302-1-huangxiaojia2@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] arm64: Constify struct kobj_type | expand |
On Mon, 26 Aug 2024 23:12:50 +0800, Huang Xiaojia wrote: > 'struct kobj_type' is not modified. It is only used in kobject_init() > which takes a 'const struct kobj_type *ktype' parameter. > > Constifying this structure moves some data to a read-only section, > so increase over all security. > > On a x86_64, compiled with arm defconfig: > Before: > ====== > text data bss dec hex filename > 5602 548 352 6502 1966 arch/arm64/kernel/cpuinfo.o > > [...] Applied to arm64 (for-next/misc), thanks! [1/1] arm64: Constify struct kobj_type https://git.kernel.org/arm64/c/684fbd42d323 Cheers,
diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c index 09eeaa24d456..369dd72a8b22 100644 --- a/arch/arm64/kernel/cpuinfo.c +++ b/arch/arm64/kernel/cpuinfo.c @@ -280,7 +280,7 @@ const struct seq_operations cpuinfo_op = { }; -static struct kobj_type cpuregs_kobj_type = { +static const struct kobj_type cpuregs_kobj_type = { .sysfs_ops = &kobj_sysfs_ops, };
'struct kobj_type' is not modified. It is only used in kobject_init() which takes a 'const struct kobj_type *ktype' parameter. Constifying this structure moves some data to a read-only section, so increase over all security. On a x86_64, compiled with arm defconfig: Before: ====== text data bss dec hex filename 5602 548 352 6502 1966 arch/arm64/kernel/cpuinfo.o After: ====== text data bss dec hex filename 5650 500 352 6502 1966 arch/arm64/kernel/cpuinfo.o Signed-off-by: Huang Xiaojia <huangxiaojia2@huawei.com> --- arch/arm64/kernel/cpuinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)