| Message ID | 20240828-dts-v13-2-6bff9896d649@wesion.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Wi-Fi support for Khadas Edge2 and fallback compatible for Apple | expand |
On 28/08/2024 10:45, Jacobe Zang wrote: > Wi-Fi compatible in these DTS is based on PCI ID. Bindings need > "brcm,bcm4329-fmac" as fallback compatible. > > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> > --- > arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- > arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- > arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > Bindings are being questioned, so link to them in changelog section would help the maintainers to decide when to apply it. I am not convinced this is correct bindings change, thus this DTS should wait. Your previous patch also misses link to bindings. Whenever you split DTS to separate series, please always provide link to the bindings, so people will have the context. Best regards, Krzysztof
On 2024/8/28 21:02, Krzysztof Kozlowski wrote: > On 28/08/2024 10:45, Jacobe Zang wrote: >> Wi-Fi compatible in these DTS is based on PCI ID. Bindings need >> "brcm,bcm4329-fmac" as fallback compatible. >> >> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> >> --- >> arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- >> arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- >> arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> > > Bindings are being questioned, so link to them in changelog section > would help the maintainers to decide when to apply it. > > I am not convinced this is correct bindings change, thus this DTS should > wait. > > Your previous patch also misses link to bindings. Whenever you split DTS > to separate series, please always provide link to the bindings, so > people will have the context. > Sure. I will post the link in changelog next time.
diff --git a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi index 5988a4eb6efaa..4b021626d4692 100644 --- a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi +++ b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi @@ -72,7 +72,7 @@ hpm1: usb-pd@3f { &port00 { bus-range = <1 1>; wifi0: network@0,0 { - compatible = "pci14e4,4425"; + compatible = "pci14e4,4425", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 00 00 00 00 00]; diff --git a/arch/arm64/boot/dts/apple/t8112-j413.dts b/arch/arm64/boot/dts/apple/t8112-j413.dts index 6f69658623bf8..df2a63d8dd5e9 100644 --- a/arch/arm64/boot/dts/apple/t8112-j413.dts +++ b/arch/arm64/boot/dts/apple/t8112-j413.dts @@ -43,7 +43,7 @@ led-0 { &port00 { bus-range = <1 1>; wifi0: wifi@0,0 { - compatible = "pci14e4,4433"; + compatible = "pci14e4,4433", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 10 18 00 00 10]; diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts index 0ad908349f554..5f3453e109b85 100644 --- a/arch/arm64/boot/dts/apple/t8112-j493.dts +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts @@ -43,7 +43,7 @@ led-0 { &port00 { bus-range = <1 1>; wifi0: wifi@0,0 { - compatible = "pci14e4,4425"; + compatible = "pci14e4,4425", "brcm,bcm4329-fmac"; reg = <0x10000 0x0 0x0 0x0 0x0>; /* To be filled by the loader */ local-mac-address = [00 00 00 00 00 00];
Wi-Fi compatible in these DTS is based on PCI ID. Bindings need "brcm,bcm4329-fmac" as fallback compatible. Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> --- arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 2 +- arch/arm64/boot/dts/apple/t8112-j413.dts | 2 +- arch/arm64/boot/dts/apple/t8112-j493.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)