| Message ID | 20240829-sama7d65-next-v1-1-53d4e50b550d@microchip.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: clock: Add SAMA7D65 PMC compatible string | expand |
On 29/08/2024 15:08:45+0530, Dharma Balasubiramani wrote: > Add the `microchip,sama7d65-pmc` compatible string to the existing binding, > since the SAMA7D65 PMC shares the same properties and clock requirements > as the SAMA7G5. Shouldn't you rather use a fallback if you currently have no driver change? > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > --- > Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > index c9eb60776b4d..885d47dd5724 100644 > --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > @@ -43,6 +43,7 @@ properties: > - atmel,sama5d4-pmc > - microchip,sam9x60-pmc > - microchip,sam9x7-pmc > + - microchip,sama7d65-pmc > - microchip,sama7g5-pmc > - const: syscon > > @@ -90,6 +91,7 @@ allOf: > enum: > - microchip,sam9x60-pmc > - microchip,sam9x7-pmc > + - microchip,sama7d65-pmc > - microchip,sama7g5-pmc > then: > properties: > > --- > base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e > change-id: 20240829-sama7d65-next-a91d089b56a3 > > Best regards, > -- > Dharma Balasubiramani <dharma.b@microchip.com> >
Alexandre, On 29/08/2024 at 16:10, Alexandre Belloni wrote: > On 29/08/2024 15:08:45+0530, Dharma Balasubiramani wrote: >> Add the `microchip,sama7d65-pmc` compatible string to the existing binding, >> since the SAMA7D65 PMC shares the same properties and clock requirements >> as the SAMA7G5. > > Shouldn't you rather use a fallback if you currently have no driver > change? The clock/pmc driver is (will be) different. Only the binding of the PMC uses the same properties and clocks specification as our recent SoCs (so can be added to the "enum"). Regards, Nicolas >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >> --- >> Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml >> index c9eb60776b4d..885d47dd5724 100644 >> --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml >> +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml >> @@ -43,6 +43,7 @@ properties: >> - atmel,sama5d4-pmc >> - microchip,sam9x60-pmc >> - microchip,sam9x7-pmc >> + - microchip,sama7d65-pmc >> - microchip,sama7g5-pmc >> - const: syscon >> >> @@ -90,6 +91,7 @@ allOf: >> enum: >> - microchip,sam9x60-pmc >> - microchip,sam9x7-pmc >> + - microchip,sama7d65-pmc >> - microchip,sama7g5-pmc >> then: >> properties: >> >> --- >> base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e >> change-id: 20240829-sama7d65-next-a91d089b56a3 >> >> Best regards, >> -- >> Dharma Balasubiramani <dharma.b@microchip.com> >> > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
On Thu, Aug 29, 2024 at 03:08:45PM +0530, Dharma Balasubiramani wrote: > Add the `microchip,sama7d65-pmc` compatible string to the existing binding, > since the SAMA7D65 PMC shares the same properties and clock requirements > as the SAMA7G5. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>
On 29.08.2024 12:38, Dharma Balasubiramani wrote: > Add the `microchip,sama7d65-pmc` compatible string to the existing binding, > since the SAMA7D65 PMC shares the same properties and clock requirements > as the SAMA7G5. Looks a bit odd to me to publish bindings and driver chances by 2 different people, at exactly the same time. Maybe coordinate and publish it together (at least for the future). Other than this: Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev> > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > --- > Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > index c9eb60776b4d..885d47dd5724 100644 > --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > @@ -43,6 +43,7 @@ properties: > - atmel,sama5d4-pmc > - microchip,sam9x60-pmc > - microchip,sam9x7-pmc > + - microchip,sama7d65-pmc > - microchip,sama7g5-pmc > - const: syscon > > @@ -90,6 +91,7 @@ allOf: > enum: > - microchip,sam9x60-pmc > - microchip,sam9x7-pmc > + - microchip,sama7d65-pmc > - microchip,sama7g5-pmc > then: > properties: > > --- > base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e > change-id: 20240829-sama7d65-next-a91d089b56a3 > > Best regards,
On 29/08/2024 16:42, Nicolas Ferre wrote: > Alexandre, > > On 29/08/2024 at 16:10, Alexandre Belloni wrote: >> On 29/08/2024 15:08:45+0530, Dharma Balasubiramani wrote: >>> Add the `microchip,sama7d65-pmc` compatible string to the existing binding, >>> since the SAMA7D65 PMC shares the same properties and clock requirements >>> as the SAMA7G5. >> >> Shouldn't you rather use a fallback if you currently have no driver >> change? > > The clock/pmc driver is (will be) different. Only the binding of the PMC > uses the same properties and clocks specification as our recent SoCs (so > can be added to the "enum"). I don't understand this patch. The binding without any users makes no sense. For bindings without drivers, I understand you send it in parallel from the DTS. But this one here will have a driver, right? In such case IT MUST GO with the driver. Best regards, Krzysztof
On 29/08/2024 at 11:38, Dharma Balasubiramani wrote: > Add the `microchip,sama7d65-pmc` compatible string to the existing binding, > since the SAMA7D65 PMC shares the same properties and clock requirements > as the SAMA7G5. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> For the record, driver addition is here: v1: https://lore.kernel.org/linux-arm-kernel/cover.1724948760.git.Ryan.Wanner@microchip.com/ v2: https://lore.kernel.org/linux-arm-kernel/cover.1725392645.git.Ryan.Wanner@microchip.com/ Best regards, Nicolas > --- > Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > index c9eb60776b4d..885d47dd5724 100644 > --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml > @@ -43,6 +43,7 @@ properties: > - atmel,sama5d4-pmc > - microchip,sam9x60-pmc > - microchip,sam9x7-pmc > + - microchip,sama7d65-pmc > - microchip,sama7g5-pmc > - const: syscon > > @@ -90,6 +91,7 @@ allOf: > enum: > - microchip,sam9x60-pmc > - microchip,sam9x7-pmc > + - microchip,sama7d65-pmc > - microchip,sama7g5-pmc > then: > properties: > > --- > base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e > change-id: 20240829-sama7d65-next-a91d089b56a3 > > Best regards,
On 05/09/2024 17:18, Nicolas Ferre wrote: > On 29/08/2024 at 11:38, Dharma Balasubiramani wrote: >> Add the `microchip,sama7d65-pmc` compatible string to the existing binding, >> since the SAMA7D65 PMC shares the same properties and clock requirements >> as the SAMA7G5. >> >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > > For the record, driver addition is here: > v1: > https://lore.kernel.org/linux-arm-kernel/cover.1724948760.git.Ryan.Wanner@microchip.com/ > > v2: > https://lore.kernel.org/linux-arm-kernel/cover.1725392645.git.Ryan.Wanner@microchip.com/ > Sending driver separately from the binding means there are warnings of undocumented compatibles. Submitting bindings also documents this. This must be one patchset. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml index c9eb60776b4d..885d47dd5724 100644 --- a/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml +++ b/Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml @@ -43,6 +43,7 @@ properties: - atmel,sama5d4-pmc - microchip,sam9x60-pmc - microchip,sam9x7-pmc + - microchip,sama7d65-pmc - microchip,sama7g5-pmc - const: syscon @@ -90,6 +91,7 @@ allOf: enum: - microchip,sam9x60-pmc - microchip,sam9x7-pmc + - microchip,sama7d65-pmc - microchip,sama7g5-pmc then: properties:
Add the `microchip,sama7d65-pmc` compatible string to the existing binding, since the SAMA7D65 PMC shares the same properties and clock requirements as the SAMA7G5. Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> --- Documentation/devicetree/bindings/clock/atmel,at91rm9200-pmc.yaml | 2 ++ 1 file changed, 2 insertions(+) --- base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e change-id: 20240829-sama7d65-next-a91d089b56a3 Best regards,