diff mbox series

dt-bindings: clocks: atmel,at91sam9x5-sckc: add sama7d65

Message ID 20240829-sama7d65-sck-v1-1-3e7b19e3cbf9@microchip.com (mailing list archive)
State New
Headers show
Series dt-bindings: clocks: atmel,at91sam9x5-sckc: add sama7d65 | expand

Commit Message

Dharma Balasubiramani Aug. 29, 2024, 10:54 a.m. UTC 
Add bindings for SAMA7D65's slow clock controller.

Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
 Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: b18bbfc14a38b5234e09c2adcf713e38063a7e6e
change-id: 20240829-sama7d65-sck-aab8d133465b

Best regards,

Comments

Conor Dooley Aug. 29, 2024, 4:09 p.m. UTC | #1 
On Thu, Aug 29, 2024 at 04:24:37PM +0530, Dharma Balasubiramani wrote:
> Add bindings for SAMA7D65's slow clock controller.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Krzysztof Kozlowski Aug. 31, 2024, 1:39 p.m. UTC | #2 
On 29/08/2024 12:54, Dharma Balasubiramani wrote:
> Add bindings for SAMA7D65's slow clock controller.
> 
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> ---
>  Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml
> index c2283cd07f05..d4cf8ae2961e 100644
> --- a/Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml
> +++ b/Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml
> @@ -20,6 +20,7 @@ properties:
>        - items:
>            - enum:
>                - microchip,sam9x7-sckc
> +              - microchip,sama7d65-sckc
>                - microchip,sama7g5-sckc
>            - const: microchip,sam9x60-sckc

I have doubts about this as well. For example "microchip,sam9x7-sckc"
was added, but there are no users.

Stop adding bindings without users. Before you keep posting more of this
stuff, post your DTS in parallel.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml b/Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml
index c2283cd07f05..d4cf8ae2961e 100644
--- a/Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml
+++ b/Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml
@@ -20,6 +20,7 @@  properties:
       - items:
           - enum:
               - microchip,sam9x7-sckc
+              - microchip,sama7d65-sckc
               - microchip,sama7g5-sckc
           - const: microchip,sam9x60-sckc