From patchwork Thu Aug 29 06:31:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13782619 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05191C761AE for ; Thu, 29 Aug 2024 06:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OoKrVSNreqAYFuHliYoTD48s/lJcIvRqPPKqditciag=; b=MvpMALB74moRw2VVG98fPU5ZEv dg6n1d2OOnEmD+tZyHp8W/GhttJlnkvvN6+/5tx0S6NQWT+BJW9t2oSaDE8eEzJwLAaA1jGioSfKg NY+M7CzMyLWukIRD2sjA4dEqOCWjAGZHmV3A/5tA2JiNxM/a0pr6RD/iPdvsYWFh9npi1EYHY3zQQ MFVu8ke7U1v0SY8hfSQUoc7y+wOTZsJtHhjkIaJoIBAKH02TtidIiJ0lvj4CIXIfvto7BkazvTZGG Cho5f4iX1qDvAZyVqpihl9AFrKU02xi0cHoWDEUpTcH3bLkFLASEpFBpT0oNLFZwNkpwP2hob1Xe4 595ySdFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjYgV-00000000mnn-0me5; Thu, 29 Aug 2024 06:31:07 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjYZW-00000000kRl-0lcK for linux-arm-kernel@bombadil.infradead.org; Thu, 29 Aug 2024 06:23:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=OoKrVSNreqAYFuHliYoTD48s/lJcIvRqPPKqditciag=; b=d+Rbe7kXEMxFwW6RBSkJzmz4iK Q30Gj0ytKLMAJQlZKvpTyZaDZkfvqXi1qfr1YT5BZ7j6f0dDGgi9jT6NXphGXeeKlOsusfP7zJbZK XSV5hcmY2aXoiH9G1Jr+jfd2/mfy08GcKMg+0fuDzAmHOnOiqbHRW1DXY2Pu2dpE8esQWSfRgin8j V8maYjfhB1eUazfxfxnR4rFAfSPbVJ6aqLqDEGzsJvjuVYZkHCxnZtoIoJieXLK8MtlceZu9d0lNM v0VFK4O2lTOxe6qngRpfu5bRMvujl9ASbjzWKUOlrWxka/PyeeGlx4NVEw9sBFvlKzKlrLcZ7/swI 2VC6UTvw==; Received: from szxga03-in.huawei.com ([45.249.212.189]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjYZS-0000000BMx0-03aC for linux-arm-kernel@lists.infradead.org; Thu, 29 Aug 2024 06:23:52 +0000 Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4WvWLk1qpJzQqxb; Thu, 29 Aug 2024 14:18:38 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id E69FD180AE6; Thu, 29 Aug 2024 14:23:28 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 29 Aug 2024 14:23:27 +0800 From: Jinjie Ruan To: , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: Subject: [PATCH net-next v3 12/13] net: bcmasp: Simplify with scoped for each OF child loop Date: Thu, 29 Aug 2024 14:31:17 +0800 Message-ID: <20240829063118.67453-13-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240829063118.67453-1-ruanjinjie@huawei.com> References: <20240829063118.67453-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_072350_682894_36A03A28 X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Jinjie Ruan Reviewed-by: Jonathan Cameron Reviewed-by: Andrew Lunn Reviewed-by: Justin Chen Reviewed-by: Florian Fainelli --- v3: - Sort the variables, longest first, shortest last. - Add Reviewed-by. v2: - Split into 2 patches. --- drivers/net/ethernet/broadcom/asp2/bcmasp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c index 20c6529ec135..297c2682a9cf 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c @@ -1300,9 +1300,9 @@ static void bcmasp_remove_intfs(struct bcmasp_priv *priv) static int bcmasp_probe(struct platform_device *pdev) { - struct device_node *ports_node, *intf_node; const struct bcmasp_plat_data *pdata; struct device *dev = &pdev->dev; + struct device_node *ports_node; struct bcmasp_priv *priv; struct bcmasp_intf *intf; int ret = 0, count = 0; @@ -1374,12 +1374,11 @@ static int bcmasp_probe(struct platform_device *pdev) } i = 0; - for_each_available_child_of_node(ports_node, intf_node) { + for_each_available_child_of_node_scoped(ports_node, intf_node) { intf = bcmasp_interface_create(priv, intf_node, i); if (!intf) { dev_err(dev, "Cannot create eth interface %d\n", i); bcmasp_remove_intfs(priv); - of_node_put(intf_node); ret = -ENOMEM; goto of_put_exit; }