| Message ID | 20240829085316.3144246-1-yujiaoliang@vivo.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] tty: serial: ma35d1: Simplify with dev_err_probe() | expand |
On 29/08/2024 10:53, Yu Jiaoliang wrote: > Error handling in probe() can be a bit simpler with dev_err_probe(). > > Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com> > --- > drivers/tty/serial/ma35d1_serial.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c > index 3b4206e815fe..09d42a4054b3 100644 > --- a/drivers/tty/serial/ma35d1_serial.c > +++ b/drivers/tty/serial/ma35d1_serial.c > @@ -692,10 +692,9 @@ static int ma35d1serial_probe(struct platform_device *pdev) > return -ENODEV; > > ret = of_alias_get_id(pdev->dev.of_node, "serial"); > - if (ret < 0) { > - dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret); > - return ret; > - } > + if (ret < 0) > + return dev_err_probe(&pdev->dev, ret, "failed to get alias/pdev id\n"); This is kind of silly... You change part which cannot defer, but you leave second dev_err() intact which actually would benefit from handling defer and dev_err_probe(). You either do not understand the function at all or you split patches in some artificial, fake way just to generate multiple patches. That's pointless. Best regards, Krzysztof
diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c index 3b4206e815fe..09d42a4054b3 100644 --- a/drivers/tty/serial/ma35d1_serial.c +++ b/drivers/tty/serial/ma35d1_serial.c @@ -692,10 +692,9 @@ static int ma35d1serial_probe(struct platform_device *pdev) return -ENODEV; ret = of_alias_get_id(pdev->dev.of_node, "serial"); - if (ret < 0) { - dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "failed to get alias/pdev id\n"); + up = &ma35d1serial_ports[ret]; up->port.line = ret; res_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Error handling in probe() can be a bit simpler with dev_err_probe(). Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com> --- drivers/tty/serial/ma35d1_serial.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)