From patchwork Fri Aug 30 06:11:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 13784326 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70D31CA0EE5 for ; Fri, 30 Aug 2024 06:13:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BGWGmkbv243QOeOOaSPc7hPTP5zReoSOOP5IN2FytII=; b=TNplm91Jcz4P548m856gcmuncu ZOuvd0UBrWl4+riqVABfES9+trge1nNUINoHgS70AF79NMoUrZof5J+F+g+jjH/Ldne3H6Ju9mPh6 Qm4VbTJs18ss74BndsouKtZiiWzY5yi1oYTll4BvrJ0RqjT4qhIl0LzzH0iLehgQkzL6ouxChJCK+ XV7D9QgbCzFRMgs0Cen3fAtMBKSoPBjkLqnfiadd/bHlyQpgcF8dTIEA+hgGuDoYM91nEcxvO6L7a tHl9iWNQxe7+/E6SMvKOyi7zHVlyUx/n9xKW1nMtl6jGrSco06OVoi3EjKBm24GaBc/ZzLI0ZrKru ZdQyp4Ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjuse-00000004uY4-1Kb2; Fri, 30 Aug 2024 06:13:08 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjurl-00000004uIr-3qh3 for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 06:12:15 +0000 Received: from [192.168.29.25] (unknown [IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 324FF524; Fri, 30 Aug 2024 08:10:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1724998262; bh=A5lJjAthj7edefbpVSZ1vxzA9GwnHb4ZMwTPz2YGRBY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=u/91umadaVk2kcMeThKWsNphlUtZpHhxeMCHXESH97tGfZImcRsu52Rv7d9BWVTar +qRcnajlS1en5BEMRQSAr07uZyAS9lIQAfKgaxEtsvLFHNBoDjWt4SI8Ydw0udnps/ FmzqMMQ1IQXDPvVP4xuUAikcEM5oNvFQasrmEztY= From: Umang Jain Date: Fri, 30 Aug 2024 11:41:51 +0530 Subject: [PATCH v4 1/2] dt-bindings: media: imx335: Add reset-gpios to the DT example MIME-Version: 1.0 Message-Id: <20240830-imx335-vflip-v4-1-cb9f20fc7b87@ideasonboard.com> References: <20240830-imx335-vflip-v4-0-cb9f20fc7b87@ideasonboard.com> In-Reply-To: <20240830-imx335-vflip-v4-0-cb9f20fc7b87@ideasonboard.com> To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , "Paul J. Murphy" , Daniele Alessandrelli , Sakari Ailus , Martina Krasteva Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Kieran Bingham , Laurent Pinchart , Umang Jain , Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1724998323; l=1487; i=umang.jain@ideasonboard.com; s=20240731; h=from:subject:message-id; bh=A5lJjAthj7edefbpVSZ1vxzA9GwnHb4ZMwTPz2YGRBY=; b=222YGFQbzKPw/p+ZhX2x9k1K8y+nLZd0q1+lOMFuTcH/52XeXGFUImn45SBUJ3HINrtRdwAFo YyaKhvM+HKwCm2q2GsAgqenDszct3DJFtSJFQcB5t4aYlH0mQt2JIXa X-Developer-Key: i=umang.jain@ideasonboard.com; a=ed25519; pk=7pvnIBNsDpFUMiph0Vlhrr01+rAn5fSIn/QtDeLeXL0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_231214_131834_837F14F7 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It's easy to get the polarity of GPIOs in the device tree wrong, as shown by a recently fixed bug in the imx335 driver. To lower the chance of future mistakes, especially in new bindings that would take the imx335 binding as a starting point, add the reset-gpios property to the DT example. This showcases the correct polarity of the XCLR signal for Sony sensors in the most common case of the signal not being inverted on the board. Acked-by: Krzysztof Kozlowski Signed-off-by: Umang Jain --- Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml index 106c36ee966d..77bf3a4ee89d 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml @@ -75,6 +75,8 @@ additionalProperties: false examples: - | + #include + i2c { #address-cells = <1>; #size-cells = <0>; @@ -92,6 +94,8 @@ examples: ovdd-supply = <&camera_vddo_1v8>; dvdd-supply = <&camera_vddd_1v2>; + reset-gpios = <&gpio 50 GPIO_ACTIVE_LOW>; + port { imx335: endpoint { remote-endpoint = <&cam>;