From patchwork Fri Aug 30 06:32:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13784352 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E23F3CA0EE5 for ; Fri, 30 Aug 2024 06:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4RxHHUoC5AA5dvCIafWmwr0YTHkc87b4aGUnq4C1JLY=; b=ZZHWFo0NwQdQFaiGJUrqbgyxrh HfcuBEt4npSkS1Z7HT7p5IUH8q/+NvxVYPMfJyBBwUG5WqiqSmO0WjzSi3BfldcQ3hqUpsHB77Y16 U3Q6H/P+djpzgVmXXRt1HFsK01XfOrE+lQwzkNIl4DjQesNVTtyrb8JoQJSuj8iy/rMHI/4SW0MBi JD84pAgQ0cht8FaIx4y9zU7+VhaxtzLXlIf1mGcg0UHJlMqTgUVmWnifV/brKg9QGSwL2YxEjZ6Gl 3o+bQXcOyr8kKrrcVLZsE3J6IgL8MaX5cimmFQr3KFGuXB0Pwz4zXRgqn+mpytUxNtlzFtRyHbYMl R0XSxRHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjv8S-00000004xUr-48Hu; Fri, 30 Aug 2024 06:29:28 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjv3z-00000004w4m-0Rtw for linux-arm-kernel@bombadil.infradead.org; Fri, 30 Aug 2024 06:24:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=4RxHHUoC5AA5dvCIafWmwr0YTHkc87b4aGUnq4C1JLY=; b=VDyhzITkulBYZvpSXBqArVhkIi Fcc/MLdgKFIhvtK0zfrqxCDXR8KdN4HVp4oA3+01xIPdthDy3QiS0LllS6CAtYh9Gqd8zbGdOMIOb +EbfFYLkOpFRZrUQlyx+RexYJxeEZFO0Lv+Fqb/fUNu7D8cXDI0OyJMaH8X1wndkbzlD5pEW0Z+o5 S0/hDnq+ektJ+ckkHM/BeG5xzjvGvS5jB1NjxzvEhPjO+Ho1Otn+494fmrgwE0rA79haOIX//Zwa7 ctcQr/bCJUZQFOb+IsmWJ3VMkQfolWjBoKlN7bmkhKvtm6n4r0i/FNVn//8wbeCHwgs2m/Itgv5ME 7DtTW13w==; Received: from szxga04-in.huawei.com ([45.249.212.190]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjv3n-0000000Ba8p-2eER for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 06:24:46 +0000 Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Ww7KG1XSVz20n3V; Fri, 30 Aug 2024 14:19:30 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 8EECA1A016C; Fri, 30 Aug 2024 14:24:21 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 30 Aug 2024 14:24:21 +0800 From: Jinjie Ruan To: , , , , , CC: Subject: [PATCH -next v2 1/4] soc: ti: knav_dma: Simplify with scoped for each OF child loop Date: Fri, 30 Aug 2024 14:32:25 +0800 Message-ID: <20240830063228.3519385-2-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240830063228.3519385-1-ruanjinjie@huawei.com> References: <20240830063228.3519385-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_072440_911620_7586CA67 X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use scoped for_each_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Jinjie Ruan --- v2: - Split into 2 patches. --- drivers/soc/ti/knav_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index fb0746d8caad..15e41d3a5e22 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -706,7 +706,6 @@ static int knav_dma_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct device_node *node = pdev->dev.of_node; - struct device_node *child; int ret = 0; if (!node) { @@ -732,10 +731,9 @@ static int knav_dma_probe(struct platform_device *pdev) } /* Initialise all packet dmas */ - for_each_child_of_node(node, child) { + for_each_child_of_node_scoped(node, child) { ret = dma_init(node, child); if (ret) { - of_node_put(child); dev_err(&pdev->dev, "init failed with %d\n", ret); break; }