From patchwork Fri Aug 30 06:32:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13784347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD573CA0EE5 for ; Fri, 30 Aug 2024 06:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nn6hYpaNWCgtzhY8pj1g/0Ypj5tMVixjQ9Zd69BwrIQ=; b=vXo0yRAeXTBvmHt2Wu/ViOkCXq f2ZJJ624wduq0YmkPvtOEk4/iaIbRThpMRDa8IVk3bct16kJ75sF4/AMn3XjmZV+oYIRTkzrBEusR uzVnZxajuHiz175OHY9nnXjOXMd0iELBwhNvUH4SvMZ9tFSYMV1BuwUyqtl8CpWl7iA7NK3X1UHxL Pg/78RP51M4sgkBCIXicM6fYmANAk4gX500e9HFJc2d0amwANnlxFspl3QLSCIv4iSTAXZPeNZk1e uhKCAbeKGS2RJ5S/OCajULPOlZ0T/Uw442zAFzKXLXEpmP41aMzFLIHfLsRF40qnSbSjY/xPQGe+Z PEdP3ILw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjv4a-00000004wDU-0wRW; Fri, 30 Aug 2024 06:25:28 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjv3h-00000004vzQ-2TYY for linux-arm-kernel@lists.infradead.org; Fri, 30 Aug 2024 06:24:35 +0000 Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Ww7KG0yLhzQrBd; Fri, 30 Aug 2024 14:19:30 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id E2B35140360; Fri, 30 Aug 2024 14:24:21 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 30 Aug 2024 14:24:21 +0800 From: Jinjie Ruan To: , , , , , CC: Subject: [PATCH -next v2 2/4] soc: ti: knav_dma: Use dev_err_probe() to simplfy code Date: Fri, 30 Aug 2024 14:32:26 +0800 Message-ID: <20240830063228.3519385-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240830063228.3519385-1-ruanjinjie@huawei.com> References: <20240830063228.3519385-1-ruanjinjie@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240829_232433_905300_BC97B889 X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: Jinjie Ruan --- v2: - Split into 2 patches. --- drivers/soc/ti/knav_dma.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 15e41d3a5e22..eeec422a46f0 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -708,17 +708,13 @@ static int knav_dma_probe(struct platform_device *pdev) struct device_node *node = pdev->dev.of_node; int ret = 0; - if (!node) { - dev_err(&pdev->dev, "could not find device info\n"); - return -EINVAL; - } + if (!node) + return dev_err_probe(&pdev->dev, -EINVAL, "could not find device info\n"); kdev = devm_kzalloc(dev, sizeof(struct knav_dma_pool_device), GFP_KERNEL); - if (!kdev) { - dev_err(dev, "could not allocate driver mem\n"); - return -ENOMEM; - } + if (!kdev) + return dev_err_probe(dev, -ENOMEM, "could not allocate driver mem\n"); kdev->dev = dev; INIT_LIST_HEAD(&kdev->list);