From patchwork Fri Aug 30 08:05:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yan Zhen X-Patchwork-Id: 13784499 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19B7ECA0EEB for ; Fri, 30 Aug 2024 08:07:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=jXE5wezqWjyqsrOsoPZyI6FDRd62p7BbR1uAaf8NKAE=; b=mxz5b9JTda1jD30cEQnJSGyp2Y 7TKtck+n44+Z72K11KNnxJAgFA90BwHKolhhhUhD7o+6oVbfzTuJe3FBfpcBS0e7C899jfAwTnW6+ XR7ZXSI27Cho/X/sf6/RmxtjW3/C65JK631foeB+9s0dcafJ0Hrzs50jmVLhphGKdw5jc7u96cuwW x9y8vFiced2RbQIdsSUBLEhoXYq3xr1Car97xZuQhPuspSQDbUzI+qNVq1zo77QmXbvEOPmXvu91N CCmzIk3CqXnOYdRivAo72K9JoocUJ6CW4txrMzwWa2azHXTnwDuhwPP3XkrJNYJP91VLmIGKgWktk MdCrGB3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjwfR-00000005Fb8-0TGP; Fri, 30 Aug 2024 08:07:37 +0000 Received: from mail-eastasiaazlp170100000.outbound.protection.outlook.com ([2a01:111:f403:c400::] helo=HK2PR02CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sjweD-00000005FAM-23Fk; Fri, 30 Aug 2024 08:06:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NBb8SoXB3xCc3YWuR9b20lTqhcnbhjaTcFgmqAAyC4lL28hto8uidPT8yC9G4qIgtQgwSKwT6yU4ZU/bsHAKXJPR91GTneQq1AjRbTRx/zkVTrap3CShh3t1/Qb+/9g7OY4BQ3cAHrIUMCL5t9PaCNR87+gkbKrI4SoGb35m5Vxjeae/X6ms6QADfUN89tZWCI7Lz6+l2TDz9UrgjgwDtHNsLIgxMnEAKZt9DJ2TLem9m+7pkAyID/MyqHXjZmNPPs3mbottO4c8QOwhXf1B8dv861XUulFm+gEwStso8nj1AYCX0D0aEIg1CzbVkkhY8rIEraL1fQR28Oi5mKJtrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jXE5wezqWjyqsrOsoPZyI6FDRd62p7BbR1uAaf8NKAE=; b=P8GdtyC5SCM3WYCAazQlDp0rnmohWAuIMPUFNjQ2iWd5VO0RnaOV9E3m4lIN5fZBdyghlBNfYwvk+YjNnjTlqtDMG6XMh7bYPNi2t8RLmTBb4SOm3jPsAgoS+NnieNtMTp4WBR+MDJaEM3MT0cA0c8zVpnmGh1vEFTL7Y1EhxYvhPk/Le+VbLRdx2B7mXGMyWUrXoKIJ4YoDQEF0tYdmM1Wa+yLMPK5qjnTo/AQ/Rbm50/z9clvyHyimJhxGehGLhqOPrLyvyGKVtvnzxyiLr44fjb3hI7SbG7pSEZCNLuxEleMAvwgFcegfErXZwqAuTzr/509lU0MoO0JsB9xDVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jXE5wezqWjyqsrOsoPZyI6FDRd62p7BbR1uAaf8NKAE=; b=hRHkGL9GlH16qTBWCeKRe/UgAVhZ/7QPag7DCA0zNU7IbNbzBXVmfuUd2m4r7YaV2ymFogp/oVgSjmRejy0+H1mJbUyFUnfzaYvgHgjx7IfF97OeKxg2G8LXTEHmLFFVfdvYloLyBBqCPr/zfKxEH6ttdaUlZSRaGRekEefIQhUsBYS/9iFirFZSSo/3oVOn+jWV2XPQ4TdOUhbgw8sG0nvTldFqpEvNz91KE0gTeFlwaNMi4Jxiv1caX2WoKfpSpyB8jLb0wN74EjZ30os6kbZfPLAVNQZgaiV/++J4SRqZ/B/jGXXqEOUOWT1jDwVssGSgkuT4GHZaFc+V+UJZ4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from KL1PR0601MB4113.apcprd06.prod.outlook.com (2603:1096:820:31::7) by SI2PR06MB5388.apcprd06.prod.outlook.com (2603:1096:4:1ef::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.27; Fri, 30 Aug 2024 08:06:13 +0000 Received: from KL1PR0601MB4113.apcprd06.prod.outlook.com ([fe80::7e85:dad0:3f7:78a1]) by KL1PR0601MB4113.apcprd06.prod.outlook.com ([fe80::7e85:dad0:3f7:78a1%4]) with mapi id 15.20.7918.019; Fri, 30 Aug 2024 08:06:13 +0000 From: Yan Zhen To: matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, opensource.kernel@vivo.com, Yan Zhen Subject: [PATCH v2] soc: mediatek: Simplify with dev_err_probe() Date: Fri, 30 Aug 2024 16:05:38 +0800 Message-Id: <20240830080538.376200-1-yanzhen@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: TYCP286CA0325.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::8) To KL1PR0601MB4113.apcprd06.prod.outlook.com (2603:1096:820:31::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: KL1PR0601MB4113:EE_|SI2PR06MB5388:EE_ X-MS-Office365-Filtering-Correlation-Id: c44db92b-bac8-4319-7c80-08dcc8ca9d52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: z9SK3Jtnjj9K/V/qxxtMC8WGvGlTFTVySIR2I9kUPzwYh4fLZHQZeJJVAOLnhJ7Z61dlOSd4AnxEsSL5WGvh9Dl4cNNrGTGd5VinUgOMQrkhV2Jbk4dSvlxRU/ijsbRBOCWlJqdMsiymrWyKJASg8sDWN3kXH8g/X7AVZzYC8Cupqbq8aoIA+KOw2rMGElMzRGk3GjfcT/Qv6OV3uvXgOgPOPzpDfLEBDpQFdRfwXWR2F3sq8ODaRoB7rdOXuwmQ0huo4CCRk3nYE2zg96LKl6Rep7fZ1OPksDociWfyWxC0pWOU/ST4qhMiCYmYB/pzzdso3ShCtAcVimRRS05T8Mb42L48fQ+tGSA1Ivk9C+9Podnt7aAdpl8vsApc2ECulzFSC1RoZz1aUrmu4cgwsmrcs8f40n9oHDgI2k/iYItHIVeWR/mIYceSmpRDTVOJHcd4fJRER7VL1i+kjirxTY4uNgrie6WWt1fyqpDSODB9n0AYKWJu6+2Wfxs3z/h0chix7uqVScUNKigmrcQPxr/QuoUI+vcHjLwIkNur9G7uKqK9Q5fmOhDFRT2ROAD3s0sAyqLSCi2Cb6+udIWbH6FzSToSGabuHODK6PQbnkDxTp5Ij78r9HTy9LEBP3dnyO3vBBcB8VtDqC7R5Lk0ETK5MPFT+/dOhs4rH2kVvHVw0Q1jdTZOORO0mX9rxEZNSBgdJ1OCDhcvTF++2s3TLaYhgIpXutuxsqNY7AXrM3LQxZP2aZh2l676Wrdbw0ti8DlpFljiN+0uOq0yhlWZ1zzoFyeKLwdluqmkxUXX+bbFwuPIDMVNXsuuzQs4qkw/NJPexf0SrEcpN+SMMOrg1txVTVXrHQmJPXz9Q3lqPLd0kgeslqw9sOkjcZTnnCNC1Gm9slwmyqsrsSOZvuaXw2KlfKm2bwkfbnjAEW6DjW2Kb3CA5u4aooxKZRFgTTHt6rzI3VT33geBQ7FGUdXYoMZtVbgQ31KYlhDFQmpveDnxZpe4SwwKWbTOakGpN+ujYSwGmVVmkS/GFyUO4MWtNfr6r5eMQtyAzjrrm2oBU1t7T+nwUPsDgmr3wtW7po9izqhBHyAxueRe8NXFfWkgVqqgC5nkemeVtLx29F+shq+eydjihc0U+F0ltV9PQzRunWQciacuAO4BgHSP0mw2sgC9llFwphVzzz7A+yHNamibKnyhZpTAbs2qHQcCb0x7SbJXwtQhj7B8Y56BNUn8jJ65R0Tnzcams6pvMPwIfs7D6K4xZ3xFHWWFLMYIZS8W7AOXpfdqLLenEcJ0udhhJJZtRLL/Z/Ws2SJ2XQUGJsrT/ZRhBK1+2HBP35hdDaB7ZZJsG4BB8ZRUYizBCLpIAyxwdbX7DVuZJ+Yqifb08xX3NSUZiRXiGdewKfVLo3V4/KBsD+V/hQ36J+MY0NPsNg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:KL1PR0601MB4113.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: lk7ks60wm320soYlA50Bdk5Pr8VyqkUwzWVP/mWftOymZ8L+5wzTt9iof2m0akyabuvXES9QhdyAgzZGH5fLd2LOu/V7Nw4SkqLPniYYwXWujjL7ToPiC4dEViCYtDeixDrMchN61MQj7IznFuYd9JGqZziDQVlMkl6OEcwE3Ie2gaE6VHf9ZYvm/p3rO5UGzl7AMc+4KaRUC+Wj2JXKAWEiW5EVtdhA0H38nd8bL6Qy2uBTXc9z3lM2FvTqfEzWiQ20neTXETD5yHWoH+DSWwudsYoRVeevM48aSMRcr9ddnUUWzGZvWRAkM2gEEPb28029Den6aMvbNpKKv/z9nKP+0wJ1U9NAZmXPrVgiuV6G5YFdp7kYAg+V46btFa4qSKqdK/eKkRUQGSoS7ocAHTlWO0TJUv+BbX+m2rD3EoEjDIh4FkS4QHhK7tpIIC6fWkQ4vrhe31feWWsLmD7UDeOMUiX8VTzeJs+aeww4jlNs/u5I/VeKDkRjDl05EGSNvW1J8Z38r+x910KBVjvV9lbVWZ+xqPS7TrqJwAx4tZs6FpVTwvtW8nL8uhO7i3UuIxhMTxi4jzxQrbi9Ndl5vqHNTZ8RlbLnqduQhS8aYxyueyoE/bBB9W2WB8TTuyS5oY5ieqbwaddFyjQ9fQWSoa9Wb17ewzrLHjZNI7II2pHHsGBPc7nM64tAjWpPvaovosa0h58sJi9lYPxAzuzy/OfokiPDmgy88csr/573tRMY9Fb4G8f44tlqH/KnA0KLUflptfqhhIXOp6O/hP5x5tkquXXKqnsWfFXGZMZpAW0n9b29C45CfurrVbiOLM7CKJ5VrJYRsFNseR0cfx9PheC/7fSOAVJ2EtCDD+RUHs2QFudkhIKxpNjfbNbihYOTRJxGp6rZ/R5OdQ7kBlf7UbBN4xitQ9JiCNFNpIRKMjVXcj2PDZPtosRFsgOm54y+Mc1uoHEEzSKzqGWYpLpCKW/EdVMB6Wvn6vWgxH3Zd0vuY/hR8ddAqzEvDopgvBmZmVRt2zquF1EhqZ+31owiHMAT0vIc6FTj5joERr50a6iuG+s4MM6uo0RQsnCtaAh7hB0emzWw3sZLxfi0+5z+Plju9+vqVXe9ooeT5/KG/Q2M5TSimRMJn/hdccRCr+dWOVhICXxcRlqaJzW+0eukfLtFIeGzvbwzH5ZPJp/EjF/gQRtN+ydgEzhT2zz7ExzkNcwzLHjwFsBHFOXlheFBZ0jArDZBVzsJnKZ7FD5KcjE1JbAJuspZzl6Ac7Jv2LfbxtVBnNodWwiHbqOAMBRMtoQLVY7phgMucJIbdlFsYF88rz2r3WnHf+m1XFwBhHUTPmz6etmVOj6zB4RUSyuoiapoa7ahiYyMMulAasftv+z1rzo3OeRg75ta4MNwsm9TNLTogeSDhEEJU1lk2GyPeqkTHB7a8FemjN5G1F5KsHUjltK2/aFqIhM84/vzjy6yWCTWeSVoqKjrftDFjs6a/PJINYYmT2Bst5Xr4TEIBdiIb/CIaGECr8pE3BwD//08VupcMAfhZMjWNfGLc3eGGSc2gJwMp22rMkqn4muBtPQW6/YeBUOhhkzcitXZK24l X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c44db92b-bac8-4319-7c80-08dcc8ca9d52 X-MS-Exchange-CrossTenant-AuthSource: KL1PR0601MB4113.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2024 08:06:12.9635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nKhkd4anX4TQzy4cWUbnHSyVA8MP1+WDh9IkotwKAKjmasmXbpgEhf+OUMaEKBLVifMXtrDbeQuDFxYqoFXo/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5388 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_010621_555128_097FC9B7 X-CRM114-Status: GOOD ( 12.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Using dev_err_probe() to simplify the error path and unify a message template. Using this helper is totally fine even if err is known to never be -EPROBE_DEFER. The benefit compared to a normal dev_err() is the standardized format of the error code, it being emitted symbolically and the fact that the error code is returned which allows more compact error paths. Signed-off-by: Yan Zhen Reviewed-by: Nícolas F. R. A. Prado --- Changes in v2: - Get rid of `ret = PTR_ERR(mmsys->regs);`. drivers/soc/mediatek/mtk-mmsys.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c index 938240714e54..a6e0c41c10ab 100644 --- a/drivers/soc/mediatek/mtk-mmsys.c +++ b/drivers/soc/mediatek/mtk-mmsys.c @@ -397,11 +397,9 @@ static int mtk_mmsys_probe(struct platform_device *pdev) return -ENOMEM; mmsys->regs = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(mmsys->regs)) { - ret = PTR_ERR(mmsys->regs); - dev_err(dev, "Failed to ioremap mmsys registers: %d\n", ret); - return ret; - } + if (IS_ERR(mmsys->regs)) + return dev_err_probe(dev, PTR_ERR(mmsys->regs), + "Failed to ioremap mmsys registers"); mmsys->data = of_device_get_match_data(&pdev->dev); @@ -413,10 +411,9 @@ static int mtk_mmsys_probe(struct platform_device *pdev) mmsys->rcdev.ops = &mtk_mmsys_reset_ops; mmsys->rcdev.of_node = pdev->dev.of_node; ret = devm_reset_controller_register(&pdev->dev, &mmsys->rcdev); - if (ret) { - dev_err(&pdev->dev, "Couldn't register mmsys reset controller: %d\n", ret); - return ret; - } + if (ret) + dev_err_probe(&pdev->dev, ret, + "Couldn't register mmsys reset controller"); } /* CMDQ is optional */