From patchwork Sat Aug 31 05:48:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Chan X-Patchwork-Id: 13785946 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4E03C5474C for ; Sat, 31 Aug 2024 05:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D/aYPkj2NtDergsDX2rHe3JcKu2TUi+kPfkt+iApdo8=; b=CJX+57S1JUXoHmE05l69nrsUom vpJEqJZ6AeVDv4Ulidk6p5412waV/p28EHYuEA/9ryoXfBprY+DZtQNIbopbF6J4BdohrRhuErE73 O70/eB7czRvXiuASkz7N2IpjttLLn07YqLDQxh8wl6jipY8RZMTtMdsAFVfo0iPz/lnYu+hUWLxyq yHKQtrVTfgvGScMrliTM6oqM3QCPJXoUj6gDiUnhRb7wrwbhmLz8PxbQlOnB3bJRd11P0+Kxmt6S+ 5E8LzIlScBMUD79GOcuBLhhwFnOSPegFfY0tbYJVMJSCsSBMuaTy5Yiff2rHrTmUomHLcwM0HBcMS 4Y8QUf/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skH9F-00000008fF0-3MUB; Sat, 31 Aug 2024 05:59:45 +0000 Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skH6p-00000008el0-3RBl for linux-arm-kernel@lists.infradead.org; Sat, 31 Aug 2024 05:57:16 +0000 Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-2055136b612so767215ad.0 for ; Fri, 30 Aug 2024 22:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725083835; x=1725688635; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D/aYPkj2NtDergsDX2rHe3JcKu2TUi+kPfkt+iApdo8=; b=VjjzQsGhajg5w6wS9FLgBXhRkPTGnNJ5hc4ny5P/ULV8bE9lZSE2Ks3Pz9/Dr14px9 oi6f1mY7G0d/QAMfI3qBnXOaKgsHMqFVOljunjOqkewzQfjxwyvfVt+YWugcPMVCYQOw eMWHAPyX/RYTEysGEM1PovP0VDNJwPSURDc1Z8EtHofpZrjyNMWkjcEg7mfp4cyrNHJi kAyp64wkl7aavFdx62JiEtSKpTK80/NcZ6MwS2iJLPe2Dr4DtGroi8s+/nhHr3znv1wr q23bflUJv/oOzi4eAJL5jiBipQNigtxidYLEWCmBy7MVlppilE6gRPlyFQd5E/uBiD47 FEeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725083835; x=1725688635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D/aYPkj2NtDergsDX2rHe3JcKu2TUi+kPfkt+iApdo8=; b=IKrHAXm3lcv0epl7dTDHLrtOdi7s+/disVcDMcWwB5GRhJpf8EZiLYeunkOwuZn1V/ rmwt0aBwjUM6FcncjuZ30j2Q7Vewq7JZGv09z6h+o8B01mdd9dJQbjSoediw1sa1Q3+R v6DciHrWluScpshT+m6DcpDHUxMZ5e3K774iYASXv05Tu/8dB3+0hdVqUn6FUYZCnELv jRBXHcxaDFiNyqk/0BZ38UN0eU4b4Cuh1VYbm8OfdDvj7giqkTwFLg4yAXkBEaRMeMxu FRPIJbHvyVs22/hJ6PBELqWDLGuB6/8svbAhMXuzetZ3hlWiLg28SAMrNkvpL9nEZJUl nQzQ== X-Forwarded-Encrypted: i=1; AJvYcCUSTz88AyGCGnStlRsud8kBRFNvJQ2CtdiJNFJ+UsvlukDGdtK3u+BD1XscYGFXa8uzogUweMOtsFs93Gm7OiW8@lists.infradead.org X-Gm-Message-State: AOJu0Yy3Dbaokkwil4VSDlxpLzuUX1EmW1h4sQ2GaQetyElFHStHwrT7 XoxAv+njs9LycOd6f64g+etAtkQ7VogEmIu/Yo3Yt66yAqD/x3oZ X-Google-Smtp-Source: AGHT+IGMvuTVKZ6LSJxB8CtCU4+d+sEou4o2/Fylk2vt34a2ffeFEJ4j/x7jh+K22k3uivREqt3WOA== X-Received: by 2002:a17:902:d545:b0:1fd:9e6e:7c1f with SMTP id d9443c01a7336-20546b553bdmr14689055ad.56.1725083835095; Fri, 30 Aug 2024 22:57:15 -0700 (PDT) Received: from localhost.localdomain ([59.188.211.160]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2053aa8cb4asm12027045ad.271.2024.08.30.22.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Aug 2024 22:57:14 -0700 (PDT) From: Nick Chan To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, konrad.dybcio@somainline.org Cc: ~postmarketos/upstreaming@lists.sr.ht, Nick Chan Subject: [PATCH v2 2/4] irqchip/apple-aic: Skip unnecessary setting of use_fast_ipi Date: Sat, 31 Aug 2024 13:48:17 +0800 Message-ID: <20240831055605.3542-3-towinchenmi@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240831055605.3542-1-towinchenmi@gmail.com> References: <20240831055605.3542-1-towinchenmi@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240830_225715_876325_6933C91F X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org use_fast_ipi is true by default and there is no need to "enable" it. Signed-off-by: Nick Chan Acked-by: Sven Peter --- drivers/irqchip/irq-apple-aic.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c index 5c534d9fd2b0..8d81d5fb3c50 100644 --- a/drivers/irqchip/irq-apple-aic.c +++ b/drivers/irqchip/irq-apple-aic.c @@ -987,9 +987,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p off += sizeof(u32) * (irqc->max_irq >> 5); /* MASK_CLR */ off += sizeof(u32) * (irqc->max_irq >> 5); /* HW_STATE */ - if (irqc->info.fast_ipi) - static_branch_enable(&use_fast_ipi); - else + if (!irqc->info.fast_ipi) static_branch_disable(&use_fast_ipi); irqc->info.die_stride = off - start_off;